From: sashiko-bot@kernel.org
To: "Gaurav Kohli" <gaurav.kohli@oss.qualcomm.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v6 9/9] arm64: dts: qcom: hamoa: Enable CDSP cooling
Date: Mon, 27 Jul 2026 14:36:33 +0000 [thread overview]
Message-ID: <20260727143633.879FC1F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260727-b4-qmi-tmd-v6-9-973cd3a226af@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims to set up CDSP cooling for 'both instances', but the patch actually configures 4 NSP thermal zones mapping to a single CDSP instance.
--
--- Patch [9]: [PATCH v6 9/9] arm64: dts: qcom: hamoa: Enable CDSP cooling ---
commit 11f46654cec2615152b5d3c181397f2d61caf2f7
Author: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
arm64: dts: qcom: hamoa: Enable CDSP cooling
This commit enables CDSP cooling for the hamoa platform. It configures
a polling delay for passive cooling and maps thermal zones to the CDSP
cooling device to throttle it when high temperatures are reached.
> Set up CDSP cooling for both instances by throttling the cdsp, when
> it reaches 95°C.
[Severity: Medium]
This isn't a bug, but there appears to be a mismatch between the commit
message and the actual code changes. The description mentions setting up
cooling for "both instances", which implies two instances.
However, the patch actually configures four NSP thermal zones (nsp0 through
nsp3) that all map to a single remoteproc_cdsp node in
arch/arm64/boot/dts/qcom/hamoa.dtsi.
Could the commit message be updated to accurately reflect the correct
number of instances and thermal zones being configured?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-b4-qmi-tmd-v6-0-973cd3a226af@oss.qualcomm.com?part=9
prev parent reply other threads:[~2026-07-27 14:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 14:22 [PATCH v6 0/9] Add support for Qualcomm remoteproc subsystem cooling Gaurav Kohli
2026-07-27 14:22 ` [PATCH v6 1/9] dt-bindings: remoteproc: qcom,pas: add #cooling-cells property Gaurav Kohli
2026-07-27 14:22 ` [PATCH v6 2/9] soc: qcom: Add QMI TMD support for remote thermal mitigation Gaurav Kohli
2026-07-27 14:40 ` sashiko-bot
2026-07-27 14:22 ` [PATCH v6 3/9] remoteproc: qcom: pas: add support for TMD thermal cooling devices Gaurav Kohli
2026-07-27 14:37 ` sashiko-bot
2026-07-27 21:55 ` Daniel Lezcano
2026-07-27 14:22 ` [PATCH v6 4/9] remoteproc: qcom_q6v5_pas: enable QMI TMD cooling support Gaurav Kohli
2026-07-27 14:22 ` [PATCH v6 5/9] arm64: dts: qcom: kodiak: Enable CDSP & Modem cooling Gaurav Kohli
2026-07-27 14:22 ` [PATCH v6 6/9] arm64: dts: qcom: lemans: Enable CDSP cooling Gaurav Kohli
2026-07-27 14:22 ` [PATCH v6 7/9] arm64: dts: qcom: talos: " Gaurav Kohli
2026-07-27 14:22 ` [PATCH v6 8/9] arm64: dts: qcom: monaco: " Gaurav Kohli
2026-07-27 14:22 ` [PATCH v6 9/9] arm64: dts: qcom: hamoa: " Gaurav Kohli
2026-07-27 14:36 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260727143633.879FC1F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gaurav.kohli@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.