Re: [PATCH v6 3/9] remoteproc: qcom: pas: add support for TMD thermal cooling devices

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect teardown order of the TMD client relative to the remoteproc device in `qcom_pas_remove()`.
--

--- Patch [3]: [PATCH v6 3/9] remoteproc: qcom: pas: add support for TMD thermal cooling devices ---
commit 96a80a2d7479048c20fb270197f15552907de3de
Author: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>

remoteproc: qcom: pas: add support for TMD thermal cooling devices

This commit registers Thermal Mitigation Devices (TMDs) for PAS-managed
remote processors to enable thermal throttling through QMI.

> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index 25599d7282083..07336a2d75f73 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
[ ... ]
> @@ -960,6 +1045,9 @@ static void qcom_pas_remove(struct platform_device *pdev)
>  	if (pas->bam_dmux)
>  		of_platform_device_destroy(&pas->bam_dmux->dev, NULL);
>  
> +	if (pas->tmd_inst)
> +		qmi_tmd_exit(pas->tmd_inst);
> +
>  	rproc_del(pas->rproc);

[Severity: Low]
Does this sequence unregister the thermal mitigation cooling device in the
wrong order?

Looking at qcom_pas_probe(), qcom_pas_setup_tmd() is called before rproc_add().
Should qmi_tmd_exit() be called after rproc_del() in qcom_pas_remove()
to maintain strict reverse-initialization ordering?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-b4-qmi-tmd-v6-0-973cd3a226af@oss.qualcomm.com?part=3