All of lore.kernel.org
 help / color / mirror / Atom feed
From: SJ Park <sj@kernel.org>
Cc: SJ Park <sj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	damon@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [RFC PATCH v2.2 13/17] mm/damon/sysfs: pass preps to DAMON core
Date: Mon, 27 Jul 2026 21:12:34 -0700	[thread overview]
Message-ID: <20260728041242.187380-14-sj@kernel.org> (raw)
In-Reply-To: <20260728041242.187380-1-sj@kernel.org>

DAMON sysfs interface provides the files for setting DAMON probe preps.
But the underlying code is not really passing the user-set values to
DAMON core.  Pass those.

Signed-off-by: SJ Park <sj@kernel.org>
---
 mm/damon/sysfs.c | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
index c0130843223d7..d02f5f8ceae5b 100644
--- a/mm/damon/sysfs.c
+++ b/mm/damon/sysfs.c
@@ -2176,6 +2176,23 @@ static int damon_sysfs_set_attrs(struct damon_ctx *ctx,
 	return damon_set_attrs(ctx, &attrs);
 }
 
+static int damon_sysfs_set_preps(struct damon_probe *probe,
+		struct damon_sysfs_preps *sys_preps)
+{
+	int i;
+
+	for (i = 0; i < sys_preps->nr; i++) {
+		struct damon_sysfs_prep *sys_prep = sys_preps->preps_arr[i];
+		struct damon_prep *prep;
+
+		prep = damon_new_prep(sys_prep->action);
+		if (!prep)
+			return -ENOMEM;
+		damon_add_prep(probe, prep);
+	}
+	return 0;
+}
+
 static int damon_sysfs_set_filters(struct damon_probe *probe,
 		struct damon_sysfs_filters *sys_filters)
 {
@@ -2211,7 +2228,15 @@ static int damon_sysfs_set_probe(struct damon_probe *probe,
 		struct damon_sysfs_probe *sys_probe)
 {
 	struct damon_sysfs_filters *sys_filters;
+	struct damon_sysfs_preps *sys_preps;
+	int err;
 
+	sys_preps = sys_probe->preps;
+	if (sys_preps) {
+		err = damon_sysfs_set_preps(probe, sys_preps);
+		if (err)
+			return err;
+	}
 	sys_filters = sys_probe->filters;
 	if (!sys_filters)
 		return 0;
-- 
2.47.3

  parent reply	other threads:[~2026-07-28  4:12 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-28  4:12 [RFC PATCH v2.2 00/17] mm/damon: introduce data access-as-a-data attribute SJ Park
2026-07-28  4:12 ` [RFC PATCH v2.2 01/17] mm/damon/core: introduce DAMON_FILTER_TYPE_PGIDLE_UNSET SJ Park
2026-07-28  4:23   ` sashiko-bot
2026-07-28  4:49     ` SJ Park
2026-07-28  4:12 ` [RFC PATCH v2.2 02/17] mm/damon/paddr: support PGIDLE_UNSET probe filter type SJ Park
2026-07-28  4:32   ` sashiko-bot
2026-07-28  4:52     ` SJ Park
2026-07-28  4:12 ` [RFC PATCH v2.2 03/17] mm/damon/sysfs: support pgidle_unset " SJ Park
2026-07-28  4:12 ` [RFC PATCH v2.2 04/17] Docs/mm/damon/design: document " SJ Park
2026-07-28  4:12 ` [RFC PATCH v2.2 05/17] mm/damon/core: introduce damon_prep struct SJ Park
2026-07-28  4:25   ` sashiko-bot
2026-07-28  4:54     ` SJ Park
2026-07-28  4:12 ` [RFC PATCH v2.2 06/17] mm/damon/core: commit preps SJ Park
2026-07-28  4:12 ` [RFC PATCH v2.2 07/17] mm/damon/core: introduce damon_operations->prep_probes() SJ Park
2026-07-28  4:12 ` [RFC PATCH v2.2 08/17] mm/damon/paddr: support damon_prep SJ Park
2026-07-28  4:24   ` sashiko-bot
2026-07-28  4:56     ` SJ Park
2026-07-28  4:12 ` [RFC PATCH v2.2 09/17] mm/damon/sysfs: implement preps directory SJ Park
2026-07-28  4:12 ` [RFC PATCH v2.2 10/17] mm/damon/sysfs: implement preps/nr_preps file SJ Park
2026-07-28  4:12 ` [RFC PATCH v2.2 11/17] mm/damon/sysfs: create directories for nr_preps writes SJ Park
2026-07-28  4:12 ` [RFC PATCH v2.2 12/17] mm/damon/sysfs: implement prep_action file SJ Park
2026-07-28  4:23   ` sashiko-bot
2026-07-28  4:58     ` SJ Park
2026-07-28  4:12 ` SJ Park [this message]
2026-07-28  4:12 ` [RFC PATCH v2.2 14/17] selftests/damon/sysfs.sh: test probe prep sysfs files SJ Park
2026-07-28  4:12 ` [RFC PATCH v2.2 15/17] Docs/mm/damon/design: document probe preps SJ Park
2026-07-28  4:12 ` [RFC PATCH v2.2 16/17] Docs/admin-guide/mm/damon/usage: document probe preps sysfs files SJ Park
2026-07-28  4:12 ` [RFC PATCH v2.2 17/17] Docs/ABI/damon: document probe prep " SJ Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260728041242.187380-14-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.