From: SJ Park <sj@kernel.org>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [RFC PATCH v2.2 11/17] mm/damon/sysfs: create directories for nr_preps writes
Date: Mon, 27 Jul 2026 21:12:32 -0700 [thread overview]
Message-ID: <20260728041242.187380-12-sj@kernel.org> (raw)
In-Reply-To: <20260728041242.187380-1-sj@kernel.org>
Implement nr_preps write action to actually create subdirectories of the
number. Each of the directory will be evolved to represent each probe
preparation action.
Signed-off-by: SJ Park <sj@kernel.org>
---
mm/damon/sysfs.c | 80 +++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 79 insertions(+), 1 deletion(-)
diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
index 38affef08d0fb..afd39659d6b84 100644
--- a/mm/damon/sysfs.c
+++ b/mm/damon/sysfs.c
@@ -750,12 +750,50 @@ static const struct kobj_type damon_sysfs_intervals_ktype = {
.default_groups = damon_sysfs_intervals_groups,
};
+/*
+ * prep directory
+ */
+
+struct damon_sysfs_prep {
+ struct kobject kobj;
+};
+
+static struct damon_sysfs_prep *damon_sysfs_prep_alloc(void)
+{
+ struct damon_sysfs_prep *prep;
+
+ prep = kzalloc_obj(struct damon_sysfs_prep);
+ if (!prep)
+ return prep;
+ return prep;
+}
+
+static void damon_sysfs_prep_release(struct kobject *kobj)
+{
+ struct damon_sysfs_prep *prep = container_of(kobj,
+ struct damon_sysfs_prep, kobj);
+
+ kfree(prep);
+}
+
+static struct attribute *damon_sysfs_prep_attrs[] = {
+ NULL,
+};
+ATTRIBUTE_GROUPS(damon_sysfs_prep);
+
+static const struct kobj_type damon_sysfs_prep_ktype = {
+ .release = damon_sysfs_prep_release,
+ .sysfs_ops = &kobj_sysfs_ops,
+ .default_groups = damon_sysfs_prep_groups,
+};
+
/*
* preps directory
*/
struct damon_sysfs_preps {
struct kobject kobj;
+ struct damon_sysfs_prep **preps_arr;
int nr;
};
@@ -766,13 +804,53 @@ static struct damon_sysfs_preps *damon_sysfs_preps_alloc(void)
static void damon_sysfs_preps_rm_dirs(struct damon_sysfs_preps *preps)
{
+ struct damon_sysfs_prep **preps_arr = preps->preps_arr;
+ int i;
+
+ for (i = 0; i < preps->nr; i++) {
+ kobject_del(&preps_arr[i]->kobj);
+ kobject_put(&preps_arr[i]->kobj);
+ }
preps->nr = 0;
+ kfree(preps_arr);
+ preps->preps_arr = NULL;
}
static int damon_sysfs_preps_add_dirs(struct damon_sysfs_preps *preps,
int nr_preps)
{
- preps->nr = nr_preps;
+ struct damon_sysfs_prep **preps_arr, *prep;
+ int err, i;
+
+ damon_sysfs_preps_rm_dirs(preps);
+ if (!nr_preps)
+ return 0;
+
+ preps_arr = kmalloc_objs(*preps_arr, nr_preps,
+ GFP_KERNEL | __GFP_NOWARN);
+ if (!preps_arr)
+ return -ENOMEM;
+ preps->preps_arr = preps_arr;
+
+ for (i = 0; i < nr_preps; i++) {
+ prep = damon_sysfs_prep_alloc();
+ if (!prep) {
+ damon_sysfs_preps_rm_dirs(preps);
+ return -ENOMEM;
+ }
+
+ err = kobject_init_and_add(&prep->kobj,
+ &damon_sysfs_prep_ktype, &preps->kobj, "%d",
+ i);
+ if (err) {
+ kobject_put(&prep->kobj);
+ damon_sysfs_preps_rm_dirs(preps);
+ return err;
+ }
+
+ preps_arr[i] = prep;
+ preps->nr++;
+ }
return 0;
}
--
2.47.3
next prev parent reply other threads:[~2026-07-28 4:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 4:12 [RFC PATCH v2.2 00/17] mm/damon: introduce data access-as-a-data attribute SJ Park
2026-07-28 4:12 ` [RFC PATCH v2.2 01/17] mm/damon/core: introduce DAMON_FILTER_TYPE_PGIDLE_UNSET SJ Park
2026-07-28 4:23 ` sashiko-bot
2026-07-28 4:49 ` SJ Park
2026-07-28 4:12 ` [RFC PATCH v2.2 02/17] mm/damon/paddr: support PGIDLE_UNSET probe filter type SJ Park
2026-07-28 4:32 ` sashiko-bot
2026-07-28 4:52 ` SJ Park
2026-07-28 4:12 ` [RFC PATCH v2.2 03/17] mm/damon/sysfs: support pgidle_unset " SJ Park
2026-07-28 4:12 ` [RFC PATCH v2.2 04/17] Docs/mm/damon/design: document " SJ Park
2026-07-28 4:12 ` [RFC PATCH v2.2 05/17] mm/damon/core: introduce damon_prep struct SJ Park
2026-07-28 4:25 ` sashiko-bot
2026-07-28 4:54 ` SJ Park
2026-07-28 4:12 ` [RFC PATCH v2.2 06/17] mm/damon/core: commit preps SJ Park
2026-07-28 4:12 ` [RFC PATCH v2.2 07/17] mm/damon/core: introduce damon_operations->prep_probes() SJ Park
2026-07-28 4:12 ` [RFC PATCH v2.2 08/17] mm/damon/paddr: support damon_prep SJ Park
2026-07-28 4:24 ` sashiko-bot
2026-07-28 4:56 ` SJ Park
2026-07-28 4:12 ` [RFC PATCH v2.2 09/17] mm/damon/sysfs: implement preps directory SJ Park
2026-07-28 4:12 ` [RFC PATCH v2.2 10/17] mm/damon/sysfs: implement preps/nr_preps file SJ Park
2026-07-28 4:12 ` SJ Park [this message]
2026-07-28 4:12 ` [RFC PATCH v2.2 12/17] mm/damon/sysfs: implement prep_action file SJ Park
2026-07-28 4:23 ` sashiko-bot
2026-07-28 4:58 ` SJ Park
2026-07-28 4:12 ` [RFC PATCH v2.2 13/17] mm/damon/sysfs: pass preps to DAMON core SJ Park
2026-07-28 4:12 ` [RFC PATCH v2.2 14/17] selftests/damon/sysfs.sh: test probe prep sysfs files SJ Park
2026-07-28 4:12 ` [RFC PATCH v2.2 15/17] Docs/mm/damon/design: document probe preps SJ Park
2026-07-28 4:12 ` [RFC PATCH v2.2 16/17] Docs/admin-guide/mm/damon/usage: document probe preps sysfs files SJ Park
2026-07-28 4:12 ` [RFC PATCH v2.2 17/17] Docs/ABI/damon: document probe prep " SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728041242.187380-12-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.