All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: changfengnan <changfengnan@bytedance.com>
Cc: linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
	Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	Sagi Grimberg <sagi@grimberg.me>,
	Bart Van Assche <bvanassche@acm.org>,
	Andy Shevchenko <andriy.shevchenko@intel.com>,
	Thomas Gleixner <tglx@kernel.org>, Jun Zeng <jun1.zeng@intel.com>,
	Gang Cao <gang.cao@intel.com>, Jun I Jin <jun.i.jin@intel.com>,
	Liang A Fang <liang.a.fang@intel.com>,
	Yong Hu <yong.hu@intel.com>,
	linux-kernel@vger.kernel.org, Guzebing <guzebing@bytedance.com>
Subject: Re: [RFC PATCH] nvme-pci: adaptively poll completions on busy queues
Date: Tue, 28 Jul 2026 06:44:09 +0200	[thread overview]
Message-ID: <20260728044409.GA20140@lst.de> (raw)
In-Reply-To: <d9210bcdf73fbe1ac8b6ec132865609a3ed68688.2c741811.b6d1.4c47.8747.ba7d54957ca3@bytedance.com>

On Tue, Jul 28, 2026 at 10:24:52AM +0800, changfengnan wrote:
> The patch showed 50 confirmed throughput improvements, with a median gain of 25.2%
> and a maximum gain of 63.0%. Only five cases showed confirmed regressions;

Can you drill down into the regression and figure out why they happen
and if we can mitigate them?  It would be nice if we could find a way
to avoid major regressions and enable the adaptive mode by default.



  reply	other threads:[~2026-07-28  4:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23 12:05 [RFC PATCH] nvme-pci: adaptively poll completions on busy queues Fengnan Chang
2026-07-23 12:14 ` changfengnan
2026-07-23 14:46 ` Keith Busch
2026-07-28  2:24 ` changfengnan
2026-07-28  4:44   ` Christoph Hellwig [this message]
2026-07-28  6:19     ` changfengnan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260728044409.GA20140@lst.de \
    --to=hch@lst.de \
    --cc=andriy.shevchenko@intel.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=changfengnan@bytedance.com \
    --cc=gang.cao@intel.com \
    --cc=guzebing@bytedance.com \
    --cc=jun.i.jin@intel.com \
    --cc=jun1.zeng@intel.com \
    --cc=kbusch@kernel.org \
    --cc=liang.a.fang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=tglx@kernel.org \
    --cc=yong.hu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.