From: Keith Busch <kbusch@kernel.org>
To: Fengnan Chang <changfengnan@bytedance.com>
Cc: linux-nvme@lists.infradead.org, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Bart Van Assche <bvanassche@acm.org>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Thomas Gleixner <tglx@kernel.org>, Jun Zeng <jun1.zeng@intel.com>,
Gang Cao <gang.cao@intel.com>, Jun I Jin <jun.i.jin@intel.com>,
Liang A Fang <liang.a.fang@intel.com>,
Yong Hu <yong.hu@intel.com>,
linux-kernel@vger.kernel.org, Guzebing <guzebing@bytedance.com>
Subject: Re: [RFC PATCH] nvme-pci: adaptively poll completions on busy queues
Date: Thu, 23 Jul 2026 08:46:21 -0600 [thread overview]
Message-ID: <amIpPcMAClxDbaiU@kbusch-mbp> (raw)
In-Reply-To: <20260723120556.58670-1-changfengnan@bytedance.com>
On Thu, Jul 23, 2026 at 08:05:56PM +0800, Fengnan Chang wrote:
> +static void nvme_adaptive_mask_irq(struct nvme_queue *nvmeq, int irq)
> +{
> + struct nvme_dev *dev = nvmeq->dev;
> + struct pci_dev *pdev = to_pci_dev(dev->dev);
> +
> + if (pdev->msi_enabled) {
> + writel(BIT(nvmeq->cq_vector), dev->bar + NVME_REG_INTMS);
> + readl(dev->bar + NVME_REG_INTMS);
Why do you have the readl? That's not necesary.
> + } else {
> + disable_irq_nosync(irq);
> + }
> +}
> +
> +static void nvme_adaptive_unmask_irq(struct nvme_queue *nvmeq, int irq)
> +{
> + struct nvme_dev *dev = nvmeq->dev;
> + struct pci_dev *pdev = to_pci_dev(dev->dev);
> +
> + clear_bit(NVMEQ_ADAPTIVE_POLLING, &nvmeq->flags);
> + if (pdev->msi_enabled) {
> + writel(BIT(nvmeq->cq_vector), dev->bar + NVME_REG_INTMC);
> + readl(dev->bar + NVME_REG_INTMS);
Same here.
next prev parent reply other threads:[~2026-07-23 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 12:05 [RFC PATCH] nvme-pci: adaptively poll completions on busy queues Fengnan Chang
2026-07-23 12:14 ` changfengnan
2026-07-23 14:46 ` Keith Busch [this message]
2026-07-28 2:24 ` changfengnan
2026-07-28 4:44 ` Christoph Hellwig
2026-07-28 6:19 ` changfengnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amIpPcMAClxDbaiU@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=changfengnan@bytedance.com \
--cc=gang.cao@intel.com \
--cc=guzebing@bytedance.com \
--cc=hch@lst.de \
--cc=jun.i.jin@intel.com \
--cc=jun1.zeng@intel.com \
--cc=liang.a.fang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=tglx@kernel.org \
--cc=yong.hu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.