* [PATCH v2] thunderbolt: Remove redundant dev_err_probe()
@ 2026-07-28 8:05 Pan Chuang
2026-07-28 11:56 ` Mika Westerberg
0 siblings, 1 reply; 2+ messages in thread
From: Pan Chuang @ 2026-07-28 8:05 UTC (permalink / raw)
To: Andreas Noever, Mika Westerberg, Yehezkel Bernat,
open list:THUNDERBOLT DRIVER, open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/thunderbolt/pci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/thunderbolt/pci.c b/drivers/thunderbolt/pci.c
index dbb6badda867..8462ccb59b7e 100644
--- a/drivers/thunderbolt/pci.c
+++ b/drivers/thunderbolt/pci.c
@@ -112,7 +112,6 @@ static int nhi_pci_init_msi(struct tb_nhi *nhi)
{
struct tb_nhi_pci *nhi_pci = nhi_to_pci(nhi);
struct pci_dev *pdev = to_pci_dev(nhi->dev);
- struct device *dev = &pdev->dev;
int res, irq, nvec;
ida_init(&nhi_pci->msix_ida);
@@ -139,7 +138,7 @@ static int nhi_pci_init_msi(struct tb_nhi *nhi)
res = devm_request_irq(&pdev->dev, irq, nhi_msi,
IRQF_NO_SUSPEND, "thunderbolt", nhi);
if (res)
- return dev_err_probe(dev, res, "request_irq failed, aborting\n");
+ return res;
}
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] thunderbolt: Remove redundant dev_err_probe()
2026-07-28 8:05 [PATCH v2] thunderbolt: Remove redundant dev_err_probe() Pan Chuang
@ 2026-07-28 11:56 ` Mika Westerberg
0 siblings, 0 replies; 2+ messages in thread
From: Mika Westerberg @ 2026-07-28 11:56 UTC (permalink / raw)
To: Pan Chuang
Cc: Andreas Noever, Mika Westerberg, Yehezkel Bernat,
open list:THUNDERBOLT DRIVER, open list
On Tue, Jul 28, 2026 at 04:05:48PM +0800, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err_probe() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
Applied to thunderbolt.git/next, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-28 11:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-28 8:05 [PATCH v2] thunderbolt: Remove redundant dev_err_probe() Pan Chuang
2026-07-28 11:56 ` Mika Westerberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.