Re: [PATCH 05/13] dt-bindings: clock: exynos8855: add peris clock definitions

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch adds an unrelated MMC clock definition (`FOUT_MMC_PLL_CLKOUT_DIV2`) in a commit strictly scoped to CMU_PERIS clocks.
--

--- Patch [5]: [PATCH 05/13] dt-bindings: clock: exynos8855: add peris clock definitions ---
commit 24dfca50d1a6c5c9117393c100c8d5214d55a23f
Author: raghav.s <raghav.s@samsung.com>
dt-bindings: clock: exynos8855: add peris clock definitions

This commit adds device tree clock binding definitions for CMU_PERIS.

[ ... ]

> diff --git a/include/dt-bindings/clock/samsung,exynos8855.h b/include/dt-bindings/clock/samsung,exynos8855.h
> index 14369b749fb25..9efaf3e330b42 100644
> --- a/include/dt-bindings/clock/samsung,exynos8855.h
> +++ b/include/dt-bindings/clock/samsung,exynos8855.h
> @@ -50,6 +50,11 @@
>  #define DOUT_SHARED4_DIV4		   38
>  #define FOUT_MMC_PLL_DIV1                  39
>  #define FOUT_MMC_PLL_DIV2                  40
> +#define CLKCMU_MOUT_PERIS_GIC              41
> +#define CLKCMU_MOUT_PERIS_NOC              42
> +#define CLKCMU_DOUT_PERIS_GIC              43
> +#define CLKCMU_DOUT_PERIS_NOC              44
> +#define FOUT_MMC_PLL_CLKOUT_DIV2           45

[Severity: Low]
The commit message explicitly states this patch is strictly scoped to adding
CMU_PERIS clock definitions, but FOUT_MMC_PLL_CLKOUT_DIV2 appears to be an
MMC clock definition. Is this macro intended for this commit, or did it
accidentally slip in during development?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260728121111.2077860-1-raghav.s@samsung.com?part=5