From: sashiko-bot@kernel.org
To: "Jishnu Prakash" <jishnu.prakash@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v4 3/4] arm64: dts: qcom: monaco-pmics: Add ADC support for PMM8620AU
Date: Tue, 28 Jul 2026 16:16:17 +0000 [thread overview]
Message-ID: <20260728161617.B98371F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260728-adc5_gen3_dt-v4-3-355f0edece77@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message inaccurately claims that both SID 0 and SID 2 are PMM8620AU PMIC instances, whereas the device tree correctly uses PMM8650AU for SID 2.
--
--- Patch [3]: [PATCH v4 3/4] arm64: dts: qcom: monaco-pmics: Add ADC support for PMM8620AU ---
commit 07dcd0ba34ae862d89be0793a9dab759b0361ee1
Author: Ayyagari Ushasreevalli <aushasre@qti.qualcomm.com>
arm64: dts: qcom: monaco-pmics: Add ADC support for PMM8620AU
This commit adds ADC nodes for PMIC instances on the Monaco platform. The
new nodes expose the die temperature and supply voltage channels.
> Add ADC nodes for PMM8620AU PMIC instances (SID 0 and SID 2)
> present on the Monaco platform.
[Severity: Medium]
Is this description accurate? The commit message states that both SID 0 and
SID 2 are PMM8620AU PMIC instances.
Looking at the added device tree nodes, the PMIC at SID 2 (pmic@2) is named
pmm8650au_1 and its ADC node is named pmm8650au_1_adc, which indicates it is
a PMM8650AU instance rather than PMM8620AU.
Could the commit message be updated to correctly reflect the hardware being
modified for SID 2?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260728-adc5_gen3_dt-v4-0-355f0edece77@oss.qualcomm.com?part=3
next prev parent reply other threads:[~2026-07-28 16:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 15:49 [PATCH v4 0/4] Add ADC support for lemans, monaco and hamoa Jishnu Prakash
2026-07-28 15:49 ` [PATCH v4 1/4] arm64: dts: qcom: Add header file for ADC5 Gen3 channel macros Jishnu Prakash
2026-07-28 16:00 ` sashiko-bot
2026-07-28 15:49 ` [PATCH v4 2/4] arm64: dts: qcom: lemans-pmics: Add ADC support for PMM8654au Jishnu Prakash
2026-07-28 15:49 ` [PATCH v4 3/4] arm64: dts: qcom: monaco-pmics: Add ADC support for PMM8620AU Jishnu Prakash
2026-07-28 16:16 ` sashiko-bot [this message]
2026-07-28 15:49 ` [PATCH v4 4/4] arm64: dts: qcom: hamoa-pmics: Add ADC support Jishnu Prakash
2026-07-28 16:29 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728161617.B98371F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jishnu.prakash@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.