All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Farman <farman@linux.ibm.com>
To: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
	Matthew Rosato <mjrosato@linux.ibm.com>,
	Eric Farman <farman@linux.ibm.com>
Subject: [PATCH v2 1/1] iotests/108: skip test if cannot access /dev/fuse
Date: Tue, 28 Jul 2026 21:26:44 +0200	[thread overview]
Message-ID: <20260728192644.2879028-2-farman@linux.ibm.com> (raw)
In-Reply-To: <20260728192644.2879028-1-farman@linux.ibm.com>

This test might fail if the user is not root (or sudo'd):

  fusermount3: failed to open .../scratch/qcow2-file-108/fuse-export: Permission denied

A check exists to try to cover for this, but there are
two potential error messages that signal this case
(per the comment block associated with the check) and
only a skip for one of them.

Update the common fuse check to include this message,
and update test 108 to utilize it.

Fixes: 9ffd6d646d ("iotests/108: Test new refcount rebuild algorithm")
Based-on: <20260715103451.1930909-1-den@openvz.org>
Signed-off-by: Eric Farman <farman@linux.ibm.com>
---
 tests/qemu-iotests/108       | 5 +----
 tests/qemu-iotests/common.rc | 1 +
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/tests/qemu-iotests/108 b/tests/qemu-iotests/108
index bf808b3512..5d91e58943 100755
--- a/tests/qemu-iotests/108
+++ b/tests/qemu-iotests/108
@@ -69,10 +69,7 @@ else
     # or "Invalid parameter 'fuse'", depending on whether there is
     # FUSE support or not.
     error=$($QSD --export fuse 2>&1)
-    if [[ $error = *"'fuse'"* ]]; then
-        _notrun 'Passwordless sudo for losetup or FUSE support required, but' \
-                'neither is available'
-    fi
+    _notrun_on_fuse_error "$error"
 fi
 
 echo
diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
index bcb1ec50a9..844c19d15a 100644
--- a/tests/qemu-iotests/common.rc
+++ b/tests/qemu-iotests/common.rc
@@ -986,6 +986,7 @@ _require_drivers()
 _notrun_on_fuse_error()
 {
     case "$1" in
+        *"Parameter 'id' is missing"* | \
         *"Parameter 'type' does not accept value 'fuse'"*)
             _notrun "No FUSE support"
             ;;
-- 
2.53.0



      reply	other threads:[~2026-07-28 19:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-28 19:26 [PATCH v2 0/1] qemu-iotests: One more fuse fix Eric Farman
2026-07-28 19:26 ` Eric Farman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260728192644.2879028-2-farman@linux.ibm.com \
    --to=farman@linux.ibm.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.