All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/1] qemu-iotests: One more fuse fix
@ 2026-07-28 19:26 Eric Farman
  2026-07-28 19:26 ` [PATCH v2 1/1] iotests/108: skip test if cannot access /dev/fuse Eric Farman
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Farman @ 2026-07-28 19:26 UTC (permalink / raw)
  To: Kevin Wolf, Hanna Reitz
  Cc: qemu-block, qemu-devel, Matthew Rosato, Eric Farman

Hi,

After learning about Denis' series of fuse fixes, there's still
one test that doesn't run on my system. The attached is a fix that
builds upon their changes to fix test 108 as well.

v1: https://lore.kernel.org/r/20260725125651.3896151-1-farman@linux.ibm.com/
v1->v2:
 - [KW] Rebase on https://lore.kernel.org/r/20260715103451.1930909-1-den@openvz.org/
   and drop two of the (now superfluous) patches

Eric Farman (1):
  iotests/108: skip test if cannot access /dev/fuse

 tests/qemu-iotests/108       | 5 +----
 tests/qemu-iotests/common.rc | 1 +
 2 files changed, 2 insertions(+), 4 deletions(-)

-- 
2.53.0



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH v2 1/1] iotests/108: skip test if cannot access /dev/fuse
  2026-07-28 19:26 [PATCH v2 0/1] qemu-iotests: One more fuse fix Eric Farman
@ 2026-07-28 19:26 ` Eric Farman
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Farman @ 2026-07-28 19:26 UTC (permalink / raw)
  To: Kevin Wolf, Hanna Reitz
  Cc: qemu-block, qemu-devel, Matthew Rosato, Eric Farman

This test might fail if the user is not root (or sudo'd):

  fusermount3: failed to open .../scratch/qcow2-file-108/fuse-export: Permission denied

A check exists to try to cover for this, but there are
two potential error messages that signal this case
(per the comment block associated with the check) and
only a skip for one of them.

Update the common fuse check to include this message,
and update test 108 to utilize it.

Fixes: 9ffd6d646d ("iotests/108: Test new refcount rebuild algorithm")
Based-on: <20260715103451.1930909-1-den@openvz.org>
Signed-off-by: Eric Farman <farman@linux.ibm.com>
---
 tests/qemu-iotests/108       | 5 +----
 tests/qemu-iotests/common.rc | 1 +
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/tests/qemu-iotests/108 b/tests/qemu-iotests/108
index bf808b3512..5d91e58943 100755
--- a/tests/qemu-iotests/108
+++ b/tests/qemu-iotests/108
@@ -69,10 +69,7 @@ else
     # or "Invalid parameter 'fuse'", depending on whether there is
     # FUSE support or not.
     error=$($QSD --export fuse 2>&1)
-    if [[ $error = *"'fuse'"* ]]; then
-        _notrun 'Passwordless sudo for losetup or FUSE support required, but' \
-                'neither is available'
-    fi
+    _notrun_on_fuse_error "$error"
 fi
 
 echo
diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
index bcb1ec50a9..844c19d15a 100644
--- a/tests/qemu-iotests/common.rc
+++ b/tests/qemu-iotests/common.rc
@@ -986,6 +986,7 @@ _require_drivers()
 _notrun_on_fuse_error()
 {
     case "$1" in
+        *"Parameter 'id' is missing"* | \
         *"Parameter 'type' does not accept value 'fuse'"*)
             _notrun "No FUSE support"
             ;;
-- 
2.53.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-07-28 19:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-28 19:26 [PATCH v2 0/1] qemu-iotests: One more fuse fix Eric Farman
2026-07-28 19:26 ` [PATCH v2 1/1] iotests/108: skip test if cannot access /dev/fuse Eric Farman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.