Re: [PATCH 2/3] riscv: dts: spacemit: Add a common board dtsi for Milk-V Jupiter boards

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch incorrectly removes the original authors' copyright headers from k1-milkv-jupiter.dts and replaces them with a single copyright claim by the patch author.
--

--- Patch [2]: [PATCH 2/3] riscv: dts: spacemit: Add a common board dtsi for Milk-V Jupiter boards ---
commit 97e4c73a96036da2bf4f3762abb7b076f18d6748
Author: Aurelien Jarno <aurelien@aurel32.net>

riscv: dts: spacemit: Add a common board dtsi for Milk-V Jupiter boards
    
This commit adds a common board dtsi file for the Milk-V Jupiter board
variants. It factors out common configurations into the new dtsi while
excluding CPU operating points, which are left for the specific board files.

[ ... ]
> diff --git a/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts b/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
> index 3c16d0c20050e..9c4aa4f8a533c 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
> @@ -1,471 +1,11 @@
>  // SPDX-License-Identifier: GPL-2.0 OR MIT
>  /*
> - * Copyright (C) 2024 Yangyu Chen <cyy@cyyself.name>
> - * Copyright (C) 2025 Javier Martinez Canillas <javierm@redhat.com>
> + * Copyright (C) 2026 Aurelien Jarno <aurelien@aurel32.net>
>   */

[Severity: Low]
This isn't a bug, but should the original authors' copyright headers be
retained here?

While the original copyright headers were correctly preserved in the newly
created k1-milkv-jupiter-common.dtsi file where the bulk of the code was
moved, standard practice is to retain the original attribution in the
existing file as well, alongside any new copyright claims.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260728211020.1248676-1-aurelien@aurel32.net?part=2