All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong via Linux-f2fs-devel" <linux-f2fs-devel@lists.sourceforge.net>
To: Chao Yu <chao@kernel.org>
Cc: jaegeuk@kernel.org, Zorro Lang <zlang@kernel.org>,
	fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v3] common/rc: support f2fs in _require_fanotify_ioerrors()
Date: Wed, 29 Jul 2026 08:47:21 -0700	[thread overview]
Message-ID: <20260729154721.GD7371@frogsfrogsfrogs> (raw)
In-Reply-To: <20260729094909.1499590-1-chao@kernel.org>

On Wed, Jul 29, 2026 at 09:49:09AM +0000, Chao Yu wrote:
> f2fs has supported to report fserror, this patch adds support for f2fs
> in _require_fanotify_ioerrors(), so that we can run generic/791 on f2fs.
> 
> Cc: Darrick J. Wong <djwong@kernel.org>
> Signed-off-by: Chao Yu <chao@kernel.org>

Looks fine to me,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
> v3:
> - fix to chech sysfs node correctly
>  common/rc | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/common/rc b/common/rc
> index 106f044ad..3a8f03412 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -6266,6 +6266,12 @@ _require_fanotify_ioerrors()
>  		x="$(_get_fs_sysfs_attr $TEST_DEV err_report_sec)"
>  		test -n "$x" && return 0
>  		;;
> +	f2fs)
> +		local feat_file="/sys/fs/f2fs/features/fserror"
> +		if [ -f "$feat_file" ] && [ "$(cat "$feat_file")" = "supported" ]; then
> +			return 0
> +		fi
> +		;;
>  	esac
>  
>  	_notrun "$FSTYP does not support fanotify ioerrors"
> -- 
> 2.49.0
> 
> 


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <djwong@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: Zorro Lang <zlang@kernel.org>,
	fstests@vger.kernel.org, jaegeuk@kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH v3] common/rc: support f2fs in _require_fanotify_ioerrors()
Date: Wed, 29 Jul 2026 08:47:21 -0700	[thread overview]
Message-ID: <20260729154721.GD7371@frogsfrogsfrogs> (raw)
In-Reply-To: <20260729094909.1499590-1-chao@kernel.org>

On Wed, Jul 29, 2026 at 09:49:09AM +0000, Chao Yu wrote:
> f2fs has supported to report fserror, this patch adds support for f2fs
> in _require_fanotify_ioerrors(), so that we can run generic/791 on f2fs.
> 
> Cc: Darrick J. Wong <djwong@kernel.org>
> Signed-off-by: Chao Yu <chao@kernel.org>

Looks fine to me,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
> v3:
> - fix to chech sysfs node correctly
>  common/rc | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/common/rc b/common/rc
> index 106f044ad..3a8f03412 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -6266,6 +6266,12 @@ _require_fanotify_ioerrors()
>  		x="$(_get_fs_sysfs_attr $TEST_DEV err_report_sec)"
>  		test -n "$x" && return 0
>  		;;
> +	f2fs)
> +		local feat_file="/sys/fs/f2fs/features/fserror"
> +		if [ -f "$feat_file" ] && [ "$(cat "$feat_file")" = "supported" ]; then
> +			return 0
> +		fi
> +		;;
>  	esac
>  
>  	_notrun "$FSTYP does not support fanotify ioerrors"
> -- 
> 2.49.0
> 
> 

  reply	other threads:[~2026-07-29 15:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29  9:49 [PATCH v3] common/rc: support f2fs in _require_fanotify_ioerrors() Chao Yu
2026-07-29  9:49 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-07-29 15:47 ` Darrick J. Wong via Linux-f2fs-devel [this message]
2026-07-29 15:47   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260729154721.GD7371@frogsfrogsfrogs \
    --to=linux-f2fs-devel@lists.sourceforge.net \
    --cc=chao@kernel.org \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.