Re: [PATCH v4 4/5] arm64: dts: renesas: add support for solidrun rzv2l som and hb-iiot evb

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The standalone `rzg2l-sr-som-emmc.dtbo` and `rzg2l-hummingboard-iiot-microsd.dtbo` overlay files are omitted from the `dtb-y` targets for `CONFIG_ARCH_R9A07G054`.
--

--- Patch [4]: [PATCH v4 4/5] arm64: dts: renesas: add support for solidrun rzv2l som and hb-iiot evb ---
commit e8396d770c29ff4a18cf3e6df93a8aacf55d42b9
Author: Josua Mayer <josua@solid-run.com>

arm64: dts: renesas: add support for solidrun rzv2l som and hb-iiot evb

This commit adds support for the SolidRun RZ/V2L SoM on the Hummingboard
IIoT. The RZ-V2L SoM shares its PCB with the RZ/G2L, differing primarily in
the SoC and the addition of a DRP-AI NPU.

> diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
> index e2af196e18bf6..5242eff76ef54 100644
> --- a/arch/arm64/boot/dts/renesas/Makefile
> +++ b/arch/arm64/boot/dts/renesas/Makefile
> @@ -189,6 +189,17 @@ dtb-$(CONFIG_ARCH_R9A07G044) += r9a07g044l2-smarc-cru-csi-ov5645.dtbo
>  r9a07g044l2-smarc-cru-csi-ov5645-dtbs := r9a07g044l2-smarc.dtb r9a07g044l2-smarc-cru-csi-ov5645.dtbo
>  dtb-$(CONFIG_ARCH_R9A07G044) += r9a07g044l2-smarc-cru-csi-ov5645.dtb
>  
> +dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-hummingboard-iiot.dtb
> +r9a07g054l2-hummingboard-iiot-emmc-dtbs := r9a07g054l2-hummingboard-iiot.dtb rzg2l-sr-som-emmc.dtbo
> +dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-hummingboard-iiot-emmc.dtb
> +r9a07g054l2-hummingboard-iiot-microsd-dtbs := r9a07g054l2-hummingboard-iiot.dtb rzg2l-hummingboard-iiot-microsd.dtbo
> +dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-hummingboard-iiot-microsd.dtb

[Severity: Medium]
Should the standalone rzg2l-sr-som-emmc.dtbo and 
rzg2l-hummingboard-iiot-microsd.dtbo overlay files be explicitly added
to the dtb-y targets here?

While Kbuild will correctly build the .dtbo dependencies for the composite
.dtb, make dtbs_install determines which files to install by strictly
including targets explicitly added to the dtb-y variable. 

If a user compiles a kernel strictly with CONFIG_ARCH_R9A07G054=y and
CONFIG_ARCH_R9A07G044=n, it appears these two overlays will be built as
intermediate objects but won't be installed by make dtbs_install,
leaving them unavailable for a bootloader to apply dynamically.

> +dtb-$(CONFIG_ARCH_R9A07G054) += rzg2l-hummingboard-iiot-rs485-a.dtbo
> +r9a07g054l2-hummingboard-iiot-rs485-a-dtbs := r9a07g054l2-hummingboard-iiot.dtb rzg2l-hummingboard-iiot-rs485-a.dtbo
> +dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-hummingboard-iiot-rs485-a.dtb

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260730-rzg2-sr-boards-v4-0-08bc459578dc@solid-run.com?part=4