Re: [PATCH v4 1/5] dt-bindings: soc: renesas: Add various SolidRun RZ/G2 based boards

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The bindings for SolidRun SoMs fail schema validation when used standalone, as they omit the 3-item compatible string configurations.
--

--- Patch [1]: [PATCH v4 1/5] dt-bindings: soc: renesas: Add various SolidRun RZ/G2 based boards ---
commit 5a8377d33a57f9f7e33e7aca8fc9422f672bf72b
Author: Josua Mayer <josua@solid-run.com>

dt-bindings: soc: renesas: Add various SolidRun RZ/G2 based boards

Add bindings for various SolidRun boards and System on Module built
around Renesas RZ/G2 family of SoCs.

> diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> index eeef34e3d7d07..1673005a3d930 100644
> --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> @@ -508,6 +508,14 @@ properties:

[ ... ]

> +      - description: SolidRun RZ/G2UL based boards
> +        items:
> +          - enum:
> +              - solidrun,rzg2ul-hummingboard-ripple # SolidRun RZ/G2UL HummingBoard Ripple
> +          - const: solidrun,rzg2ul-sr-som
> +          - const: renesas,r9a07g043u12 # RZ/G2UL Type-2
> +          - const: renesas,r9a07g043
> +

[Severity: Medium]
Will this schema definition break validation for standalone SolidRun SoMs?

The current schema items block mandates exactly 4 compatible strings, with the
first string being one of the carrier board enum values.

If a standalone SoM device tree is defined with 3 compatible strings (e.g.,
"solidrun,rzg2ul-sr-som", "renesas,r9a07g043u12", "renesas,r9a07g043"), it
appears it will fail validation because there is no matching 3-item array
block for the standalone SoM.

[ ... ]

> +      - description: SolidRun RZ/G2L based boards
> +        items:
> +          - enum:
> +              - solidrun,rzg2l-hummingboard-iiot   # SolidRun RZ/G2L HummingBoard IIoT
> +              - solidrun,rzg2l-hummingboard-pro    # SolidRun RZ/G2L HummingBoard Pro
> +              - solidrun,rzg2l-hummingboard-ripple # SolidRun RZ/G2L HummingBoard Ripple
> +          - const: solidrun,rzg2l-sr-som
> +          - const: renesas,r9a07g044l2 # Dual Cortex-A55 RZ/G2L
> +          - const: renesas,r9a07g044
> +

[Severity: Medium]
Does the standalone RZ/G2L SoM also require its own 3-item validation block
for the same reason?

Without it, standalone SoM configurations will likely fail dt_binding_check
and dtbs_check validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260730-rzg2-sr-boards-v4-0-08bc459578dc@solid-run.com?part=1