All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, uma.shankar@intel.com,
	ankit.k.nautiyal@intel.com, chaitanya.kumar.borah@intel.com
Subject: [PATCH v8 10/10] drm/i915/vrr: Enable cmrr
Date: Thu, 30 Jul 2026 16:29:17 +0530	[thread overview]
Message-ID: <20260730105919.3913412-11-mitulkumar.ajitkumar.golani@intel.com> (raw)
In-Reply-To: <20260730105919.3913412-1-mitulkumar.ajitkumar.golani@intel.com>

Set crtc_state->vrr.cmrr.enable at the end of
intel_vrr_cmrr_compute_config() so that CMRR is actually enabled once
the M/N parameters have been computed. This is the final step that
turns on CMRR, with all the parameter computation handled in the
earlier patches.

--v2:
- Everything else except enable compute to handle before this patch
(Chaitanya)

--v3:
- Remove redundant return from compute config

--v4:
- Update CMRR commit message (Chaitanya)

Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
---
 drivers/gpu/drm/i915/display/intel_vrr.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
index 653581ed4e90..e36db1174440 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -269,6 +269,8 @@ intel_vrr_cmrr_compute_config(struct intel_crtc_state *crtc_state)
 	adjusted_mode->crtc_vtotal = div64_u64_rem(dividend,
 						   crtc_state->vrr.cmrr.cmrr_n,
 						   &crtc_state->vrr.cmrr.cmrr_m);
+
+	crtc_state->vrr.cmrr.enable = true;
 }
 
 static
-- 
2.48.1


  parent reply	other threads:[~2026-07-30 11:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30 10:59 [PATCH v8 00/10] Enable CMRR in fixed-RR VRR path Mitul Golani
2026-07-30 10:59 ` [PATCH v8 01/10] drm/i915/psr: Do not enable PSR2 when CMRR is enabled Mitul Golani
2026-07-30 10:59 ` [PATCH v8 02/10] drm/i915/vrr: Restrict CMRR enable condition to VRR-TG-default platforms Mitul Golani
2026-07-30 10:59 ` [PATCH v8 03/10] drm/i915/vrr: Add per-CRTC vrr/cmrr debugfs control Mitul Golani
2026-07-30 10:59 ` [PATCH v8 04/10] drm/i915/vrr: Update AS_SDP target_rr_divider based on CMRR config request Mitul Golani
2026-07-30 10:59 ` [PATCH v8 05/10] drm/i915/display: Move CMRR crtc_state members under VRR Mitul Golani
2026-07-30 10:59 ` [PATCH v8 06/10] drm/i915/vrr: Compute CMRR fractional timings generically Mitul Golani
2026-07-30 10:59 ` [PATCH v8 07/10] drm/i915/vrr: Latch CMRR ratio via atomic commit on debugfs write Mitul Golani
2026-07-31  9:43   ` Borah, Chaitanya Kumar
2026-07-30 10:59 ` [PATCH v8 08/10] drm/i915/vrr: Program CMRR enable/disable from transcoder timings Mitul Golani
2026-07-30 10:59 ` [PATCH v8 09/10] drm/i915/vrr: Dump CMRR state in the crtc state dump Mitul Golani
2026-07-30 10:59 ` Mitul Golani [this message]
2026-07-31  9:45   ` [PATCH v8 10/10] drm/i915/vrr: Enable cmrr Borah, Chaitanya Kumar
2026-07-30 11:58 ` ✓ CI.KUnit: success for Enable CMRR in fixed-RR VRR path (rev8) Patchwork
2026-07-30 12:45 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-30 13:03 ` ✗ i915.CI.BAT: failure for Enable CMRR in fixed-RR VRR path (rev9) Patchwork
2026-07-30 20:50   ` Golani, Mitulkumar Ajitkumar
2026-07-30 15:22 ` ✓ Xe.CI.FULL: success for Enable CMRR in fixed-RR VRR path (rev8) Patchwork
2026-07-31  4:40 ` ✓ i915.CI.BAT: success for Enable CMRR in fixed-RR VRR path (rev9) Patchwork
2026-07-31  6:54 ` ✓ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260730105919.3913412-11-mitulkumar.ajitkumar.golani@intel.com \
    --to=mitulkumar.ajitkumar.golani@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=uma.shankar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.