[PATCH 0/2] smb/server: fix memory leak bugs

[PATCH 0/2] smb/server: fix memory leak bugs

[ZhangGuoDong]

From: ZhangGuoDong <zhangguodong@kylinos.cn>

ZhangGuoDong (2):
  smb/server: fix memory leak in ksmbd_krb5_authenticate()
  smb/server: fix memory leak in ksmbd_login_user()

 fs/smb/server/auth.c             | 1 +
 fs/smb/server/mgmt/user_config.c | 1 +
 2 files changed, 2 insertions(+)

-- 
2.43.0

[PATCH 1/2] smb/server: fix memory leak in ksmbd_krb5_authenticate()

[ZhangGuoDong]

From: ZhangGuoDong <zhangguodong@kylinos.cn>

ksmbd_ipc_login_request_ext() returns an independently allocated
response. ksmbd_alloc_user() copies the supplementary group IDs from
the response, but ksmbd_krb5_authenticate() does not release it.

Free the extended response after ksmbd_alloc_user() has finished with
it.

Signed-off-by: ZhangGuoDong <zhangguodong@kylinos.cn>
Reviewed-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
---
 fs/smb/server/auth.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/smb/server/auth.c b/fs/smb/server/auth.c
index 4e7b6f0e6b8c..e886ea5681ca 100644
--- a/fs/smb/server/auth.c
+++ b/fs/smb/server/auth.c
@@ -464,6 +464,7 @@ int ksmbd_krb5_authenticate(struct ksmbd_session *sess, char *in_blob,
 	*out_len = resp->spnego_blob_len;
 	retval = 0;
 out:
+	kvfree(resp_ext);
 	kvfree(resp);
 	return retval;
 }
-- 
2.43.0

[PATCH 2/2] smb/server: fix memory leak in ksmbd_login_user()

[ZhangGuoDong]

From: ZhangGuoDong <zhangguodong@kylinos.cn>

ksmbd_ipc_login_request_ext() returns an independently allocated
response. ksmbd_alloc_user() copies the supplementary group IDs from
the response, but ksmbd_login_user() does not release it.

Free the extended response after ksmbd_alloc_user() has finished with
it.

Signed-off-by: ZhangGuoDong <zhangguodong@kylinos.cn>
Reviewed-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
---
 fs/smb/server/mgmt/user_config.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/smb/server/mgmt/user_config.c b/fs/smb/server/mgmt/user_config.c
index cf45841d9d1b..21b1d51d918b 100644
--- a/fs/smb/server/mgmt/user_config.c
+++ b/fs/smb/server/mgmt/user_config.c
@@ -27,6 +27,7 @@ struct ksmbd_user *ksmbd_login_user(const char *account)
 
 	user = ksmbd_alloc_user(resp, resp_ext);
 out:
+	kvfree(resp_ext);
 	kvfree(resp);
 	return user;
 }
-- 
2.43.0

Re: [PATCH 0/2] smb/server: fix memory leak bugs

[Namjae Jeon]

On Fri, Jul 31, 2026 at 11:43 AM ZhangGuoDong <zhang.guodong@linux.dev> wrote:
>
> From: ZhangGuoDong <zhangguodong@kylinos.cn>
>
> ZhangGuoDong (2):
>   smb/server: fix memory leak in ksmbd_krb5_authenticate()
>   smb/server: fix memory leak in ksmbd_login_user()
Enzo previously sent the same patch, and it is currently applied to
ksmbd-for-next-next.

https://github.com/smfrench/smb3-kernel/commit/151d00564ce5b643ed8e9e9343bd21f1073386eb

Thanks.
>
>  fs/smb/server/auth.c             | 1 +
>  fs/smb/server/mgmt/user_config.c | 1 +
>  2 files changed, 2 insertions(+)
>
> --
> 2.43.0
>