All of lore.kernel.org
 help / color / mirror / Atom feed
* [agd5f:drm-fixes-7.2 14/28] drivers/gpu/drm/amd/amdgpu/psp_v15_0.c:149 psp_v15_0_0_ring_create() warn: inconsistent indenting
@ 2026-07-30 19:33 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-07-30 19:33 UTC (permalink / raw)
  To: Shubhankar Milind Sardeshpande
  Cc: oe-kbuild-all, Alex Deucher, Pratik Vishwakarma,
	Mario Limonciello (AMD)

tree:   https://gitlab.freedesktop.org/agd5f/linux.git drm-fixes-7.2
head:   114b42507b6a23d9d24e24e4ef165233332c64d4
commit: a8d234a1133f02bfbbdaac18b889219949f28108 [14/28] drm/amdgpu: Enable support for PSP 15_0_5
config: x86_64-randconfig-161-20260730 (https://download.01.org/0day-ci/archive/20260731/202607310338.dhtAssro-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
smatch: v0.5.0-9187-g5189e3fb

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202607310338.dhtAssro-lkp@intel.com/

New smatch warnings:
drivers/gpu/drm/amd/amdgpu/psp_v15_0.c:149 psp_v15_0_0_ring_create() warn: inconsistent indenting

Old smatch warnings:
drivers/gpu/drm/amd/amdgpu/psp_v15_0.c:184 psp_v15_0_0_ring_create() warn: inconsistent indenting

vim +149 drivers/gpu/drm/amd/amdgpu/psp_v15_0.c

   110	
   111	static int psp_v15_0_0_ring_create(struct psp_context *psp,
   112					 enum psp_ring_type ring_type)
   113	{
   114		int ret = 0;
   115		unsigned int psp_ring_reg = 0;
   116		struct psp_ring *ring = &psp->km_ring;
   117		struct amdgpu_device *adev = psp->adev;
   118	
   119		if (amdgpu_sriov_vf(adev)) {
   120			ret = psp_v15_0_0_ring_stop(psp, ring_type);
   121			if (ret) {
   122				DRM_ERROR("psp_v14_0_ring_stop_sriov failed!\n");
   123				return ret;
   124			}
   125	
   126			/* Write low address of the ring to C2PMSG_102 */
   127			psp_ring_reg = lower_32_bits(ring->ring_mem_mc_addr);
   128			WREG32_SOC15(MP0, 0, regMPASP_SMN_C2PMSG_102, psp_ring_reg);
   129			/* Write high address of the ring to C2PMSG_103 */
   130			psp_ring_reg = upper_32_bits(ring->ring_mem_mc_addr);
   131			WREG32_SOC15(MP0, 0, regMPASP_SMN_C2PMSG_103, psp_ring_reg);
   132	
   133			/* Write the ring initialization command to C2PMSG_101 */
   134			WREG32_SOC15(MP0, 0, regMPASP_SMN_C2PMSG_101,
   135				     GFX_CTRL_CMD_ID_INIT_GPCOM_RING);
   136	
   137			/* there might be handshake issue with hardware which needs delay */
   138			mdelay(20);
   139	
   140			/* Wait for response flag (bit 31) in C2PMSG_101 */
   141			ret = psp_wait_for(psp, SOC15_REG_OFFSET(MP0, 0, regMPASP_SMN_C2PMSG_101),
   142					   0x80000000, 0x8000FFFF, false);
   143	
   144		} else {
   145			if (amdgpu_ip_version(adev, MP0_HWIP, 0) == IP_VERSION(15, 0, 5)) {
   146				/* Wait for sOS ready for ring creation */
   147				ret = psp_wait_for(psp, SOC15_REG_OFFSET(MP0, 0, regMPASP_PCRU0_MPASP_C2PMSG_64),
   148						0x80000000, 0x80000000, false);
 > 149			if (ret) {
   150				DRM_ERROR("Failed to wait for trust OS ready for ring creation\n");
   151				return ret;
   152			}
   153	
   154			/* Write low address of the ring to C2PMSG_69 */
   155			psp_ring_reg = lower_32_bits(ring->ring_mem_mc_addr);
   156			WREG32_SOC15(MP0, 0, regMPASP_PCRU0_MPASP_C2PMSG_69, psp_ring_reg);
   157			/* Write high address of the ring to C2PMSG_70 */
   158			psp_ring_reg = upper_32_bits(ring->ring_mem_mc_addr);
   159			WREG32_SOC15(MP0, 0, regMPASP_PCRU0_MPASP_C2PMSG_70, psp_ring_reg);
   160			/* Write size of ring to C2PMSG_71 */
   161			psp_ring_reg = ring->ring_size;
   162			WREG32_SOC15(MP0, 0, regMPASP_PCRU0_MPASP_C2PMSG_71, psp_ring_reg);
   163			/* Write the ring initialization command to C2PMSG_64 */
   164			psp_ring_reg = ring_type;
   165			psp_ring_reg = psp_ring_reg << 16;
   166			WREG32_SOC15(MP0, 0, regMPASP_PCRU0_MPASP_C2PMSG_64, psp_ring_reg);
   167	
   168			/* there might be handshake issue with hardware which needs delay */
   169			mdelay(20);
   170	
   171			/* Wait for response flag (bit 31) in C2PMSG_64 */
   172			ret = psp_wait_for(psp, SOC15_REG_OFFSET(MP0, 0, regMPASP_PCRU0_MPASP_C2PMSG_64),
   173					   0x80000000, 0x8000FFFF, false);
   174			} else {
   175				/* Wait for sOS ready for ring creation */
   176				ret = psp_wait_for(psp, SOC15_REG_OFFSET(MP0, 0, regMPASP_PCRU1_MPASP_C2PMSG_64),
   177						   0x80000000, 0x80000000, false);
   178				if (ret) {
   179					DRM_ERROR("Failed to wait for trust OS ready for ring creation\n");
   180					return ret;
   181				}
   182	
   183			/* Write low address of the ring to C2PMSG_69 */
   184			psp_ring_reg = lower_32_bits(ring->ring_mem_mc_addr);
   185			WREG32_SOC15(MP0, 0, regMPASP_PCRU1_MPASP_C2PMSG_69, psp_ring_reg);
   186			/* Write high address of the ring to C2PMSG_70 */
   187			psp_ring_reg = upper_32_bits(ring->ring_mem_mc_addr);
   188			WREG32_SOC15(MP0, 0, regMPASP_PCRU1_MPASP_C2PMSG_70, psp_ring_reg);
   189			/* Write size of ring to C2PMSG_71 */
   190			psp_ring_reg = ring->ring_size;
   191			WREG32_SOC15(MP0, 0, regMPASP_PCRU1_MPASP_C2PMSG_71, psp_ring_reg);
   192			/* Write the ring initialization command to C2PMSG_64 */
   193			psp_ring_reg = ring_type;
   194			psp_ring_reg = psp_ring_reg << 16;
   195			WREG32_SOC15(MP0, 0, regMPASP_PCRU1_MPASP_C2PMSG_64, psp_ring_reg);
   196	
   197			/* there might be handshake issue with hardware which needs delay */
   198			mdelay(20);
   199	
   200			/* Wait for response flag (bit 31) in C2PMSG_64 */
   201			ret = psp_wait_for(psp, SOC15_REG_OFFSET(MP0, 0, regMPASP_PCRU1_MPASP_C2PMSG_64),
   202					   0x80000000, 0x8000FFFF, false);
   203			}
   204		}
   205	
   206		return ret;
   207	}
   208	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-07-30 19:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-30 19:33 [agd5f:drm-fixes-7.2 14/28] drivers/gpu/drm/amd/amdgpu/psp_v15_0.c:149 psp_v15_0_0_ring_create() warn: inconsistent indenting kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.