Re: [PATCH 1/2] dt-bindings: media: i2c: Add onsemi AR0234 image sensor binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The `compatible` property schema contains fatal YAML syntax errors due to missing list hyphens (`-`), resulting in invalid JSON schema constructs that will fail `dt_binding_check`.
- [Low] The `data-lanes` schema constraint mathematically allows 3 lanes, which contradicts the explicit 2-or-4 lane hardware requirement described in the binding.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: media: i2c: Add onsemi AR0234 image sensor binding ---
commit 883339f4cdfd1f0ac858633345ef05f216a1e0e8
Author: Alexander Shiyan <eagle.alexander923@gmail.com>

dt-bindings: media: i2c: Add onsemi AR0234 image sensor binding

This commit adds a new devicetree binding schema for the onsemi AR0234 CMOS
image sensor. It details properties for compatible strings, clocks, supplies,
and the MIPI CSI-2 port configurations.

> diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml
[ ... ]
> +properties:
> +  compatible:
> +    oneOf:
> +      const: onnn,ar0234cs
> +      items:
> +        enum:
> +          onnn,ar0234cssc
> +          onnn,ar0234cssm
> +        const: onnn,ar0234cs

[Severity: Low]
Are hyphens missing for the array elements in this compatible block?

Without list hyphens under oneOf, items, and enum, the YAML parser might
treat these as mappings or multi-line scalar strings instead of valid JSON
schema array constructs. This invalid structure will cause dt_binding_check
to fail.

[ ... ]
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +        properties:
> +          data-lanes:
> +            description: Number of MIPI CSI-2 data lanes (must be 2 or 4)
> +            minItems: 2
> +            maxItems: 4

[Severity: Low]
Does this constraint mathematically permit 3 data lanes, contradicting the
description that the hardware must use exactly 2 or 4 lanes?

A device tree specifying data-lanes = <1 2 3> would silently pass validation.
Could this be structured using a oneOf block with exact limits to strictly
enforce the hardware requirement?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260731073505.2278769-1-eagle.alexander923@gmail.com?part=1