From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
Cc: "Kevin Tsai" <ktsai@capellamicro.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Giorgi Tchankvetadze" <giorgi@tchankvetadze.com>
Subject: Re: [PATCH] iio: light: cm32181: return zero after writing calibscale
Date: Fri, 31 Jul 2026 16:11:27 +0200 [thread overview]
Message-ID: <20260731161127.00001478@gmail.com> (raw)
In-Reply-To: <20260731132048.199946-2-giorgitchankvetadze1997@gmail.com>
On Fri, 31 Jul 2026 17:20:48 +0400
Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com> wrote:
> From: Giorgi Tchankvetadze <giorgi@tchankvetadze.com>
>
> The write_raw callback is documented to return 0 on success or a
> negative error code. However, the IIO_CHAN_INFO_CALIBSCALE case
> returns 'val' (the user-supplied value) instead of 0.
>
> Fix it by returning 0 on success, matching the behavior of other
> calibscale implementations in the subsystem.
>
> Fixes: 971672c0b3cc ("iio: add Capella CM32181 ambient light sensor driver.")
> Signed-off-by: Giorgi Tchankvetadze <giorgi@tchankvetadze.com>
> ---
LGTM.
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
--
Kind regards,
Joshua Crofts
prev parent reply other threads:[~2026-07-31 14:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 13:20 [PATCH] iio: light: cm32181: return zero after writing calibscale Giorgi Tchankvetadze
2026-07-31 14:11 ` Joshua Crofts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731161127.00001478@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=giorgi@tchankvetadze.com \
--cc=giorgitchankvetadze1997@gmail.com \
--cc=jic23@kernel.org \
--cc=ktsai@capellamicro.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.