From: Jonathan Cameron <jic23@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Radu Sabau" <radu.sabau@analog.com>,
"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
"Jorge Marques" <jorge.marques@analog.com>,
"Salih Erim" <salih.erim@amd.com>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Jishnu Prakash" <jishnu.prakash@oss.qualcomm.com>,
linux-iio@vger.kernel.org, linux@analog.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 0/4] iio: adc: ade9000: add support for ADE9078
Date: Sun, 2 Aug 2026 02:44:06 +0100 [thread overview]
Message-ID: <20260802024406.6147807e@jic23-huawei> (raw)
In-Reply-To: <20260731082951.1228-1-antoniu.miclaus@analog.com>
On Fri, 31 Jul 2026 11:29:46 +0300
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
> The ADE9078 is a polyphase energy metering device from the same family as
> the ADE9000 and is register compatible with it. The main differences
> relevant to the driver are the absence of the on-chip dip/swell detection,
> a lower maximum SPI clock (10 MHz), and slightly different full-scale ADC
> codes.
This looks fine to me, but will need to sit on list until the dt maintainers
have gotten to it. Sashiko did call out some possible preexisting issues
in the driver. I haven't looked at them, but if you have some time, it may
be worth a look the power vs interrupt registration one smells plausible.
https://sashiko.dev/#/patchset/20260731082951.1228-1-antoniu.miclaus%40analog.com
>
> This series adds support for the ADE9078 to the existing ade9000 driver.
> It first refactors the driver to move the part-specific values (device
> name, channel table, and full-scale codes) into a chip_info structure
> retrieved via device match data, then adds the new device tree compatible
> and the ADE9078 support itself, and finally updates the documentation.
>
> Changes in v2:
> - move the "respective datasheets" comment wording to avoid churn.
> - use a generic Kconfig title and list the supported parts.
> - duplicate the RMS voltage macro instead of a shared base macro.
>
> v1: https://lore.kernel.org/linux-iio/<FILL-IN-v1-MESSAGE-ID>/
>
> Antoniu Miclaus (4):
> iio: adc: ade9000: introduce chip_info structure
> dt-bindings: iio: adc: adi,ade9000: add adi,ade9078 compatible
> iio: adc: ade9000: add support for ADE9078
> docs: iio: ade9000: document ADE9078 support
>
> .../bindings/iio/adc/adi,ade9000.yaml | 30 ++-
> Documentation/iio/ade9000.rst | 28 +--
> drivers/iio/adc/Kconfig | 16 +-
> drivers/iio/adc/ade9000.c | 180 ++++++++++++------
> 4 files changed, 175 insertions(+), 79 deletions(-)
>
>
> base-commit: 0b5e142ced4bcf20532da051934bd694d1bbd470
next prev parent reply other threads:[~2026-08-02 1:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 8:29 [PATCH v2 0/4] iio: adc: ade9000: add support for ADE9078 Antoniu Miclaus
2026-07-31 8:29 ` [PATCH v2 1/4] iio: adc: ade9000: introduce chip_info structure Antoniu Miclaus
2026-07-31 8:40 ` sashiko-bot
2026-07-31 8:29 ` [PATCH v2 2/4] dt-bindings: iio: adc: adi,ade9000: add adi,ade9078 compatible Antoniu Miclaus
2026-07-31 8:39 ` sashiko-bot
2026-07-31 8:29 ` [PATCH v2 3/4] iio: adc: ade9000: add support for ADE9078 Antoniu Miclaus
2026-07-31 8:29 ` [PATCH v2 4/4] docs: iio: ade9000: document ADE9078 support Antoniu Miclaus
2026-08-02 1:44 ` Jonathan Cameron [this message]
2026-08-05 11:45 ` [PATCH v2 0/4] iio: adc: ade9000: add support for ADE9078 Miclaus, Antoniu
2026-08-05 16:45 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260802024406.6147807e@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jishnu.prakash@oss.qualcomm.com \
--cc=jorge.marques@analog.com \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=marcelo.schmitt@analog.com \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=radu.sabau@analog.com \
--cc=robh@kernel.org \
--cc=salih.erim@amd.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.