Re: [PATCH v2 0/4] iio: adc: ade9000: add support for ADE9078

[Jonathan Cameron <jic23@kernel.org>]

On Wed, 5 Aug 2026 11:45:37 +0000
"Miclaus, Antoniu" <Antoniu.Miclaus@analog.com> wrote:

> Hi Jonathan,
> 
> > -----Original Message-----
> > From: Jonathan Cameron <jic23@kernel.org>
> > Sent: Sunday, August 2, 2026 4:44 AM
> > To: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>
> > Cc: Sa, Nuno <Nuno.Sa@analog.com>; Hennerich, Michael
> > <Michael.Hennerich@analog.com>; David Lechner <dlechner@baylibre.com>;
> > Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>;
> > Conor Dooley <conor+dt@kernel.org>; Jonathan Corbet <corbet@lwn.net>;
> > Shuah Khan <skhan@linuxfoundation.org>; Sabau, Radu bogdan
> > <Radu.Sabau@analog.com>; Schmitt, Marcelo
> > <Marcelo.Schmitt@analog.com>; Marques, Jorge
> > <Jorge.Marques@analog.com>; Salih Erim <salih.erim@amd.com>; Matti
> > Vaittinen <mazziesaccount@gmail.com>; Jishnu Prakash
> > <jishnu.prakash@oss.qualcomm.com>; linux-iio@vger.kernel.org; linux
> > <linux@analog.com>; devicetree@vger.kernel.org; linux-
> > kernel@vger.kernel.org; linux-doc@vger.kernel.org
> > Subject: Re: [PATCH v2 0/4] iio: adc: ade9000: add support for ADE9078
> > 
> > [External]
> > 
> > On Fri, 31 Jul 2026 11:29:46 +0300
> > Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
> >   
> > > The ADE9078 is a polyphase energy metering device from the same family as
> > > the ADE9000 and is register compatible with it. The main differences
> > > relevant to the driver are the absence of the on-chip dip/swell detection,
> > > a lower maximum SPI clock (10 MHz), and slightly different full-scale ADC
> > > codes.  
> > 
> > This looks fine to me, but will need to sit on list until the dt maintainers
> > have gotten to it.  Sashiko did call out some possible preexisting issues
> > in the driver.  I haven't looked at them, but if you have some time, it may
> > be worth a look the power vs interrupt registration one smells plausible.
> >   
> Want me to send the fixes in a separate patch or within this series?

Separate should be fine for any preexisting issues.  I'm not going to
hold this series up waiting for them (assuming we get the dt ack - it's
listed on their patchwork as Needs Ack so no one has gotten to it yet).
https://patchwork.kernel.org/project/devicetree/patch/20260731082951.1228-3-antoniu.miclaus@analog.com/

Jonathan

> 
> > https://urldefense.com/v3/__https://sashiko.dev/*/patchset/20260731082
> > 951.1228-1-
> > antoniu.miclaus*40analog.com__;IyU!!A3Ni8CS0y2Y!78esTjrnDgvdH9h_Pruv
> > IpxZPJggP6_ge3-ecPnYKxN8b32xrwH3oUABtFHCRmEGtnicycd5eqRTn7EkeQ$  
> > >
> > > This series adds support for the ADE9078 to the existing ade9000 driver.
> > > It first refactors the driver to move the part-specific values (device
> > > name, channel table, and full-scale codes) into a chip_info structure
> > > retrieved via device match data, then adds the new device tree compatible
> > > and the ADE9078 support itself, and finally updates the documentation.
> > >
> > > Changes in v2:
> > > - move the "respective datasheets" comment wording to avoid churn.
> > > - use a generic Kconfig title and list the supported parts.
> > > - duplicate the RMS voltage macro instead of a shared base macro.
> > >
> > > v1: https://urldefense.com/v3/__https://lore.kernel.org/linux-  
> > iio/__;!!A3Ni8CS0y2Y!78esTjrnDgvdH9h_PruvIpxZPJggP6_ge3-
> > ecPnYKxN8b32xrwH3oUABtFHCRmEGtnicycd5eqTALKwajg$ <FILL-IN-v1-
> > MESSAGE-ID>/  
> > >
> > > Antoniu Miclaus (4):
> > >   iio: adc: ade9000: introduce chip_info structure
> > >   dt-bindings: iio: adc: adi,ade9000: add adi,ade9078 compatible
> > >   iio: adc: ade9000: add support for ADE9078
> > >   docs: iio: ade9000: document ADE9078 support
> > >
> > >  .../bindings/iio/adc/adi,ade9000.yaml         |  30 ++-
> > >  Documentation/iio/ade9000.rst                 |  28 +--
> > >  drivers/iio/adc/Kconfig                       |  16 +-
> > >  drivers/iio/adc/ade9000.c                     | 180 ++++++++++++------
> > >  4 files changed, 175 insertions(+), 79 deletions(-)
> > >
> > >
> > > base-commit: 0b5e142ced4bcf20532da051934bd694d1bbd470  
>