All of lore.kernel.org
 help / color / mirror / Atom feed
From: mdshahid03@gmail.com
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Joshua Crofts" <joshua.crofts@broadcom.com>,
	"Broadcom internal kernel list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"David Lechner" <dlechner@baylibre.com>,
	linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org, "Nuno Sá" <nuno.sa@analog.com>,
	"Ray Jui" <rjui@broadcom.com>,
	"Scott Branden" <sbranden@broadcom.com>,
	"Mohammad Shahid" <mdshahid03@gmail.com>
Subject: Re: [PATCH v3 3/3] iio: adc: bcm_iproc_adc: Convert probe error handling to dev_err_probe()
Date: Sun,  2 Aug 2026 16:05:20 +0530	[thread overview]
Message-ID: <20260802103520.114582-1-mdshahid03@gmail.com> (raw)
In-Reply-To: <20260802030433.696454fe@jic23-huawei>

From: Mohammad Shahid <mdshahid03@gmail.com>

Hi Jonathan,

Thanks for the detailed review and suggestions.

I'll address the formatting comments in patch 3 and also reduce the
unnecessary churn in patch 2 as you suggested.

Regarding the suggestion to convert the probe cleanup to
devm_add_action_or_reset(), my intention was to keep this series focused
on the dev_err_probe() conversion and submit the devm-managed cleanup as
a separate follow-up series, since it is a larger refactoring.

Would that approach be acceptable, or would you prefer that the cleanup
be included in this series?

Thanks,
Shahid


  reply	other threads:[~2026-08-02 10:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31 18:23 [PATCH v3 0/3] iio: adc: bcm_iproc_adc: Simplify probe error handling mdshahid03
2026-07-31 18:23 ` [PATCH v3 1/3] iio: adc: bcm_iproc_adc: Remove redundant error message after devm_request_threaded_irq() mdshahid03
2026-07-31 18:23 ` [PATCH v3 2/3] iio: adc: bcm_iproc_adc: Introduce local device pointer mdshahid03
2026-08-02  1:58   ` Jonathan Cameron
2026-07-31 18:23 ` [PATCH v3 3/3] iio: adc: bcm_iproc_adc: Convert probe error handling to dev_err_probe() mdshahid03
2026-08-01  6:45   ` Joshua Crofts
2026-08-02  2:04   ` Jonathan Cameron
2026-08-02 10:35     ` mdshahid03 [this message]
2026-08-02 17:26       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260802103520.114582-1-mdshahid03@gmail.com \
    --to=mdshahid03@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=joshua.crofts@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.