All of lore.kernel.org
 help / color / mirror / Atom feed
From: linuxtestproject.agent@gmail.com
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] fsconfig04: Check FSCONFIG_SET_PATH
Date: Mon,  3 Aug 2026 03:37:11 +0000	[thread overview]
Message-ID: <20260803033711.9131-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260803021230.14530-1-wegao@suse.com>

Hi Wei,

On Aug 3, 2026, Wei Gao wrote:
> fsconfig04: Check FSCONFIG_SET_PATH

> + * - Format dev1 and dev2 as external journal devices with the same UUID
> + *   ("-O journal_dev -U <uuid>").
> + * - Format dev0 three times to cycle journal associations:
> + *   dev1 -> dev2 -> dev1, so both journal superblocks are consistent.
> + * - Open dev0 via fsopen(2) and set the source and journal_path using
> + *   fsconfig(FSCONFIG_SET_STRING) and fsconfig(FSCONFIG_SET_PATH).

Could the syscall references use the required :manpage:`fsopen(2)` and
:manpage:`fsconfig(2)` roles, and could identifiers and command-line
arguments use reStructuredText inline literals (for example,
``FSCONFIG_SET_PATH`` and ``-O journal_dev -U <uuid>``)? This block is
exported to the test catalog, where these roles and literals provide the
expected links and formatting.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2026-08-03  3:37 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-16 15:10 [LTP] [PATCH v1] fsconfig04.c: Check FSCONFIG_SET_PATH Wei Gao via ltp
2025-05-22 20:56 ` Petr Vorel
2025-05-26 14:29   ` Wei Gao via ltp
2025-05-26  6:40     ` Petr Vorel
2025-05-26 14:35 ` [LTP] [PATCH v2] " Wei Gao via ltp
2025-05-26  9:54   ` Petr Vorel
2025-05-26 12:54     ` Cyril Hrubis
2025-05-26 16:13       ` Petr Vorel
2025-05-27  8:24         ` Cyril Hrubis
2025-05-27  8:58           ` [LTP] LTP doc: test examples [was: Re: [PATCH v2] fsconfig04.c: Check FSCONFIG_SET_PATH] Petr Vorel
2025-05-26 14:38   ` [LTP] [PATCH v2] fsconfig04.c: Check FSCONFIG_SET_PATH Cyril Hrubis
2025-06-03 21:45   ` [LTP] [PATCH v3] " Wei Gao via ltp
2025-10-17  4:39     ` Wei Gao via ltp
2025-12-12  9:29     ` Andrea Cervesato via ltp
2026-02-25  9:27       ` Wei Gao via ltp
2026-03-16  8:49         ` Petr Vorel
2026-03-17  0:59           ` Wei Gao via ltp
2026-03-24 12:50           ` Petr Vorel
2026-04-10  5:47     ` [LTP] [PATCH v4] " Wei Gao via ltp
2026-04-16 11:25       ` [LTP] [PATCH v5] fsconfig04: " Wei Gao via ltp
2026-04-16 13:52         ` [LTP] " linuxtestproject.agent
2026-04-16 13:55           ` Andrea Cervesato via ltp
2026-04-30  5:19         ` [LTP] [PATCH v6] " Wei Gao via ltp
2026-04-30  6:34           ` [LTP] " linuxtestproject.agent
2026-05-07 12:25             ` Wei Gao via ltp
2026-06-09  9:44           ` [LTP] [PATCH v6] " Andrea Cervesato via ltp
2026-06-10  5:21           ` [LTP] [PATCH v7] " Wei Gao via ltp
2026-06-10 10:06             ` [LTP] " linuxtestproject.agent
2026-06-18  2:38             ` [LTP] [PATCH v8] " Wei Gao via ltp
2026-06-18  4:04               ` [LTP] " linuxtestproject.agent
2026-06-26  6:14               ` [LTP] [PATCH v9] " Wei Gao via ltp
2026-06-26  9:33                 ` [LTP] " linuxtestproject.agent
2026-07-13 12:08                 ` [LTP] [PATCH v9] " Andrea Cervesato via ltp
2026-07-20 12:26                 ` [LTP] [PATCH v10] " Wei Gao via ltp
2026-07-20 13:11                   ` [LTP] " linuxtestproject.agent
2026-08-03  2:12                   ` [LTP] [PATCH v11] " Wei Gao via ltp
2026-08-03  3:37                     ` linuxtestproject.agent [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260803033711.9131-1-linuxtestproject.agent@gmail.com \
    --to=linuxtestproject.agent@gmail.com \
    --cc=ltp@lists.linux.it \
    --cc=wegao@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.