All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH V2] package/x11r7/xwayland: fix glamor DRI ordering dependency on mesa3d
@ 2026-08-03 14:08 Adam Ford
  2026-08-09 17:44 ` John Ernberg
  0 siblings, 1 reply; 3+ messages in thread
From: Adam Ford @ 2026-08-03 14:08 UTC (permalink / raw)
  To: buildroot; +Cc: Raphael Pavlidis, Adam Ford

Xwayland's glamor support enables a DRI configure check that looks for
Mesa's dri.pc in staging. Without an explicit ordering dependency, a
highly parallel build can run Xwayland's configure before mesa3d is
installed, failing with:

    ERROR: Dependency "dri" not found

Since mesa3d is what provides the DRI/EGL/GBM bits glamor relies on, fold
it into the glamor condition: only enable -Dglamor=true and add it to the
dependencies alongside libepoxy.

Signed-off-by: Adam Ford <aford173@gmail.com>

diff --git a/package/x11r7/xwayland/xwayland.mk b/package/x11r7/xwayland/xwayland.mk
index 02a21b96c1..3bd87a4552 100644
--- a/package/x11r7/xwayland/xwayland.mk
+++ b/package/x11r7/xwayland/xwayland.mk
@@ -32,7 +32,7 @@ XWAYLAND_CONF_OPTS = \
 
 ifeq ($(BR2_PACKAGE_HAS_LIBEGL)$(BR2_PACKAGE_LIBEPOXY),yy)
 XWAYLAND_CONF_OPTS += -Dglamor=true
-XWAYLAND_DEPENDENCIES += libepoxy
+XWAYLAND_DEPENDENCIES += libepoxy mesa3d
 else
 XWAYLAND_CONF_OPTS += -Dglamor=false
 endif
-- 
2.53.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH V2] package/x11r7/xwayland: fix glamor DRI ordering dependency on mesa3d
  2026-08-03 14:08 [Buildroot] [PATCH V2] package/x11r7/xwayland: fix glamor DRI ordering dependency on mesa3d Adam Ford
@ 2026-08-09 17:44 ` John Ernberg
  2026-08-11 19:12   ` Adam Ford
  0 siblings, 1 reply; 3+ messages in thread
From: John Ernberg @ 2026-08-09 17:44 UTC (permalink / raw)
  To: Adam Ford; +Cc: buildroot, Raphael Pavlidis

Hi Adam,

Apologies for the delay.

On Mon, Aug 3, 2026 at 4:08 PM Adam Ford <aford173@gmail.com> wrote:
>
> Xwayland's glamor support enables a DRI configure check that looks for
> Mesa's dri.pc in staging. Without an explicit ordering dependency, a
> highly parallel build can run Xwayland's configure before mesa3d is
> installed, failing with:
>
>     ERROR: Dependency "dri" not found
>
> Since mesa3d is what provides the DRI/EGL/GBM bits glamor relies on, fold
> it into the glamor condition: only enable -Dglamor=true and add it to the
> dependencies alongside libepoxy.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/package/x11r7/xwayland/xwayland.mk b/package/x11r7/xwayland/xwayland.mk
> index 02a21b96c1..3bd87a4552 100644
> --- a/package/x11r7/xwayland/xwayland.mk
> +++ b/package/x11r7/xwayland/xwayland.mk
> @@ -32,7 +32,7 @@ XWAYLAND_CONF_OPTS = \
>
>  ifeq ($(BR2_PACKAGE_HAS_LIBEGL)$(BR2_PACKAGE_LIBEPOXY),yy)
>  XWAYLAND_CONF_OPTS += -Dglamor=true
> -XWAYLAND_DEPENDENCIES += libepoxy
> +XWAYLAND_DEPENDENCIES += libepoxy mesa3d
>  else
>  XWAYLAND_CONF_OPTS += -Dglamor=false
>  endif
> --
> 2.53.0
>

dri is needed by glx, not glamor, when checking the code. Did you test
build this?

(it's easier to reproduce with a per-package build where this becomes
a persistent failure rather than random)

It should go to the LIBGL check rather than the LIB*E*GL check. But as
I mentioned on v1, you probably need to check how this works when
nvidia-driver is the LIBGL provider.

Best regards // John Ernberg
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH V2] package/x11r7/xwayland: fix glamor DRI ordering dependency on mesa3d
  2026-08-09 17:44 ` John Ernberg
@ 2026-08-11 19:12   ` Adam Ford
  0 siblings, 0 replies; 3+ messages in thread
From: Adam Ford @ 2026-08-11 19:12 UTC (permalink / raw)
  To: John Ernberg; +Cc: buildroot, Raphael Pavlidis


[-- Attachment #1.1: Type: text/plain, Size: 1977 bytes --]

On Sun, Aug 9, 2026 at 12:44 PM John Ernberg <j@j-ernberg.se> wrote:

> Hi Adam,
>
> Apologies for the delay.
>
> On Mon, Aug 3, 2026 at 4:08 PM Adam Ford <aford173@gmail.com> wrote:
> >
> > Xwayland's glamor support enables a DRI configure check that looks for
> > Mesa's dri.pc in staging. Without an explicit ordering dependency, a
> > highly parallel build can run Xwayland's configure before mesa3d is
> > installed, failing with:
> >
> >     ERROR: Dependency "dri" not found
> >
> > Since mesa3d is what provides the DRI/EGL/GBM bits glamor relies on, fold
> > it into the glamor condition: only enable -Dglamor=true and add it to the
> > dependencies alongside libepoxy.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > diff --git a/package/x11r7/xwayland/xwayland.mk
> b/package/x11r7/xwayland/xwayland.mk
> > index 02a21b96c1..3bd87a4552 100644
> > --- a/package/x11r7/xwayland/xwayland.mk
> > +++ b/package/x11r7/xwayland/xwayland.mk
> > @@ -32,7 +32,7 @@ XWAYLAND_CONF_OPTS = \
> >
> >  ifeq ($(BR2_PACKAGE_HAS_LIBEGL)$(BR2_PACKAGE_LIBEPOXY),yy)
> >  XWAYLAND_CONF_OPTS += -Dglamor=true
> > -XWAYLAND_DEPENDENCIES += libepoxy
> > +XWAYLAND_DEPENDENCIES += libepoxy mesa3d
> >  else
> >  XWAYLAND_CONF_OPTS += -Dglamor=false
> >  endif
> > --
> > 2.53.0
> >
>
> dri is needed by glx, not glamor, when checking the code. Did you test
> build this?
>
> (it's easier to reproduce with a per-package build where this becomes
> a persistent failure rather than random)
>

I test-built this with per-package enabled, and it worked, but I only have
Mesa providing libgl as in my build scenario, I am using either Intel or
AMDGPU.


>
> It should go to the LIBGL check rather than the LIB*E*GL check. But as
> I mentioned on v1, you probably need to check how this works when
> nvidia-driver is the LIBGL provider.


I'll dig a bit further into this.

adam

>
> Best regards // John Ernberg
>

[-- Attachment #1.2: Type: text/html, Size: 3292 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-08-11 19:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-03 14:08 [Buildroot] [PATCH V2] package/x11r7/xwayland: fix glamor DRI ordering dependency on mesa3d Adam Ford
2026-08-09 17:44 ` John Ernberg
2026-08-11 19:12   ` Adam Ford

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.