All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: regulator: ti,tps65219: Use generic power-controller schema
Date: Tue, 04 Aug 2026 15:27:25 +0000	[thread overview]
Message-ID: <20260804152725.E4E671F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260804-regulator-syspower-v1-1-b05af2081184@nxp.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch references a non-existent generic YAML schema `/schemas/power/power-controller.yaml#`.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: regulator: ti,tps65219: Use generic power-controller schema ---
commit cf2a7a6bb686cde6c0c0239ec4f30d1057f13e9e
Author: Peng Fan <peng.fan@nxp.com>

dt-bindings: regulator: ti,tps65219: Use generic power-controller schema

This commit converts the ti,tps65219 binding to use the generic power
controller schema by removing the local system-power-controller property
and referencing power-controller.yaml.

> diff --git a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
> index 7c64e588a8b54..d3a82aa7319f0 100644
> --- a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
> +++ b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml

[ ... ]

> @@ -99,9 +94,10 @@ required:
>    - interrupts
>    - regulators
>  
> -additionalProperties: false
> +unevaluatedProperties: false
>  
>  allOf:
> +  - $ref: /schemas/power/power-controller.yaml#

[Severity: Low]
Does this generic schema actually exist in the kernel tree yet? It appears
the target might still be power-controller.txt, meaning this reference could
cause dt_binding_check validation to fail with a schema resolution error.

>    - if:
>        properties:
>          compatible:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260804-regulator-syspower-v1-0-b05af2081184@nxp.com?part=1

  reply	other threads:[~2026-08-04 15:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04 14:37 [PATCH 0/2] dt-bindings: regulator: Use generic power-controller schema Peng Fan (OSS)
2026-08-04 14:37 ` [PATCH 1/2] dt-bindings: regulator: ti,tps65219: " Peng Fan (OSS)
2026-08-04 15:27   ` sashiko-bot [this message]
2026-08-05 21:16   ` Rob Herring
2026-08-04 14:37 ` [PATCH 2/2] dt-bindings: regulator: act8x: " Peng Fan (OSS)
2026-08-04 15:39   ` sashiko-bot
2026-08-04 20:06 ` [PATCH 0/2] dt-bindings: regulator: " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260804152725.E4E671F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=peng.fan@oss.nxp.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.