From: sashiko-bot@kernel.org
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: regulator: act8x: Use generic power-controller schema
Date: Tue, 04 Aug 2026 15:39:22 +0000 [thread overview]
Message-ID: <20260804153923.481061F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260804-regulator-syspower-v1-2-b05af2081184@nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Broken schema cross-reference to a non-existent power-controller.yaml file.
--
--- Patch [2]: [PATCH 2/2] dt-bindings: regulator: act8x: Use generic power-controller schema ---
commit dbd959e51dadcb9629319a89cca123c97aebf588
Author: Peng Fan <peng.fan@nxp.com>
dt-bindings: regulator: act8x: Use generic power-controller schema
Convert the binding to use the generic power-controller schema instead by
referencing power-controller.yaml and removing the local
system-power-controller property definition.
> diff --git a/Documentation/devicetree/bindings/regulator/active-semi,act8600.yaml b/Documentation/devicetree/bindings/regulator/active-semi,act8600.yaml
> index b8ca967bc83d1..49f74a9b1eaab 100644
> --- a/Documentation/devicetree/bindings/regulator/active-semi,act8600.yaml
> +++ b/Documentation/devicetree/bindings/regulator/active-semi,act8600.yaml
> @@ -9,6 +9,9 @@ title: Active-semi ACT8600 regulator
> maintainers:
> - Paul Cercueil <paul@crapouillou.net>
>
> +allOf:
> + - $ref: /schemas/power/power-controller.yaml#
[Severity: Low]
Does this reference break dt_binding_check?
It appears that /schemas/power/power-controller.yaml does not exist in the
tree yet, as only the legacy power-controller.txt is present in
Documentation/devicetree/bindings/power/.
Are there missing prerequisite patches for this series?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260804-regulator-syspower-v1-0-b05af2081184@nxp.com?part=2
next prev parent reply other threads:[~2026-08-04 15:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 14:37 [PATCH 0/2] dt-bindings: regulator: Use generic power-controller schema Peng Fan (OSS)
2026-08-04 14:37 ` [PATCH 1/2] dt-bindings: regulator: ti,tps65219: " Peng Fan (OSS)
2026-08-04 15:27 ` sashiko-bot
2026-08-05 21:16 ` Rob Herring
2026-08-04 14:37 ` [PATCH 2/2] dt-bindings: regulator: act8x: " Peng Fan (OSS)
2026-08-04 15:39 ` sashiko-bot [this message]
2026-08-04 20:06 ` [PATCH 0/2] dt-bindings: regulator: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804153923.481061F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=peng.fan@oss.nxp.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.