All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org,
	lee@kernel.org, mfd@lists.linux.dev
Subject: Re: [PATCH 09/10] dt-bindings: mfd: fsl,mc13xxx: Use generic power-controller schema
Date: Tue, 04 Aug 2026 16:10:36 +0000	[thread overview]
Message-ID: <20260804161037.AEAF31F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260804-mfd-syspower-v1-9-a440783c2e78@nxp.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Broken schema reference to a nonexistent YAML file.
--

--- Patch [9]: [PATCH 09/10] dt-bindings: mfd: fsl,mc13xxx: Use generic power-controller schema ---
commit eeab4b123a8fd6063871fdea625f14e773ee0aa4
Author: Peng Fan <peng.fan@nxp.com>

dt-bindings: mfd: fsl,mc13xxx: Use generic power-controller schema

This commit switches the fsl,mc13xxx binding to use the generic power
controller schema. It removes the local system-power-controller property
and references the generic power-controller.yaml file.

> diff --git a/Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml b/Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml
> --- a/Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml
> +++ b/Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml
[ ... ]
> @@ -174,6 +172,7 @@ required:
>    - reg
>  
>  allOf:
> +  - $ref: /schemas/power/power-controller.yaml#

[Severity: Low]
Does the power-controller.yaml schema exist in the tree yet? 

It appears the generic power controller schema remains a legacy 
power-controller.txt file in this tree. Adding this reference will cause 
make dt_binding_check to fail with a schema reference resolution error 
since the referenced YAML file does not actually exist.

>    - if:
>        properties:
>          compatible:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260804-mfd-syspower-v1-0-a440783c2e78@nxp.com?part=9

  reply	other threads:[~2026-08-04 16:10 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04 14:16 [PATCH 00/10] dt-bindings: mfd: Use generic power-controller schema Peng Fan (OSS)
2026-08-04 14:16 ` Peng Fan (OSS)
2026-08-04 14:16 ` [PATCH 01/10] dt-bindings: mfd: ene-kb[3]930: " Peng Fan (OSS)
2026-08-04 14:16   ` Peng Fan (OSS)
2026-08-04 15:11   ` sashiko-bot
2026-08-04 14:16 ` [PATCH 02/10] dt-bindings: mfd: ti,tps65910: " Peng Fan (OSS)
2026-08-04 14:16   ` Peng Fan (OSS)
2026-08-04 15:23   ` sashiko-bot
2026-08-05 21:12   ` Rob Herring
2026-08-05 21:12     ` Rob Herring
2026-08-04 14:16 ` [PATCH 03/10] dt-bindings: mfd: rockchip,rk8x: " Peng Fan (OSS)
2026-08-04 14:16   ` Peng Fan (OSS)
2026-08-04 15:30   ` sashiko-bot
2026-08-04 14:16 ` [PATCH 04/10] dt-bindings: mfd: ricoh,rn5t618: " Peng Fan (OSS)
2026-08-04 14:16   ` Peng Fan (OSS)
2026-08-04 15:34   ` sashiko-bot
2026-08-04 14:16 ` [PATCH 05/10] dt-bindings: mfd: netronix,ntxec: " Peng Fan (OSS)
2026-08-04 14:16   ` Peng Fan (OSS)
2026-08-04 15:44   ` sashiko-bot
2026-08-04 14:16 ` [PATCH 06/10] dt-bindings: mfd: ti,twl: " Peng Fan (OSS)
2026-08-04 14:16   ` Peng Fan (OSS)
2026-08-04 15:51   ` sashiko-bot
2026-08-04 14:16 ` [PATCH 07/10] dt-bindings: mfd: ti,tps6594: " Peng Fan (OSS)
2026-08-04 14:16   ` Peng Fan (OSS)
2026-08-04 15:55   ` sashiko-bot
2026-08-04 14:16 ` [PATCH 08/10] dt-bindings: mfd: rohm,bd71828-pmic: " Peng Fan (OSS)
2026-08-04 14:16   ` Peng Fan (OSS)
2026-08-04 16:01   ` sashiko-bot
2026-08-05  7:14   ` Matti Vaittinen
2026-08-05  7:14     ` Matti Vaittinen
2026-08-04 14:16 ` [PATCH 09/10] dt-bindings: mfd: fsl,mc13xxx: " Peng Fan (OSS)
2026-08-04 14:16   ` Peng Fan (OSS)
2026-08-04 16:10   ` sashiko-bot [this message]
2026-08-04 14:16 ` [PATCH 10/10] dt-bindings: mfd: samsung,s2mpg10-pmic: " Peng Fan (OSS)
2026-08-04 14:16   ` Peng Fan (OSS)
2026-08-04 16:14   ` sashiko-bot
2026-08-05 21:10 ` [PATCH 00/10] dt-bindings: mfd: " Rob Herring
2026-08-05 21:10   ` Rob Herring
2026-08-06  1:11   ` Peng Fan
2026-08-06  1:11     ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260804161037.AEAF31F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee@kernel.org \
    --cc=mfd@lists.linux.dev \
    --cc=peng.fan@oss.nxp.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.