From: Miao Wang <shankerwangmiao@gmail.com>
To: Binbin Zhou <zhoubinbin@loongson.cn>,
Chong Qiao <qiaochong@loongson.cn>, Lee Jones <lee@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Corey Minyard <corey@minyard.net>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>
Cc: Xi Ruoyao <xry111@xry111.site>, WANG Xuerui <kernel@xen0n.name>,
Yinbo Zhu <zhuyinbo@loongson.cn>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
mfd@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org,
openipmi-developer@lists.sourceforge.net,
Miao Wang <shankerwangmiao@gmail.com>
Subject: [PATCH RFC v6 5/7] ipmi: ls2k: adjust dependency to its mfd driver
Date: Wed, 05 Aug 2026 03:14:23 +0800 [thread overview]
Message-ID: <20260805-ls2kbmc-mod-v6-5-16ccde412d86@gmail.com> (raw)
In-Reply-To: <20260805-ls2kbmc-mod-v6-0-16ccde412d86@gmail.com>
There is functional dependency between the IPMI driver and its mfd
driver. Previously, the dependency was set to "select" from
IPMI_LS2K to MFD_LS2K_BMC_CORE. However, the ipmi driver is actually
compiled as a part of the ipmi_si module, and IPMI_LS2K is a bool
option. Therefore, the dependency "select" will force the mfd driver
to be compiled built-in when the ipmi driver is built as a module. This
is not desirable. This patch fixes this by declaring a conditional
dependency from IPMI_SI to MFD_LS2K_BMC_CORE if IPMI_LS2K is selected.
This will allow the mfd driver to be compiled as a module if the ipmi
driver is built as a module. The adjustment to Kconfig for the mfd
driver will be introduced in the later patch in this series.
Fixes: d46651d4e3c0 ("ipmi: Add Loongson-2K BMC support")
Signed-off-by: Miao Wang <shankerwangmiao@gmail.com>
---
drivers/char/ipmi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig
index 669f7600019747bcd2b37563477cf336f19a0407..07f3308c71616215871a730b87f1991d2b502e63 100644
--- a/drivers/char/ipmi/Kconfig
+++ b/drivers/char/ipmi/Kconfig
@@ -62,6 +62,7 @@ config IPMI_DEVICE_INTERFACE
config IPMI_SI
tristate 'IPMI System Interface handler'
select IPMI_PLAT_DATA
+ select MFD_LS2K_BMC_CORE if IPMI_LS2K
help
Provides a driver for System Interfaces (KCS, SMIC, BT).
Currently, only KCS and SMIC are supported. If
@@ -87,7 +88,6 @@ config IPMI_IPMB
config IPMI_LS2K
bool 'Loongson-2K IPMI interface'
depends on LOONGARCH
- select MFD_LS2K_BMC_CORE
help
Provides a driver for Loongson-2K IPMI interfaces.
--
2.49.0
WARNING: multiple messages have this Message-ID (diff)
From: Miao Wang via B4 Relay <devnull+shankerwangmiao.gmail.com@kernel.org>
To: Binbin Zhou <zhoubinbin@loongson.cn>,
Chong Qiao <qiaochong@loongson.cn>, Lee Jones <lee@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Corey Minyard <corey@minyard.net>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>
Cc: Xi Ruoyao <xry111@xry111.site>, WANG Xuerui <kernel@xen0n.name>,
Yinbo Zhu <zhuyinbo@loongson.cn>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
mfd@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org,
openipmi-developer@lists.sourceforge.net,
Miao Wang <shankerwangmiao@gmail.com>
Subject: [PATCH RFC v6 5/7] ipmi: ls2k: adjust dependency to its mfd driver
Date: Wed, 05 Aug 2026 03:14:23 +0800 [thread overview]
Message-ID: <20260805-ls2kbmc-mod-v6-5-16ccde412d86@gmail.com> (raw)
In-Reply-To: <20260805-ls2kbmc-mod-v6-0-16ccde412d86@gmail.com>
From: Miao Wang <shankerwangmiao@gmail.com>
There is functional dependency between the IPMI driver and its mfd
driver. Previously, the dependency was set to "select" from
IPMI_LS2K to MFD_LS2K_BMC_CORE. However, the ipmi driver is actually
compiled as a part of the ipmi_si module, and IPMI_LS2K is a bool
option. Therefore, the dependency "select" will force the mfd driver
to be compiled built-in when the ipmi driver is built as a module. This
is not desirable. This patch fixes this by declaring a conditional
dependency from IPMI_SI to MFD_LS2K_BMC_CORE if IPMI_LS2K is selected.
This will allow the mfd driver to be compiled as a module if the ipmi
driver is built as a module. The adjustment to Kconfig for the mfd
driver will be introduced in the later patch in this series.
Fixes: d46651d4e3c0 ("ipmi: Add Loongson-2K BMC support")
Signed-off-by: Miao Wang <shankerwangmiao@gmail.com>
---
drivers/char/ipmi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig
index 669f7600019747bcd2b37563477cf336f19a0407..07f3308c71616215871a730b87f1991d2b502e63 100644
--- a/drivers/char/ipmi/Kconfig
+++ b/drivers/char/ipmi/Kconfig
@@ -62,6 +62,7 @@ config IPMI_DEVICE_INTERFACE
config IPMI_SI
tristate 'IPMI System Interface handler'
select IPMI_PLAT_DATA
+ select MFD_LS2K_BMC_CORE if IPMI_LS2K
help
Provides a driver for System Interfaces (KCS, SMIC, BT).
Currently, only KCS and SMIC are supported. If
@@ -87,7 +88,6 @@ config IPMI_IPMB
config IPMI_LS2K
bool 'Loongson-2K IPMI interface'
depends on LOONGARCH
- select MFD_LS2K_BMC_CORE
help
Provides a driver for Loongson-2K IPMI interfaces.
--
2.49.0
next prev parent reply other threads:[~2026-08-04 19:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 19:14 [PATCH RFC v6 0/7] mfd: ls2kbmc: multiple fixes for this driver Miao Wang
2026-08-04 19:14 ` Miao Wang via B4 Relay
2026-08-04 19:14 ` [PATCH RFC v6 1/7] mfd: ls2kbmc: Make a copy when parsing mode string Miao Wang
2026-08-04 19:14 ` Miao Wang via B4 Relay
2026-08-04 19:14 ` [PATCH RFC v6 2/7] mfd: ls2kbmc: Sanity check for the connected pci port Miao Wang
2026-08-04 19:14 ` Miao Wang via B4 Relay
2026-08-04 19:14 ` [PATCH RFC v6 3/7] mfd: ls2kbmc: Redraw using exported functions Miao Wang
2026-08-04 19:14 ` Miao Wang via B4 Relay
2026-08-04 19:14 ` [PATCH RFC v6 4/7] mfd: ls2kbmc: Cancel the work queue on removal Miao Wang
2026-08-04 19:14 ` Miao Wang via B4 Relay
2026-08-04 19:14 ` Miao Wang [this message]
2026-08-04 19:14 ` [PATCH RFC v6 5/7] ipmi: ls2k: adjust dependency to its mfd driver Miao Wang via B4 Relay
2026-08-04 19:34 ` Corey Minyard
2026-08-04 19:14 ` [PATCH RFC v6 6/7] mfd: ls2kbmc: Able to be compiled as a module Miao Wang
2026-08-04 19:14 ` Miao Wang via B4 Relay
2026-08-04 19:14 ` [PATCH RFC v6 7/7] mfd: ls2kbmc: Capture the reset event of BMC through GPIO Miao Wang
2026-08-04 19:14 ` Miao Wang via B4 Relay
2026-08-10 10:14 ` Bartosz Golaszewski
2026-08-10 11:28 ` Miao Wang
2026-08-10 11:30 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260805-ls2kbmc-mod-v6-5-16ccde412d86@gmail.com \
--to=shankerwangmiao@gmail.com \
--cc=brgl@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=corey@minyard.net \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=qiaochong@loongson.cn \
--cc=xry111@xry111.site \
--cc=zhoubinbin@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.