[PATCH] ASoC: ti: omap-twl4030: Check for missing card name after parsing

[PATCH] ASoC: ti: omap-twl4030: Check for missing card name after parsing

[phucduc.bui]

From: bui duc phuc <phucduc.bui@gmail.com>

Return any error from snd_soc_of_parse_card_name() directly. If the
helper returns successfully but card->name remains unset, report the
missing card name explicitly before returning -ENODEV.

Suggested-by: Andreas Kemnade <andreas@kemnade.info>
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
 sound/soc/ti/omap-twl4030.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/sound/soc/ti/omap-twl4030.c b/sound/soc/ti/omap-twl4030.c
index 8a3a792a21c6..a3ab52b2b64e 100644
--- a/sound/soc/ti/omap-twl4030.c
+++ b/sound/soc/ti/omap-twl4030.c
@@ -216,7 +216,11 @@ static int omap_twl4030_probe(struct platform_device *pdev)
 	if (priv == NULL)
 		return -ENOMEM;
 
-	if (snd_soc_of_parse_card_name(card, "ti,model")) {
+	ret = snd_soc_of_parse_card_name(card, "ti,model");
+	if (ret)
+		return ret;
+
+	if (!card->name) {
 		dev_err(&pdev->dev, "Card name is not provided\n");
 		return -ENODEV;
 	}
-- 
2.43.0

Re: [PATCH] ASoC: ti: omap-twl4030: Check for missing card name after parsing

[Mark Brown]

On Wed, 05 Aug 2026 11:45:56 +0700, phucduc.bui@gmail.com wrote:
> ASoC: ti: omap-twl4030: Check for missing card name after parsing

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3

Thanks!

[1/1] ASoC: ti: omap-twl4030: Check for missing card name after parsing
      https://git.kernel.org/broonie/sound/c/9e0698b77684

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH] ASoC: ti: omap-twl4030: Check for missing card name after parsing

[Jarkko Nikula]

On 05/08/2026 7:45 am, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> Return any error from snd_soc_of_parse_card_name() directly. If the
> helper returns successfully but card->name remains unset, report the
> missing card name explicitly before returning -ENODEV.
>
> Suggested-by: Andreas Kemnade <andreas@kemnade.info>
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
>  sound/soc/ti/omap-twl4030.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>