Re: [PATCH v7 3/9] perf c2c: add column rendering for function view

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The macro `C2C_FUNC_FOLD_WIDTH` is defined but never used.
--

--- Patch [3]: [PATCH v7 3/9] perf c2c: add column rendering for function view ---
commit a3883eb9f33b41bc5b4463fa0fd2cb2ff6a32559
Author: Jiebin Sun <jiebin.sun@intel.com>

perf c2c: add column rendering for function view

This commit adds the function view's column renderers for the perf c2c tool. It
introduces the necessary width and header helpers, the per-function estimated
cycles computation, and dimension tables to link columns to their renderers.

> diff --git a/tools/perf/ui/browsers/c2c-function.c b/tools/perf/ui/browsers/c2c-function.c
> index c0fd7799e4f85..89e4e65022b52 100644
> --- a/tools/perf/ui/browsers/c2c-function.c
> +++ b/tools/perf/ui/browsers/c2c-function.c
[ ... ]
> +/* Spaces of indent per hierarchy level, like the normal report view. */
> +#define C2C_FUNC_INDENT 2
> +
> +/* Width of the folded-sign prefix ("%c ") each identity cell emits. */
> +#define C2C_FUNC_FOLD_WIDTH 2

[Severity: Low]
This isn't a bug, but is this macro intended to be used? 

It looks like C2C_FUNC_FOLD_WIDTH is defined here, but the code later in 
symbol_view_entry() and cycles_percent_entry() hardcodes the "%c " format
string and calculates lengths without referencing this macro. 

Could the renderers use this macro when calculating the remaining buffer 
widths instead of manual adjustments?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260806074217.2846596-1-jiebin.sun@intel.com?part=3