Re: [PATCH v7 2/9] perf c2c: add function view browser skeleton

[Namhyung Kim <namhyung@kernel.org>]

On Thu, Aug 06, 2026 at 03:42:10PM +0800, Jiebin Sun wrote:
> Add the skeleton of the c2c function view: a new TUI browser in
> tools/perf/ui/browsers/c2c-function.c reached by pressing TAB in the
> cacheline view. This commit wires up the entry point (a stub that will be
> filled in by later patches), declares perf_c2c__browse_function_view() in
> c2c.h, and adds the TAB key handler and help text to the cacheline browser.
> 
> Link c2c-function.o directly into perf rather than libperf-ui.a. The
> browser is part of the c2c command and later patches make it depend on
> state and callbacks provided by builtin-c2c.o. libperf-ui.a is also linked
> into python/perf.so under --whole-archive, without the builtin command
> objects, which would leave those command-private symbols unresolved.
> Build the browser only with CONFIG_SLANG, matching its TUI-only entry
> point.

I don't think it's a proper fix.  The c2c-function.o should belong to
libperf-ui.a.  Perhabs we can split libperf-tui.a and not link it to the
python module.  But still, it's better to move the common code into the
util directory.

Thanks,
Namhyung