All of lore.kernel.org
 help / color / mirror / Atom feed
* drivers/auxdisplay/line-display.c:89 delete_attachment() warn: iterator used outside loop: 'attachment'
@ 2025-12-13 11:19 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2025-12-13 11:19 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: "Jean-François Lessard" <jefflessard3@gmail.com>
CC: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   a859eca0e4cc96f63ff125dbe5388d961558b0e9
commit: 3ba5c78fe7c5d60edae0c47361f191d40c5c1cf0 auxdisplay: linedisp: support attribute attachment to auxdisplay devices
date:   8 weeks ago
:::::: branch date: 6 hours ago
:::::: commit date: 8 weeks ago
config: i386-randconfig-141-20251212 (https://download.01.org/0day-ci/archive/20251213/202512131917.9L9pfhSQ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.4.0-5) 12.4.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202512131917.9L9pfhSQ-lkp@intel.com/

New smatch warnings:
drivers/auxdisplay/line-display.c:89 delete_attachment() warn: iterator used outside loop: 'attachment'

Old smatch warnings:
drivers/auxdisplay/line-display.c:110 to_linedisp() warn: iterator used outside loop: 'attachment'

vim +/attachment +89 drivers/auxdisplay/line-display.c

3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  72  
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  73  static struct linedisp *delete_attachment(struct device *dev, bool direct)
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  74  {
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  75  	struct linedisp_attachment *attachment;
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  76  	struct linedisp *linedisp;
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  77  
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  78  	guard(spinlock)(&linedisp_attachments_lock);
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  79  
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  80  	list_for_each_entry(attachment, &linedisp_attachments, list) {
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  81  		if (attachment->device == dev &&
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  82  		    attachment->direct == direct)
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  83  			break;
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  84  	}
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  85  
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  86  	if (list_entry_is_head(attachment, &linedisp_attachments, list))
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  87  		return NULL;
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  88  
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18 @89  	linedisp = attachment->linedisp;
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  90  	list_del(&attachment->list);
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  91  	kfree(attachment);
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  92  
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  93  	return linedisp;
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  94  }
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  95  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 2+ messages in thread

* drivers/auxdisplay/line-display.c:89 delete_attachment() warn: iterator used outside loop: 'attachment'
@ 2026-08-06 16:40 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-08-06 16:40 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: "Jean-François Lessard" <jefflessard3@gmail.com>
CC: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   0d839570765118029aa8bf4a95444c6a11aacf85
commit: 3ba5c78fe7c5d60edae0c47361f191d40c5c1cf0 auxdisplay: linedisp: support attribute attachment to auxdisplay devices
date:   10 months ago
:::::: branch date: 25 hours ago
:::::: commit date: 10 months ago
config: x86_64-randconfig-161 (https://download.01.org/0day-ci/archive/20260807/202608070025.KNx97V16-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
smatch: v0.5.0-9187-g5189e3fb

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 3ba5c78fe7c5 ("auxdisplay: linedisp: support attribute attachment to auxdisplay devices")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202608070025.KNx97V16-lkp@intel.com/

New smatch warnings:
drivers/auxdisplay/line-display.c:89 delete_attachment() warn: iterator used outside loop: 'attachment'

Old smatch warnings:
drivers/auxdisplay/line-display.c:110 to_linedisp() warn: iterator used outside loop: 'attachment'

vim +/attachment +89 drivers/auxdisplay/line-display.c

3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  72  
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  73  static struct linedisp *delete_attachment(struct device *dev, bool direct)
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  74  {
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  75  	struct linedisp_attachment *attachment;
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  76  	struct linedisp *linedisp;
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  77  
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  78  	guard(spinlock)(&linedisp_attachments_lock);
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  79  
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  80  	list_for_each_entry(attachment, &linedisp_attachments, list) {
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  81  		if (attachment->device == dev &&
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  82  		    attachment->direct == direct)
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  83  			break;
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  84  	}
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  85  
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  86  	if (list_entry_is_head(attachment, &linedisp_attachments, list))
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  87  		return NULL;
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  88  
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18 @89  	linedisp = attachment->linedisp;
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  90  	list_del(&attachment->list);
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  91  	kfree(attachment);
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  92  
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  93  	return linedisp;
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  94  }
3ba5c78fe7c5d6 Jean-François Lessard 2025-09-18  95  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-08-06 16:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-06 16:40 drivers/auxdisplay/line-display.c:89 delete_attachment() warn: iterator used outside loop: 'attachment' kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2025-12-13 11:19 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.