* [PATCH] Input: xpad - fix button mapping on Razer Atrox Xbox One
@ 2026-08-07 14:14 Vernon Di Carlo
2026-08-07 14:22 ` sashiko-bot
2026-08-07 14:41 ` [PATCH v2] " Vernon Di Carlo
0 siblings, 2 replies; 4+ messages in thread
From: Vernon Di Carlo @ 2026-08-07 14:14 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, linux-kernel, Vernon Di Carlo
The Razer Atrox Arcade Stick for Xbox One (1532:0a00) does not use
the standard Xbox One input layout for its shoulder and trigger
buttons.
USB captures show that LB and RB are reported in bits 5 and 4 of
byte 5 respectively, opposite to the standard Xbox One mapping.
The digital LT and RT states are reported in bits 7 and 6 of byte
22 instead of the standard analog trigger fields.
As a result, xpad currently reports LB and RB swapped and does not
report LT or RT at all.
Add an Atrox-specific mapping quirk to swap LB/RB and report LT/RT
from their actual locations.
Tested with a Razer Atrox Arcade Stick for Xbox One, USB ID
1532:0a00.
Signed-off-by: Vernon Di Carlo <vernondicarlo@gmail.com>
---
drivers/input/joystick/xpad.c | 26 +++++++++++++++++++-------
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index feb8f368f..b9daa334e 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -50,6 +50,7 @@
#define MAP_PADDLES BIT(4)
#define MAP_PROFILE_BUTTON BIT(5)
#define MAP_SHARE_OFFSET BIT(6)
+#define MAP_ATROX BIT(7)
#define DANCEPAD_MAP_CONFIG (MAP_DPAD_TO_BUTTONS | \
MAP_TRIGGERS_TO_BUTTONS | MAP_STICKS_TO_NULL)
@@ -280,7 +281,8 @@ static const struct xpad_device {
{ 0x1430, 0xf801, "RedOctane Controller", 0, XTYPE_XBOX360 },
{ 0x146b, 0x0601, "BigBen Interactive XBOX 360 Controller", 0, XTYPE_XBOX360 },
{ 0x146b, 0x0604, "Bigben Interactive DAIJA Arcade Stick", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 },
- { 0x1532, 0x0a00, "Razer Atrox Arcade Stick", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
+ { 0x1532, 0x0a00, "Razer Atrox Arcade Stick",
+ MAP_TRIGGERS_TO_BUTTONS | MAP_ATROX, XTYPE_XBOXONE },
{ 0x1532, 0x0a03, "Razer Wildcat", 0, XTYPE_XBOXONE },
{ 0x1532, 0x0a29, "Razer Wolverine V2", 0, XTYPE_XBOXONE },
{ 0x1532, 0x0a57, "Razer Wolverine V3 Pro (Wired)", 0, XTYPE_XBOX360 },
@@ -1110,8 +1112,13 @@ static void xpadone_process_packet(struct usb_xpad *xpad, u16 cmd, unsigned char
}
/* TL/TR */
- input_report_key(dev, BTN_TL, data[5] & BIT(4));
- input_report_key(dev, BTN_TR, data[5] & BIT(5));
+ if (xpad->mapping & MAP_ATROX) {
+ input_report_key(dev, BTN_TL, data[5] & BIT(5));
+ input_report_key(dev, BTN_TR, data[5] & BIT(4));
+ } else {
+ input_report_key(dev, BTN_TL, data[5] & BIT(4));
+ input_report_key(dev, BTN_TR, data[5] & BIT(5));
+ }
/* stick press left/right */
input_report_key(dev, BTN_THUMBL, data[5] & BIT(6));
@@ -1133,10 +1140,15 @@ static void xpadone_process_packet(struct usb_xpad *xpad, u16 cmd, unsigned char
/* triggers left/right */
if (xpad->mapping & MAP_TRIGGERS_TO_BUTTONS) {
- input_report_key(dev, BTN_TL2,
- (__u16) le16_to_cpup((__le16 *)(data + 6)));
- input_report_key(dev, BTN_TR2,
- (__u16) le16_to_cpup((__le16 *)(data + 8)));
+ if ((xpad->mapping & MAP_ATROX) && len > 22) {
+ input_report_key(dev, BTN_TL2, data[22] & BIT(7));
+ input_report_key(dev, BTN_TR2, data[22] & BIT(6));
+ } else {
+ input_report_key(dev, BTN_TL2,
+ (__u16) le16_to_cpup((__le16 *)(data + 6)));
+ input_report_key(dev, BTN_TR2,
+ (__u16) le16_to_cpup((__le16 *)(data + 8)));
+ }
} else {
input_report_abs(dev, ABS_Z,
(__u16) le16_to_cpup((__le16 *)(data + 6)));
--
2.53.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Input: xpad - fix button mapping on Razer Atrox Xbox One
2026-08-07 14:14 [PATCH] Input: xpad - fix button mapping on Razer Atrox Xbox One Vernon Di Carlo
@ 2026-08-07 14:22 ` sashiko-bot
2026-08-07 14:41 ` [PATCH v2] " Vernon Di Carlo
1 sibling, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-08-07 14:22 UTC (permalink / raw)
To: Vernon Di Carlo; +Cc: linux-input, dmitry.torokhov
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect fallback logic for short packets on Razer Atrox Xbox One controllers
--
--- Patch [1]: [PATCH] Input: xpad - fix button mapping on Razer Atrox Xbox One ---
commit 13a313431546b71a3cf1a1ca198625dd7324af1f
Author: Vernon Di Carlo <vernondicarlo@gmail.com>
Input: xpad - fix button mapping on Razer Atrox Xbox One
This commit adds a specific mapping quirk for the Razer Atrox Arcade Stick
to swap LB/RB and correctly report the digital LT/RT states from byte 22.
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index feb8f368f834e..b9daa334e038b 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
[ ... ]
> @@ -1133,10 +1140,15 @@ static void xpadone_process_packet(struct usb_xpad *xpad, u16 cmd, unsigned char
>
> /* triggers left/right */
> if (xpad->mapping & MAP_TRIGGERS_TO_BUTTONS) {
> - input_report_key(dev, BTN_TL2,
> - (__u16) le16_to_cpup((__le16 *)(data + 6)));
> - input_report_key(dev, BTN_TR2,
> - (__u16) le16_to_cpup((__le16 *)(data + 8)));
> + if ((xpad->mapping & MAP_ATROX) && len > 22) {
> + input_report_key(dev, BTN_TL2, data[22] & BIT(7));
> + input_report_key(dev, BTN_TR2, data[22] & BIT(6));
> + } else {
[Severity: Medium]
If a Razer Atrox controller sends a packet with a length of 22 bytes or
fewer, won't this fall through to the else block?
Does this cause the driver to incorrectly interpret data[6] and data[8]
as trigger states and report spurious trigger events for this device?
> + input_report_key(dev, BTN_TL2,
> + (__u16) le16_to_cpup((__le16 *)(data + 6)));
> + input_report_key(dev, BTN_TR2,
> + (__u16) le16_to_cpup((__le16 *)(data + 8)));
> + }
> } else {
> input_report_abs(dev, ABS_Z,
> (__u16) le16_to_cpup((__le16 *)(data + 6)));
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260807141419.7930-1-vernondicarlo@gmail.com?part=1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] Input: xpad - fix button mapping on Razer Atrox Xbox One
2026-08-07 14:14 [PATCH] Input: xpad - fix button mapping on Razer Atrox Xbox One Vernon Di Carlo
2026-08-07 14:22 ` sashiko-bot
@ 2026-08-07 14:41 ` Vernon Di Carlo
2026-08-07 14:58 ` sashiko-bot
1 sibling, 1 reply; 4+ messages in thread
From: Vernon Di Carlo @ 2026-08-07 14:41 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, linux-kernel, Vernon Di Carlo
The Razer Atrox Arcade Stick for Xbox One (1532:0a00) does not use
the standard Xbox One input layout for its shoulder and trigger
buttons.
USB captures show that LB and RB are reported in bits 5 and 4 of
byte 5 respectively, opposite to the standard Xbox One mapping.
The digital LT and RT states are reported in bits 7 and 6 of byte
22 instead of the standard analog trigger fields.
As a result, xpad currently reports LB and RB swapped and does not
report LT or RT at all.
Add an Atrox-specific mapping quirk to swap LB/RB and report LT/RT
from their actual locations.
Tested with a Razer Atrox Arcade Stick for Xbox One, USB ID
1532:0a00.
Signed-off-by: Vernon Di Carlo <vernondicarlo@gmail.com>
---
Notes:
Changes in v2:
- Reject short Atrox input packets instead of falling back to the
standard Xbox One trigger layout.
drivers/input/joystick/xpad.c | 29 ++++++++++++++++++++++-------
1 file changed, 22 insertions(+), 7 deletions(-)
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index feb8f368f..00de9145e 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -50,6 +50,7 @@
#define MAP_PADDLES BIT(4)
#define MAP_PROFILE_BUTTON BIT(5)
#define MAP_SHARE_OFFSET BIT(6)
+#define MAP_ATROX BIT(7)
#define DANCEPAD_MAP_CONFIG (MAP_DPAD_TO_BUTTONS | \
MAP_TRIGGERS_TO_BUTTONS | MAP_STICKS_TO_NULL)
@@ -280,7 +281,8 @@ static const struct xpad_device {
{ 0x1430, 0xf801, "RedOctane Controller", 0, XTYPE_XBOX360 },
{ 0x146b, 0x0601, "BigBen Interactive XBOX 360 Controller", 0, XTYPE_XBOX360 },
{ 0x146b, 0x0604, "Bigben Interactive DAIJA Arcade Stick", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 },
- { 0x1532, 0x0a00, "Razer Atrox Arcade Stick", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
+ { 0x1532, 0x0a00, "Razer Atrox Arcade Stick",
+ MAP_TRIGGERS_TO_BUTTONS | MAP_ATROX, XTYPE_XBOXONE },
{ 0x1532, 0x0a03, "Razer Wildcat", 0, XTYPE_XBOXONE },
{ 0x1532, 0x0a29, "Razer Wolverine V2", 0, XTYPE_XBOXONE },
{ 0x1532, 0x0a57, "Razer Wolverine V3 Pro (Wired)", 0, XTYPE_XBOX360 },
@@ -1079,6 +1081,9 @@ static void xpadone_process_packet(struct usb_xpad *xpad, u16 cmd, unsigned char
error);
}
} else if (data[0] == GIP_CMD_INPUT) { /* The main valid packet type for inputs */
+ if ((xpad->mapping & MAP_ATROX) && len <= 22)
+ return;
+
/* menu/view buttons */
input_report_key(dev, BTN_START, data[4] & BIT(2));
input_report_key(dev, BTN_SELECT, data[4] & BIT(3));
@@ -1110,8 +1115,13 @@ static void xpadone_process_packet(struct usb_xpad *xpad, u16 cmd, unsigned char
}
/* TL/TR */
- input_report_key(dev, BTN_TL, data[5] & BIT(4));
- input_report_key(dev, BTN_TR, data[5] & BIT(5));
+ if (xpad->mapping & MAP_ATROX) {
+ input_report_key(dev, BTN_TL, data[5] & BIT(5));
+ input_report_key(dev, BTN_TR, data[5] & BIT(4));
+ } else {
+ input_report_key(dev, BTN_TL, data[5] & BIT(4));
+ input_report_key(dev, BTN_TR, data[5] & BIT(5));
+ }
/* stick press left/right */
input_report_key(dev, BTN_THUMBL, data[5] & BIT(6));
@@ -1133,10 +1143,15 @@ static void xpadone_process_packet(struct usb_xpad *xpad, u16 cmd, unsigned char
/* triggers left/right */
if (xpad->mapping & MAP_TRIGGERS_TO_BUTTONS) {
- input_report_key(dev, BTN_TL2,
- (__u16) le16_to_cpup((__le16 *)(data + 6)));
- input_report_key(dev, BTN_TR2,
- (__u16) le16_to_cpup((__le16 *)(data + 8)));
+ if (xpad->mapping & MAP_ATROX) {
+ input_report_key(dev, BTN_TL2, data[22] & BIT(7));
+ input_report_key(dev, BTN_TR2, data[22] & BIT(6));
+ } else {
+ input_report_key(dev, BTN_TL2,
+ (__u16) le16_to_cpup((__le16 *)(data + 6)));
+ input_report_key(dev, BTN_TR2,
+ (__u16) le16_to_cpup((__le16 *)(data + 8)));
+ }
} else {
input_report_abs(dev, ABS_Z,
(__u16) le16_to_cpup((__le16 *)(data + 6)));
--
2.53.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] Input: xpad - fix button mapping on Razer Atrox Xbox One
2026-08-07 14:41 ` [PATCH v2] " Vernon Di Carlo
@ 2026-08-07 14:58 ` sashiko-bot
0 siblings, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-08-07 14:58 UTC (permalink / raw)
To: Vernon Di Carlo; +Cc: dmitry.torokhov, linux-input
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Handling GIP_CMD_ANNOUNCE in the URB completion handler calls xpad_start_input(), which sleeps and double-submits the URB.
--
--- Patch [1]: [PATCH v2] Input: xpad - fix button mapping on Razer Atrox Xbox One ---
commit f5450a413687f18b1cfa1f3ba3fe1938a5e5c72f
Author: Vernon Di Carlo <vernondicarlo@gmail.com>
Input: xpad - fix button mapping on Razer Atrox Xbox One
This patch adds an Atrox-specific mapping quirk to swap LB/RB and report
LT/RT from their actual locations for the Razer Atrox Arcade Stick for Xbox
One. It also rejects short Atrox input packets.
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index feb8f368f834e..00de9145e0916 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
[ ... ]
> @@ -1079,6 +1081,9 @@ static void xpadone_process_packet(struct usb_xpad *xpad, u16 cmd, unsigned char
> error);
> }
[Severity: High]
This is a pre-existing issue, but while looking at this context, I noticed
that handling GIP_CMD_ANNOUNCE here calls xpad_start_input(), which appears
to sleep in atomic context and double-submit the URB.
Since xpadone_process_packet() is called from the URB completion handler
xpad_irq_in() (atomic context), does calling xpad_start_input() trigger a
sleeping in atomic context bug?
Looking at xpad_start_input(), it makes a GFP_KERNEL allocation and submits
the URB:
if (usb_submit_urb(xpad->irq_in, GFP_KERNEL))
return -EIO;
Then when it returns, xpad_irq_in() subsequently attempts to submit the same
URB a second time:
retval = usb_submit_urb(urb, GFP_ATOMIC);
Could this lead to deadlocks or panics, and potentially corrupt the USB
core state due to the double submission?
> } else if (data[0] == GIP_CMD_INPUT) { /* The main valid packet type for inputs */
> + if ((xpad->mapping & MAP_ATROX) && len <= 22)
> + return;
> +
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260807144153.8430-1-vernondicarlo@gmail.com?part=1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-08-07 14:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-07 14:14 [PATCH] Input: xpad - fix button mapping on Razer Atrox Xbox One Vernon Di Carlo
2026-08-07 14:22 ` sashiko-bot
2026-08-07 14:41 ` [PATCH v2] " Vernon Di Carlo
2026-08-07 14:58 ` sashiko-bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.