From: sashiko-bot@kernel.org
To: "Adrian Hunter" <adrian.hunter@intel.com>
Cc: Frank.Li@kernel.org, linux-i3c@lists.infradead.org,
linux-pci@vger.kernel.org,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH V5 03/14] i3c: master: Do not treat master device as a duplicate target
Date: Fri, 07 Aug 2026 15:07:00 +0000 [thread overview]
Message-ID: <20260807150701.DD3191F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260807145638.168865-4-adrian.hunter@intel.com>
> i3c_master_search_i3c_dev_duplicate() searches the bus for another I3C
> device with the same PID as the reference device. The search can match
> master->this, causing the controller itself to be returned as a
> duplicate.
>
> Since the controller is not a target device, it cannot be a duplicate of
> one. Exclude master->this from matching so that the function only
> returns real duplicate target devices.
>
> Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
> Cc: stable@vger.kernel.org
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260807145638.168865-1-adrian.hunter@intel.com?part=3
WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Adrian Hunter" <adrian.hunter@intel.com>
Cc: Frank.Li@kernel.org, linux-i3c@lists.infradead.org,
linux-pci@vger.kernel.org,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH V5 03/14] i3c: master: Do not treat master device as a duplicate target
Date: Fri, 07 Aug 2026 15:07:00 +0000 [thread overview]
Message-ID: <20260807150701.DD3191F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260807145638.168865-4-adrian.hunter@intel.com>
> i3c_master_search_i3c_dev_duplicate() searches the bus for another I3C
> device with the same PID as the reference device. The search can match
> master->this, causing the controller itself to be returned as a
> duplicate.
>
> Since the controller is not a target device, it cannot be a duplicate of
> one. Exclude master->this from matching so that the function only
> returns real duplicate target devices.
>
> Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
> Cc: stable@vger.kernel.org
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260807145638.168865-1-adrian.hunter@intel.com?part=3
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2026-08-07 15:07 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 14:56 [PATCH V5 00/14] i3c: Support IBI-based system wakeup Adrian Hunter
2026-08-07 14:56 ` Adrian Hunter
2026-08-07 14:56 ` [PATCH V5 01/14] i3c: master: Fix recursive locking during device registration Adrian Hunter
2026-08-07 14:56 ` Adrian Hunter
2026-08-07 15:26 ` sashiko-bot
2026-08-07 15:26 ` sashiko-bot
2026-08-07 14:56 ` [PATCH V5 02/14] i3c: Fix unlocked dereference of dev->desc in i3c_device_get_supported_xfer_mode() Adrian Hunter
2026-08-07 14:56 ` Adrian Hunter
2026-08-07 15:13 ` sashiko-bot
2026-08-07 15:13 ` sashiko-bot
2026-08-07 14:56 ` [PATCH V5 03/14] i3c: master: Do not treat master device as a duplicate target Adrian Hunter
2026-08-07 14:56 ` Adrian Hunter
2026-08-07 15:07 ` sashiko-bot [this message]
2026-08-07 15:07 ` sashiko-bot
2026-08-07 14:56 ` [PATCH V5 04/14] i3c: master: Fix use-after-free of master->this Adrian Hunter
2026-08-07 14:56 ` Adrian Hunter
2026-08-07 15:14 ` sashiko-bot
2026-08-07 15:14 ` sashiko-bot
2026-08-07 14:56 ` [PATCH V5 05/14] i3c: Make dev->desc locking assumptions explicit Adrian Hunter
2026-08-07 14:56 ` Adrian Hunter
2026-08-07 15:20 ` sashiko-bot
2026-08-07 15:20 ` sashiko-bot
2026-08-07 14:56 ` [PATCH V5 06/14] i3c: master: Fix potential UAF in i3c_device_uevent() Adrian Hunter
2026-08-07 14:56 ` Adrian Hunter
2026-08-07 15:21 ` sashiko-bot
2026-08-07 15:21 ` sashiko-bot
2026-08-07 14:56 ` [PATCH V5 07/14] i3c: master: Fix potential UAF in i3c_device_match() Adrian Hunter
2026-08-07 14:56 ` Adrian Hunter
2026-08-07 15:37 ` sashiko-bot
2026-08-07 15:37 ` sashiko-bot
2026-08-07 19:43 ` Frank Li
2026-08-07 19:43 ` Frank Li
2026-08-08 13:07 ` Alexandre Belloni
2026-08-08 13:07 ` Alexandre Belloni
2026-08-07 14:56 ` [PATCH V5 08/14] i3c: master: Support IBI-based wakeup capability Adrian Hunter
2026-08-07 14:56 ` Adrian Hunter
2026-08-07 15:16 ` sashiko-bot
2026-08-07 15:16 ` sashiko-bot
2026-08-07 14:56 ` [PATCH V5 09/14] i3c: master: Report wakeup events for IBIs Adrian Hunter
2026-08-07 14:56 ` Adrian Hunter
2026-08-07 15:41 ` sashiko-bot
2026-08-07 15:41 ` sashiko-bot
2026-08-07 14:56 ` [PATCH V5 10/14] i3c: master: Add helper to query bus wakeup requirements Adrian Hunter
2026-08-07 14:56 ` Adrian Hunter
2026-08-07 15:21 ` sashiko-bot
2026-08-07 15:21 ` sashiko-bot
2026-08-07 14:56 ` [PATCH V5 11/14] i3c: master: Reject IBI requests from non-IBI-capable devices Adrian Hunter
2026-08-07 14:56 ` Adrian Hunter
2026-08-07 15:26 ` sashiko-bot
2026-08-07 15:26 ` sashiko-bot
2026-08-07 14:56 ` [PATCH V5 12/14] i3c: mipi-i3c-hci-pci: Propagate I3C wakeup requirements to PCI Adrian Hunter
2026-08-07 14:56 ` Adrian Hunter
2026-08-07 15:38 ` sashiko-bot
2026-08-07 15:38 ` sashiko-bot
2026-08-07 14:56 ` [PATCH V5 13/14] i3c: mipi-i3c-hci: Factor out i3c_hci_sysdev() Adrian Hunter
2026-08-07 14:56 ` Adrian Hunter
2026-08-07 15:40 ` sashiko-bot
2026-08-07 15:40 ` sashiko-bot
2026-08-07 14:56 ` [PATCH V5 14/14] i3c: mipi-i3c-hci: Advertise IBI wakeup capability Adrian Hunter
2026-08-07 14:56 ` Adrian Hunter
2026-08-07 15:30 ` sashiko-bot
2026-08-07 15:30 ` sashiko-bot
2026-08-08 13:09 ` [PATCH V5 00/14] i3c: Support IBI-based system wakeup Alexandre Belloni
2026-08-08 13:09 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260807150701.DD3191F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.