All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH b4] b4: Ignore Signed-off-by trailers in follow-up replies
@ 2026-08-08 16:47 Mostafa Saleh
  0 siblings, 0 replies; only message in thread
From: Mostafa Saleh @ 2026-08-08 16:47 UTC (permalink / raw)
  To: tools; +Cc: Mostafa Saleh

When someone replies to a patch thread, sometimes they include a
Signed-off-by trailer (for example, when providing inline diffs or
snippets in a reply). Currently, b4 am/shazam collect these tags
from replies and append them to the main patch's trailers.

I am not aware of any use case when collecting the Signed-off-by
is needed, so drop it in this case.

Assisted-by: Gemini:gemini-3.1-pro-preview
Signed-off-by: Mostafa Saleh <smostafa@google.com>

---
I hit this when using:
b4 shazam -v1 https://lore.kernel.org/all/20260806150105.4010701-1-smostafa@google.com/

It collected the tag from Marc's patch in my patch as in:
https://lore.kernel.org/all/20260808085824.732659-4-smostafa@google.com/
Which is wrong.
---
 src/b4/__init__.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/b4/__init__.py b/src/b4/__init__.py
index a52b001..fd33111 100644
--- a/src/b4/__init__.py
+++ b/src/b4/__init__.py
@@ -1857,6 +1857,7 @@ class LoreMessage:
                     'base-commit',
                     'change-id',
                     'message-id',
+                    'signed-off-by',
                 }
                 if trailer.lname not in badtrailers:
                     trailer.lmsg = self
-- 
2.55.0.654.g21b8a5bc05-goog


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-08-08 16:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-08 16:47 [PATCH b4] b4: Ignore Signed-off-by trailers in follow-up replies Mostafa Saleh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.