Re: [PATCH 3/5] xfs: fix zoned write iomap flags assignments

[Christoph Hellwig <hch@lst.de>]

On Mon, Aug 10, 2026 at 06:25:47PM +0200, Andrey Albershteyn wrote:
> > diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> > index c80f05507373..9506cd8d15e6 100644
> > --- a/fs/xfs/xfs_aops.c
> > +++ b/fs/xfs/xfs_aops.c
> > @@ -634,11 +634,10 @@ xfs_zoned_map_blocks(
> >  	xfs_iunlock(ip, XFS_ILOCK_EXCL);
> >  
> >  	wpc->iomap.type = IOMAP_MAPPED;
> > -	wpc->iomap.flags = IOMAP_F_DIRTY;
> >  	wpc->iomap.bdev = mp->m_rtdev_targp->bt_bdev;
> >  	wpc->iomap.offset = offset;
> >  	wpc->iomap.length = XFS_FSB_TO_B(mp, count_fsb);
> > -	wpc->iomap.flags = IOMAP_F_ANON_WRITE;
> > +	wpc->iomap.flags = IOMAP_F_ANON_WRITE | IOMAP_F_DIRTY;
> 
> Does it make sense to set IOMAP_F_DIRTY here? I haven't found how it
> could be used

Well, by the protocol of the flag we should set it as the update
requires a transaction to be persisted.  But you are right in the
sense that nothing actually looks at it for zoned right now.