* [PATCH] thermal/drivers/armada: Fix missing bitfields include
@ 2026-08-11 9:47 Daniel Lezcano
2026-08-11 13:15 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Lezcano @ 2026-08-11 9:47 UTC (permalink / raw)
To: rafael, daniel.lezcano
Cc: bblima, linux-kernel, linux-pm, Daniel Lezcano, kernel test robot,
Miquel Raynal, Zhang Rui, Lukasz Luba
From: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
Add the missing include leading to the error:
error: implicit declaration of function ‘FIELD_GET’ [-Werror=implicit-function-declaration]
184 | if (FIELD_GET(MON_FAULT_STATUS_MASK, val) == MON_FAULT_LVL1_UPR)
| ^~~~~~~~~
cc1: all warnings being treated as errors
Fixes: cbe31d5ce498 ("thermal/drivers/armada: Use bitfield and bitmask macros")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202608082242.drjXuzsN-lkp@intel.com/
Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
---
drivers/thermal/armada_thermal.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
index 912c68a44bdc..ff63b4f2b977 100644
--- a/drivers/thermal/armada_thermal.c
+++ b/drivers/thermal/armada_thermal.c
@@ -4,6 +4,7 @@
*
* Copyright (C) 2013 Marvell
*/
+#include <linux/bitfield.h>
#include <linux/device.h>
#include <linux/err.h>
#include <linux/io.h>
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] thermal/drivers/armada: Fix missing bitfields include
2026-08-11 9:47 [PATCH] thermal/drivers/armada: Fix missing bitfields include Daniel Lezcano
@ 2026-08-11 13:15 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2026-08-11 13:15 UTC (permalink / raw)
To: Daniel Lezcano
Cc: rafael, daniel.lezcano, bblima, linux-kernel, linux-pm,
kernel test robot, Zhang Rui, Lukasz Luba
On 11/08/2026 at 11:47:47 +02, Daniel Lezcano <daniel.lezcano@oss.qualcomm.com> wrote:
> From: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
>
> Add the missing include leading to the error:
>
> error: implicit declaration of function ‘FIELD_GET’ [-Werror=implicit-function-declaration]
> 184 | if (FIELD_GET(MON_FAULT_STATUS_MASK, val) == MON_FAULT_LVL1_UPR)
> | ^~~~~~~~~
> cc1: all warnings being treated as errors
>
> Fixes: cbe31d5ce498 ("thermal/drivers/armada: Use bitfield and bitmask macros")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202608082242.drjXuzsN-lkp@intel.com/
> Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-11 13:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-11 9:47 [PATCH] thermal/drivers/armada: Fix missing bitfields include Daniel Lezcano
2026-08-11 13:15 ` Miquel Raynal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.