* [PATCH v2] file-posix: fix zone write granularity assignment for zoned block devices
@ 2026-08-11 13:32 Niklas Cassel
0 siblings, 0 replies; only message in thread
From: Niklas Cassel @ 2026-08-11 13:32 UTC (permalink / raw)
To: Kevin Wolf, Hanna Reitz
Cc: qemu-block, qemu-devel, Sam Li, Stefan Hajnoczi, Damien Le Moal,
Niklas Cassel
In the ZBC and ZAC specifications, the requirement is that the write
granularity matches the physical block size.
However, in the ZNS specification, the requirement is simply that the
write granularity matches the logical block size.
See:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a805a4fa4fa376bbc145762bb8b09caa2fa8af48
In Linux, there is a zone_write_granularity sysfs property which abstracts
this away, so let's make use of it.
Currently, it is theoretically possible that QEMU presents an inflated
write granularity for NVMe devices where the physical block size is larger
than the logical block size.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Fixes: a3c41f06d5a8 ("file-posix: add tracking of the zone write pointers")
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
Changes since v1:
-Improved commit log.
-Picked up tag.
block/file-posix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index 3c985da94f..63c52b1044 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -1495,7 +1495,7 @@ static void raw_refresh_zoned_limits(BlockDriverState *bs, struct stat *st,
bs->bl.max_append_sectors = ret >> BDRV_SECTOR_BITS;
}
- ret = get_sysfs_long_val(st, "physical_block_size");
+ ret = get_sysfs_long_val(st, "zone_write_granularity");
if (ret >= 0) {
bs->bl.write_granularity = ret;
}
--
2.55.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-08-11 13:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-11 13:32 [PATCH v2] file-posix: fix zone write granularity assignment for zoned block devices Niklas Cassel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.