All of lore.kernel.org
 help / color / mirror / Atom feed
From: Melissa Wen <mwen@igalia.com>
To: Petri Latvala <adrinael@adrinael.net>,
	Arkadiusz Hiler <arek@hiler.eu>,
	Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
	Bhanuprakash Modem <bhanuprakash.modem@gmail.com>,
	Ashutosh Dixit <ashutosh.dixit@intel.com>,
	Karthik B S <karthik.b.s@intel.com>
Cc: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>,
	igt-dev@lists.freedesktop.org, kernel-dev@igalia.com,
	Alex Hung <alex.hung@amd.com>,
	Swati Sharma <swati2.sharma@intel.com>,
	John Harrison <John.Harrison@Igalia.com>,
	Rodrigo Siqueira <siqueira@igalia.com>,
	Simon Ser <contact@emersion.fr>, Xaver Hugl <xaver.hugl@kde.org>,
	Harry Wentland <harry.wentland@amd.com>,
	Uma Shankar <uma.shankar@intel.com>
Subject: [PATCH i-g-t v3 4/6] tests/kms_properties: keep primary plane enabled for each CRTC
Date: Tue, 11 Aug 2026 16:23:04 +0200	[thread overview]
Message-ID: <20260811143558.141813-5-mwen@igalia.com> (raw)
In-Reply-To: <20260811143558.141813-1-mwen@igalia.com>

For AMD, a primary plane must be active to keep CRTC active. So stop
reusing primary plane fb for overlays, give the latter its own fb.

Signed-off-by: Melissa Wen <mwen@igalia.com>

---

v2:
- detach different changes from a single commit (Chaitanya)
---
 tests/kms_properties.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/tests/kms_properties.c b/tests/kms_properties.c
index 292a04a2a..87614346a 100644
--- a/tests/kms_properties.c
+++ b/tests/kms_properties.c
@@ -237,7 +237,7 @@ static void run_colorop_property_tests(igt_display_t *display,
 				       igt_crtc_t *crtc, igt_output_t *output,
 				       bool atomic)
 {
-	struct igt_fb fb;
+	struct igt_fb fb, afb;
 	igt_plane_t *plane;
 	igt_colorop_t *colorop;
 	int i;
@@ -255,6 +255,16 @@ static void run_colorop_property_tests(igt_display_t *display,
 			 igt_crtc_name(crtc), plane->index,
 			 kmstest_plane_type_name(plane->type), output->name);
 
+		/* AMD requires primary plane enabled to keep CRTC enabled */
+		if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
+			drmModeModeInfo *mode = igt_output_get_mode(output);
+
+			igt_create_pattern_fb(display->drm_fd, mode->hdisplay, mode->vdisplay,
+					      DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &afb);
+
+			igt_plane_set_fb(plane, &afb);
+		}
+
 		/* iterate over all color pipelines on plane */
 		for (i = 0; i < plane->num_color_pipelines; ++i) {
 			/* iterate over all colorops in pipeline*/
-- 
2.53.0


  parent reply	other threads:[~2026-08-11 14:41 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 14:23 [PATCH i-g-t v3 0/6] test/kms_colorop_helper: don't request colorop updates indefinitely Melissa Wen
2026-08-11 14:23 ` [PATCH i-g-t v3 1/6] lib/igt_kms: clear colorop-changed flag after commit Melissa Wen
2026-08-11 16:37   ` Jani Nikula
2026-08-14  3:39   ` Alex Hung
2026-08-11 14:23 ` [PATCH i-g-t v3 2/6] test/kms_colorop_helper: only check if a given enum value exist Melissa Wen
2026-08-14  3:41   ` Alex Hung
2026-08-11 14:23 ` [PATCH i-g-t v3 3/6] tests/kms_properties: don't check colorop if no plane color pipeline prop Melissa Wen
2026-08-14  3:44   ` Alex Hung
2026-08-11 14:23 ` Melissa Wen [this message]
2026-08-14  4:05   ` [PATCH i-g-t v3 4/6] tests/kms_properties: keep primary plane enabled for each CRTC Alex Hung
2026-08-14  6:20     ` Borah, Chaitanya Kumar
2026-08-17 15:16       ` Melissa Wen
2026-08-11 14:23 ` [PATCH i-g-t v3 6/6] tests/kms_color_pipeline: skip if not an intel device Melissa Wen
2026-08-14  3:55   ` Alex Hung
2026-08-17 15:19     ` Melissa Wen
2026-08-17 15:39       ` Harry Wentland
2026-08-17 16:08         ` Harry Wentland
2026-08-18 13:54         ` Melissa Wen
2026-08-18 14:30           ` Harry Wentland
2026-08-18 14:50             ` Melissa Wen
2026-08-19  5:24               ` Borah, Chaitanya Kumar
2026-08-21 11:53                 ` Sharma, Swati2
2026-08-11 16:43 ` ✓ Xe.CI.BAT: success for test/kms_colorop_helper: don't request colorop updates indefinitely (rev2) Patchwork
2026-08-11 16:59 ` ✓ i915.CI.BAT: " Patchwork
2026-08-11 18:43 ` ✓ Xe.CI.FULL: " Patchwork
2026-08-11 19:21 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260811143558.141813-5-mwen@igalia.com \
    --to=mwen@igalia.com \
    --cc=John.Harrison@Igalia.com \
    --cc=adrinael@adrinael.net \
    --cc=alex.hung@amd.com \
    --cc=arek@hiler.eu \
    --cc=ashutosh.dixit@intel.com \
    --cc=bhanuprakash.modem@gmail.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=contact@emersion.fr \
    --cc=harry.wentland@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juhapekka.heikkila@gmail.com \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=karthik.b.s@intel.com \
    --cc=kernel-dev@igalia.com \
    --cc=siqueira@igalia.com \
    --cc=swati2.sharma@intel.com \
    --cc=uma.shankar@intel.com \
    --cc=xaver.hugl@kde.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.