Re: [PATCH i-g-t v3 3/6] tests/kms_properties: don't check colorop if no plane color pipeline prop

[Alex Hung <alex.hung@amd.com>]

See typos and mistakes in commit message below; otherwise
Reviewed-by: Alex Hung <alex.hung@amd.com>

On 8/11/26 08:23, Melissa Wen wrote:
> If plane COLOR_PIPELINE property is not avaliable, the plane doesn't
"available"

> support colorop pipeline and there is no meaning in check colorop
"checking"

> properties here too. Don't check colorop properties in planes that
> doesn't support it (for example, in cursor planes of AMD driver).
"don't"

> 
> Signed-off-by: Melissa Wen <mwen@igalia.com>
> 
> ---
> 
> v2:
> - detach different changes from a single commit (Chaitanya)
> ---
>   tests/kms_properties.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tests/kms_properties.c b/tests/kms_properties.c
> index 93bf1ea26..292a04a2a 100644
> --- a/tests/kms_properties.c
> +++ b/tests/kms_properties.c
> @@ -247,6 +247,10 @@ static void run_colorop_property_tests(igt_display_t *display,
>   		     &fb);
>   
>   	for_each_plane_on_crtc(crtc, plane) {
> +		/* don't check colorop in planes without support to color pipeline */
> +		if (!igt_plane_has_prop(plane, IGT_PLANE_COLOR_PIPELINE))
> +			continue;
> +
>   		igt_info("Testing colorop properties on plane %s.#%d-%s (output: %s)\n",
>   			 igt_crtc_name(crtc), plane->index,
>   			 kmstest_plane_type_name(plane->type), output->name);