* [withdrawn] radix-tree-fix-kmemleak-false-positives-on-tree-head-reassignment.patch removed from -mm tree
@ 2026-08-11 17:25 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-08-11 17:25 UTC (permalink / raw)
To: mm-commits, willy, kent.overstreet, catalin.marinas, bigeasy,
arnd, leitao, akpm
The quilt patch titled
Subject: radix-tree: fix kmemleak false positives on tree head reassignment
has been removed from the -mm tree. Its filename was
radix-tree-fix-kmemleak-false-positives-on-tree-head-reassignment.patch
This patch was dropped because it was withdrawn
------------------------------------------------------
From: Breno Leitao <leitao@debian.org>
Subject: radix-tree: fix kmemleak false positives on tree head reassignment
Date: Fri, 03 Jul 2026 08:22:03 -0700
Kmemleak periodically reports transient false positives for radix tree
nodes allocated through the IDR, for example:
unreferenced object 0xffff0004d6ac4200 (size 576):
comm "tcpeventd", pid 6412
backtrace (crc 335d668a):
kmem_cache_alloc_noprof
radix_tree_node_alloc
radix_tree_extend
idr_get_free
idr_alloc_cyclic
map_create
__sys_bpf
radix_tree_extend() (grow) and radix_tree_shrink() (shrink) repoint
root->xa_head to a new node. If a kmemleak scan has already walked past
root->xa_head, the new head is not reachable from any scanned pointer
until the following scan, so kmemleak reports it as leaked even though it
is live.
This is the same race fixed for the XArray API in commit a1a029bcea59
("XArray: fix kmemleak false positive in xas_shrink()"). The IDR uses the
radix tree API directly and hits it on both the grow and the shrink path,
so mark the new head as a transient leak in both.
Add a matching kmemleak_transient_leak() stub to the radix tree test
harness so the userspace lib/radix-tree.c build keeps building.
Link: https://lore.kernel.org/20260703-radix-tree-v2-1-38bb6efb5f6e@debian.org
Signed-off-by: Breno Leitao <leitao@debian.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
lib/radix-tree.c | 7 ++++++-
tools/testing/shared/linux/kmemleak.h | 1 +
2 files changed, 7 insertions(+), 1 deletion(-)
--- a/lib/radix-tree.c~radix-tree-fix-kmemleak-false-positives-on-tree-head-reassignment
+++ a/lib/radix-tree.c
@@ -455,6 +455,8 @@ static int radix_tree_extend(struct radi
node->slots[0] = (void __rcu *)entry;
entry = node_to_entry(node);
rcu_assign_pointer(root->xa_head, entry);
+ /* new head may be missed by an in-progress kmemleak scan */
+ kmemleak_transient_leak(node);
shift += RADIX_TREE_MAP_SHIFT;
} while (shift <= maxshift);
out:
@@ -495,8 +497,11 @@ static inline bool radix_tree_shrink(str
if (!node->shift && is_idr(root))
break;
- if (radix_tree_is_internal_node(child))
+ if (radix_tree_is_internal_node(child)) {
entry_to_node(child)->parent = NULL;
+ /* new head may be missed by an in-progress kmemleak scan */
+ kmemleak_transient_leak(entry_to_node(child));
+ }
/*
* We don't need rcu_assign_pointer(), since we are simply
--- a/tools/testing/shared/linux/kmemleak.h~radix-tree-fix-kmemleak-false-positives-on-tree-head-reassignment
+++ a/tools/testing/shared/linux/kmemleak.h
@@ -1 +1,2 @@
static inline void kmemleak_update_trace(const void *ptr) { }
+static inline void kmemleak_transient_leak(const void *ptr) { }
_
Patches currently in -mm which might be from leitao@debian.org are
mm-vmscan-report-rcu-tasks-quiescent-states-in-shrink_lruvec.patch
mm-kmemleak-report-rcu-tasks-quiescent-states-during-the-scan.patch
mm-kmemleak-report-leaks-only-after-n-consecutive-unreferenced-scans.patch
mm-kmemleak-factor-leak-confirmation-into-a-helper.patch
selftests-mm-test-kmemleaks-n-consecutive-scan-leak-confirmation.patch
mm-kmemleak-default-min_unref_scans-to-2-for-verbose-auto-scan.patch
documentation-kmemleak-document-the-conditional-min_unref_scans-default.patch
selftests-mm-kmemleak-drop-stale-min_unref_scans-default-from-comments.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-08-11 17:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-11 17:25 [withdrawn] radix-tree-fix-kmemleak-false-positives-on-tree-head-reassignment.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.