From: sashiko-bot@kernel.org
To: "Doehyun Baek" <doehyunbaek@gmail.com>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH v7 7/7] docs/zh_CN: update DAMON LRU sort translation
Date: Wed, 12 Aug 2026 07:09:06 +0000 [thread overview]
Message-ID: <20260812070907.43C581F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260812065914.3071433-8-doehyunbaek@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The Chinese translation introduces documentation for module parameters and warnings that do not exist in the kernel source code or the English documentation.
--
--- Patch [7]: [PATCH v7 7/7] docs/zh_CN: update DAMON LRU sort translation ---
commit adc70b54833d5e4ddeaaa02dcb9d816dc74cba6a
Author: Doehyun Baek <doehyunbaek@gmail.com>
docs/zh_CN: update DAMON LRU sort translation
Update the Chinese translation of .../admin-guide/mm/damon/lru_sort.rst.
Update the translation through commit c9380cdd949d
("Docs/{admin-guide,mm}/damon: fix DAMON documentation details").
> diff --git a/Documentation/translations/zh_CN/admin-guide/mm/damon/lru_sort.rst b/Documentation/translations/zh_CN/admin-guide/mm/damon/lru_sort.rst
> index 03d33c710604c..6af0dd59ef5db 100644
> --- a/Documentation/translations/zh_CN/admin-guide/mm/damon/lru_sort.rst
> +++ b/Documentation/translations/zh_CN/admin-guide/mm/damon/lru_sort.rst
[ ... ]
> @@ -71,6 +71,41 @@ commit_inputs
> ,DAMON_LRU_SORT会再次读取除了 ``enabled`` 之外的参数。读取完成后,这个参数会被
> 设置为 ``N`` 。如果在读取时发现有无效参数,DAMON_LRU_SORT会被关闭。
>
> +一旦向该参数写入 ``Y``,用户在再次读取 ``commit_inputs`` 返回 ``N`` 之前,
> +不得写入任何参数。如果用户违反该规则,内核可能表现出未定义行为。
[Severity: Medium]
Does this introduce a warning about undefined behavior that does not exist in
the upstream English documentation?
> +
> +active_mem_bp
> +-------------
[Severity: Medium]
Is active_mem_bp a valid parameter for damon_lru_sort? It appears this might
be documenting a parameter that does not exist in the mainline kernel source
or the English documentation.
> +
> +期望的活跃内存与[非]活跃内存比率,单位为 bp(1/10,000)。
> +
> +在保持其他配额设置的上限的同时,DAMON_LRU_SORT 会自动增减配额的有效水平,
> +目标是让热/冷内存的 LRU [降低]优先级处理产生该活跃内存与[非]活跃内存比率。
> +值为零表示禁用该自动调优功能。
> +
> +默认禁用。
> +
> +autotune_monitoring_intervals
> +-----------------------------
[Severity: Medium]
Does the autotune_monitoring_intervals parameter exist for damon_lru_sort?
> +
> +如果该参数设置为 ``Y``,DAMON_LRU_SORT 会自动调优 DAMON 的采样和聚集间隔。
> +自动调优的目标是在每个 DAMON 快照中捕获有意义数量的访问事件,同时将采样
> +间隔限制在最小 5 毫秒、最大 10 秒。将其设置为 ``N`` 会禁用自动调优。
> +
> +默认禁用。
> +
> +filter_young_pages
> +------------------
[Severity: Medium]
Like the parameters above, does filter_young_pages exist in the mainline
implementation for damon_lru_sort?
> +
> +相应地为 LRU [降低]优先级处理过滤[非]年轻页。
> +
> +如果设置该参数,则在每次 LRU [降低]优先级处理操作前再次检查页级访问
[ ... ]
> @@ -176,14 +213,34 @@ monitor_region_start
>
> 目标内存区域的起始物理地址。
>
> -DAMON_LRU_SORT要处理的目标内存区域的起始物理地址。默认,使用系统最大内存。
> +DAMON_LRU_SORT要处理的目标内存区域的起始物理地址。默认,使用系统的整个物理内存。
>
> monitor_region_end
> ------------------
>
> 目标内存区域的结束物理地址。
>
> -DAMON_LRU_SORT要处理的目标内存区域的结束物理地址。默认,使用系统最大内存。
> +DAMON_LRU_SORT要处理的目标内存区域的结束物理地址。默认,使用系统的整个物理内存。
> +
> +addr_unit
> +---------
> +
> +内存地址和字节数的缩放因子。
> +
> +该参数用于设置和获取 DAMON_RECLAIM 的 DAMON 实例的 :ref:`地址单位 <damon_design_addr_unit_zh_CN>` 参数。
[Severity: Medium]
Is addr_unit a valid parameter for damon_lru_sort? Also, should this
reference DAMON_LRU_SORT instead of DAMON_RECLAIM?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260812065914.3071433-1-doehyunbaek@gmail.com?part=7
prev parent reply other threads:[~2026-08-12 7:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 6:59 [PATCH v7 0/7] docs/zh_CN: update DAMON documentation translation Doehyun Baek
2026-08-12 6:59 ` [PATCH v7 1/7] docs/zh_CN: update DAMON design translation Doehyun Baek
2026-08-12 7:02 ` sashiko-bot
2026-08-12 6:59 ` [PATCH v7 2/7] docs/zh_CN: add DAMON_STAT usage translation Doehyun Baek
2026-08-12 7:07 ` sashiko-bot
2026-08-12 6:59 ` [PATCH v7 3/7] docs/zh_CN: update DAMON index translation Doehyun Baek
2026-08-12 7:05 ` sashiko-bot
2026-08-12 6:59 ` [PATCH v7 4/7] docs/zh_CN: update DAMON start translation Doehyun Baek
2026-08-12 7:07 ` sashiko-bot
2026-08-12 6:59 ` [PATCH v7 5/7] docs/zh_CN: update DAMON usage translation Doehyun Baek
2026-08-12 7:02 ` sashiko-bot
2026-08-12 6:59 ` [PATCH v7 6/7] docs/zh_CN: update DAMON reclaim translation Doehyun Baek
2026-08-12 7:02 ` sashiko-bot
2026-08-12 6:59 ` [PATCH v7 7/7] docs/zh_CN: update DAMON LRU sort translation Doehyun Baek
2026-08-12 7:09 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812070907.43C581F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=doehyunbaek@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.