* + mm-mglru-fix-young-counter-undercount-for-large-folios.patch added to mm-unstable branch
@ 2026-08-12 18:29 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-08-12 18:29 UTC (permalink / raw)
To: mm-commits, zhuhui, yuanchu, weixugc, shakeel.butt, mhocko, ljs,
kasong, hannes, david, baolin.wang, baohua, axelrasmussen,
hui.zhu, akpm
The patch titled
Subject: mm/mglru: Fix young counter undercount for large folios
has been added to the -mm mm-unstable branch. Its filename is
mm-mglru-fix-young-counter-undercount-for-large-folios.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-mglru-fix-young-counter-undercount-for-large-folios.patch
This patch will later appear in the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via various
branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there most days
------------------------------------------------------
From: "Hui Zhu" <hui.zhu@linux.dev>
Subject: mm/mglru: Fix young counter undercount for large folios
Date: Wed, 12 Aug 2026 14:59:33 +0800
In lru_gen_look_around(), the young counter tracks the number of young
PTEs. The original folio's contribution is represented by the initial
value of young: test_and_clear_young_ptes_notify() is called on it at
function entry, and the function returns early if it is not young. In
the subsequent loop, the original folio is skipped (its accessed bits
were already cleared), so it is not double-counted.
However, young is initialized to 1 regardless of the folio size. When
the original folio is a large folio with nr PTEs, its young count is
underestimated by nr - 1. This inconsistency can cause
suitable_to_scan() to return false, preventing the PMD from being added
to the bloom filter and reducing aging accuracy for mTHP workloads.
Initialize young to nr so the original folio is accounted the same way
as other young folios in the loop (young += nr).
Link: https://lore.kernel.org/20260812065933.103627-1-hui.zhu@linux.dev
Fixes: 56e5b60b2114 ("mm: support batched checking of the young flag for MGLRU")
Signed-off-by: Hui Zhu <zhuhui@kylinos.cn>
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Axel Rasmussen <axelrasmussen@google.com>
Cc: Barry Song <baohua@kernel.org>
Cc: David Hildenbrand <david@kernel.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Kairui Song <kasong@tencent.com>
Cc: Lorenzo Stoakes <ljs@kernel.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Wei Xu <weixugc@google.com>
Cc: Yuanchu Xie <yuanchu@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/vmscan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/mm/vmscan.c~mm-mglru-fix-young-counter-undercount-for-large-folios
+++ a/mm/vmscan.c
@@ -4261,7 +4261,7 @@ bool lru_gen_look_around(struct page_vma
unsigned long end;
struct lru_gen_mm_walk *walk;
struct folio *last = NULL;
- int young = 1;
+ int young = nr;
pte_t *pte = pvmw->pte;
unsigned long addr = pvmw->address;
struct vm_area_struct *vma = pvmw->vma;
_
Patches currently in -mm which might be from hui.zhu@linux.dev are
mm-mglru-fix-young-counter-undercount-for-large-folios.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-08-12 18:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-12 18:29 + mm-mglru-fix-young-counter-undercount-for-large-folios.patch added to mm-unstable branch Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.