[PATCH] ASoC: dt-bindings: tse850: Convert to DT schema

[PATCH] ASoC: dt-bindings: tse850: Convert to DT schema

[Bhargav Joshi]

Convert Axentia TSE-850 audio complex from text to DT schema. No
funcational changes.

Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
 .../bindings/sound/axentia,tse850-pcm5142.txt      |  92 ------------------
 .../bindings/sound/axentia,tse850-pcm5142.yaml     | 104 +++++++++++++++++++++
 2 files changed, 104 insertions(+), 92 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/axentia,tse850-pcm5142.txt b/Documentation/devicetree/bindings/sound/axentia,tse850-pcm5142.txt
deleted file mode 100644
index b6cc5f6f78c2..000000000000
--- a/Documentation/devicetree/bindings/sound/axentia,tse850-pcm5142.txt
+++ /dev/null
@@ -1,92 +0,0 @@
-Devicetree bindings for the Axentia TSE-850 audio complex
-
-Required properties:
-  - compatible: "axentia,tse850-pcm5142"
-  - axentia,cpu-dai: The phandle of the cpu dai.
-  - axentia,audio-codec: The phandle of the PCM5142 codec.
-  - axentia,add-gpios: gpio specifier that controls the mixer.
-  - axentia,loop1-gpios: gpio specifier that controls loop relays on channel 1.
-  - axentia,loop2-gpios: gpio specifier that controls loop relays on channel 2.
-  - axentia,ana-supply: Regulator that supplies the output amplifier. Must
-    support voltages in the 2V - 20V range, in 1V steps.
-
-The schematics explaining the gpios are as follows:
-
-               loop1 relays
-   IN1 +---o  +------------+  o---+ OUT1
-            \                /
-             +              +
-             |   /          |
-             +--o  +--.     |
-             |  add   |     |
-             |        V     |
-             |      .---.   |
-   DAC +----------->|Sum|---+
-             |      '---'   |
-             |              |
-             +              +
-
-   IN2 +---o--+------------+--o---+ OUT2
-               loop2 relays
-
-The 'loop1' gpio pin controls two relays, which are either in loop position,
-meaning that input and output are directly connected, or they are in mixer
-position, meaning that the signal is passed through the 'Sum' mixer. Similarly
-for 'loop2'.
-
-In the above, the 'loop1' relays are inactive, thus feeding IN1 to the mixer
-(if 'add' is active) and feeding the mixer output to OUT1. The 'loop2' relays
-are active, short-cutting the TSE-850 from channel 2. IN1, IN2, OUT1 and OUT2
-are TSE-850 connectors and DAC is the PCB name of the (filtered) output from
-the PCM5142 codec.
-
-Example:
-
-	&ssc0 {
-		#sound-dai-cells = <0>;
-
-	};
-
-	&i2c {
-		codec: pcm5142@4c {
-			compatible = "ti,pcm5142";
-
-			reg = <0x4c>;
-
-			AVDD-supply = <&reg_3v3>;
-			DVDD-supply = <&reg_3v3>;
-			CPVDD-supply = <&reg_3v3>;
-
-			clocks = <&sck>;
-
-			pll-in = <3>;
-			pll-out = <6>;
-		};
-	};
-
-	ana: ana-reg {
-		compatible = "pwm-regulator";
-
-		regulator-name = "ANA";
-
-		pwms = <&pwm0 2 1000 PWM_POLARITY_INVERTED>;
-		pwm-dutycycle-unit = <1000>;
-		pwm-dutycycle-range = <100 1000>;
-
-		regulator-min-microvolt = <2000000>;
-		regulator-max-microvolt = <20000000>;
-		regulator-ramp-delay = <1000>;
-	};
-
-	sound {
-		compatible = "axentia,tse850-pcm5142";
-
-		axentia,cpu-dai = <&ssc0>;
-		axentia,audio-codec = <&codec>;
-
-		axentia,add-gpios = <&pioA 8 GPIO_ACTIVE_LOW>;
-		axentia,loop1-gpios = <&pioA 10 GPIO_ACTIVE_LOW>;
-		axentia,loop2-gpios = <&pioA 11 GPIO_ACTIVE_LOW>;
-
-		axentia,ana-supply = <&ana>;
-	};
diff --git a/Documentation/devicetree/bindings/sound/axentia,tse850-pcm5142.yaml b/Documentation/devicetree/bindings/sound/axentia,tse850-pcm5142.yaml
new file mode 100644
index 000000000000..0ab4b697d28e
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/axentia,tse850-pcm5142.yaml
@@ -0,0 +1,104 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/axentia,tse850-pcm5142.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Axentia TSE-850 audio complex
+
+maintainers:
+  - Peter Rosin <peda@axentia.se>
+
+description: |
+  The TSE-850 is an FM Transmitter Station Equipment, designed to generate
+  baseband signals for FM, mainly the DARC subcarrier, but other signals
+  are also possible.
+
+  The schematics explaining the gpios are as follows::
+
+                 loop1 relays
+     IN1 +---o  +------------+  o---+ OUT1
+              \                /
+               +              +
+               |   /          |
+               +--o  +--.     |
+               |  add   |     |
+               |        V     |
+               |      .---.   |
+     DAC +----------->|Sum|---+
+               |      '---'   |
+               |              |
+               +              +
+     IN2 +---o--+------------+--o---+ OUT2
+                 loop2 relays
+
+  The 'loop1' gpio pin controls two relays, which are either in loop
+  position, meaning that input and output are directly connected, or
+  they are in mixer position, meaning that the signal is passed through
+  the 'Sum' mixer. Similarly for 'loop2'.
+
+  In the above, the 'loop1' relays are inactive, thus feeding IN1 to the
+  mixer (if 'add' is active) and feeding the mixer output to OUT1. The
+  'loop2' relays are active, short-cutting the TSE-850 from channel 2.
+  IN1, IN2, OUT1 and OUT2 are TSE-850 connectors and DAC is the PCB name
+  of the (filtered) output from the PCM5142 codec.
+
+properties:
+  compatible:
+    const: axentia,tse850-pcm5142
+
+  axentia,cpu-dai:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description:
+      The phandle of the cpu dai.
+
+  axentia,audio-codec:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description:
+      The phandle of the PCM5142 codec.
+
+  axentia,add-gpios:
+    maxItems: 1
+    description:
+      gpio specifier that controls the mixer.
+
+  axentia,loop1-gpios:
+    maxItems: 1
+    description:
+      gpio specifier that controls loop relays on channel 1.
+
+  axentia,loop2-gpios:
+    maxItems: 1
+    description:
+      gpio specifier that controls loop relays on channel 2.
+
+  axentia,ana-supply:
+    description:
+      Regulator that supplies the output amplifier. Must support voltages in
+      the 2V - 20V range, in 1V steps.
+
+required:
+  - compatible
+  - axentia,cpu-dai
+  - axentia,audio-codec
+  - axentia,add-gpios
+  - axentia,loop1-gpios
+  - axentia,loop2-gpios
+  - axentia,ana-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    #include <dt-bindings/pwm/pwm.h>
+
+    sound {
+        compatible = "axentia,tse850-pcm5142";
+        axentia,cpu-dai = <&ssc0>;
+        axentia,audio-codec = <&codec>;
+        axentia,add-gpios = <&pioA 8 GPIO_ACTIVE_LOW>;
+        axentia,loop1-gpios = <&pioA 10 GPIO_ACTIVE_LOW>;
+        axentia,loop2-gpios = <&pioA 11 GPIO_ACTIVE_LOW>;
+        axentia,ana-supply = <&regulator_ana>;
+    };

---
base-commit: 3d6d817622b0a9721e3cc404df3469171582be13
change-id: 20260813-ti-axtensia-59c88b5f0f17

Best regards,
-- 
Bhargav

Re: [PATCH] ASoC: dt-bindings: tse850: Convert to DT schema

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unused include directive in the DT example.
--

--- Patch [1]: [PATCH] ASoC: dt-bindings: tse850: Convert to DT schema ---
commit fd4229a28be15b03b82f6b00f748cb23a777434c
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

ASoC: dt-bindings: tse850: Convert to DT schema

This commit converts the Axentia TSE-850 audio complex device tree binding 
from a text document to a YAML schema.

> diff --git a/Documentation/devicetree/bindings/sound/axentia,tse850-pcm5142.yaml b/Documentation/devicetree/bindings/sound/axentia,tse850-pcm5142.yaml
> new file mode 100644
> index 0000000000000..0ab4b697d28ea
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/axentia,tse850-pcm5142.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/pwm/pwm.h>

[Severity: Low]
This isn't a bug, but is this include directive for pwm.h still needed?

Since the pwm-regulator node from the original text binding was dropped in the
conversion, no properties in the example use PWM macros. Can this include
be removed to avoid unnecessary dead code in the example block?

> +
> +    sound {
> +        compatible = "axentia,tse850-pcm5142";
> +        axentia,cpu-dai = <&ssc0>;
> +        axentia,audio-codec = <&codec>;
> +        axentia,add-gpios = <&pioA 8 GPIO_ACTIVE_LOW>;
> +        axentia,loop1-gpios = <&pioA 10 GPIO_ACTIVE_LOW>;
> +        axentia,loop2-gpios = <&pioA 11 GPIO_ACTIVE_LOW>;
> +        axentia,ana-supply = <&regulator_ana>;
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260813-ti-axtensia-v1-1-768a1089fd5f@gmail.com?part=1