All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Paunovic <royalnet026@gmail.com>
To: "Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Andy Yan" <andy.yan@rock-chips.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	Marius Dinu <m95d+git@psihoexpert.ro>,
	dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Igor Paunovic <royalnet026@gmail.com>
Subject: [PATCH 0/2] drm/rockchip: Add missing DRM_BRIDGE_CONNECTOR selects
Date: Thu, 13 Aug 2026 16:40:17 +0200	[thread overview]
Message-ID: <20260813144019.12089-1-royalnet026@gmail.com> (raw)

While testing the dw-dp v11 series I noticed that ROCKCHIP_DW_DP does
not select DRM_BRIDGE_CONNECTOR although dw_dp-rockchip.c calls
drm_bridge_connector_init(), and Sebastian suggested handling this
independently of that series [1].

The ROCKCHIP_DW_DP gap was in fact found before: Marius Dinu posted
the same one-liner in March [2] and dropped it when the failure
stopped reproducing in his build. The failure is
configuration-dependent - any other enabled option that selects
DRM_BRIDGE_CONNECTOR masks it - so it can come and go with unrelated
config changes. It still reproduces on current drm-misc-next.

A sweep over drivers/gpu/drm/rockchip found eight callers of
drm_bridge_connector_init(). Five options already select it,
ROCKCHIP_INNO_HDMI gets it through its DRM_INNO_HDMI core option, and
two are left with a latent link failure: ROCKCHIP_DW_DP and
ROCKCHIP_RK3066_HDMI. The rk3066 case additionally needs
DRM_DISPLAY_HELPER, whose module carries the bridge-connector code.

Both failures were reproduced on drm-misc-next (d85a5e9dfb42) with an
arm64 allnoconfig-based configuration enabling only DRM_ROCKCHIP plus
the option in question; with the fixes applied both configurations
link cleanly, and an arm64 defconfig re-run shows no new Kconfig
warnings. Both issues are present in released kernels: the rk3066 one
since v6.16, the dw_dp one since v6.18.

[1] https://lore.kernel.org/r/aneNCDU12OzG99UX@venus
[2] https://lore.kernel.org/r/20260319155051.1944-1-m95d+git@psihoexpert.ro

Igor Paunovic (2):
  drm/rockchip: dw_dp: Select DRM_BRIDGE_CONNECTOR
  drm/rockchip: rk3066_hdmi: Add missing Kconfig selects

 drivers/gpu/drm/rockchip/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.43.0



WARNING: multiple messages have this Message-ID (diff)
From: Igor Paunovic <royalnet026@gmail.com>
To: "Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Andy Yan" <andy.yan@rock-chips.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	Marius Dinu <m95d+git@psihoexpert.ro>,
	dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Igor Paunovic <royalnet026@gmail.com>
Subject: [PATCH 0/2] drm/rockchip: Add missing DRM_BRIDGE_CONNECTOR selects
Date: Thu, 13 Aug 2026 16:40:17 +0200	[thread overview]
Message-ID: <20260813144019.12089-1-royalnet026@gmail.com> (raw)

While testing the dw-dp v11 series I noticed that ROCKCHIP_DW_DP does
not select DRM_BRIDGE_CONNECTOR although dw_dp-rockchip.c calls
drm_bridge_connector_init(), and Sebastian suggested handling this
independently of that series [1].

The ROCKCHIP_DW_DP gap was in fact found before: Marius Dinu posted
the same one-liner in March [2] and dropped it when the failure
stopped reproducing in his build. The failure is
configuration-dependent - any other enabled option that selects
DRM_BRIDGE_CONNECTOR masks it - so it can come and go with unrelated
config changes. It still reproduces on current drm-misc-next.

A sweep over drivers/gpu/drm/rockchip found eight callers of
drm_bridge_connector_init(). Five options already select it,
ROCKCHIP_INNO_HDMI gets it through its DRM_INNO_HDMI core option, and
two are left with a latent link failure: ROCKCHIP_DW_DP and
ROCKCHIP_RK3066_HDMI. The rk3066 case additionally needs
DRM_DISPLAY_HELPER, whose module carries the bridge-connector code.

Both failures were reproduced on drm-misc-next (d85a5e9dfb42) with an
arm64 allnoconfig-based configuration enabling only DRM_ROCKCHIP plus
the option in question; with the fixes applied both configurations
link cleanly, and an arm64 defconfig re-run shows no new Kconfig
warnings. Both issues are present in released kernels: the rk3066 one
since v6.16, the dw_dp one since v6.18.

[1] https://lore.kernel.org/r/aneNCDU12OzG99UX@venus
[2] https://lore.kernel.org/r/20260319155051.1944-1-m95d+git@psihoexpert.ro

Igor Paunovic (2):
  drm/rockchip: dw_dp: Select DRM_BRIDGE_CONNECTOR
  drm/rockchip: rk3066_hdmi: Add missing Kconfig selects

 drivers/gpu/drm/rockchip/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.43.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

             reply	other threads:[~2026-08-13 14:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13 14:40 Igor Paunovic [this message]
2026-08-13 14:40 ` [PATCH 0/2] drm/rockchip: Add missing DRM_BRIDGE_CONNECTOR selects Igor Paunovic
2026-08-13 14:40 ` [PATCH 1/2] drm/rockchip: dw_dp: Select DRM_BRIDGE_CONNECTOR Igor Paunovic
2026-08-13 14:40   ` Igor Paunovic
2026-08-13 14:40 ` [PATCH 2/2] drm/rockchip: rk3066_hdmi: Add missing Kconfig selects Igor Paunovic
2026-08-13 14:40   ` Igor Paunovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260813144019.12089-1-royalnet026@gmail.com \
    --to=royalnet026@gmail.com \
    --cc=airlied@gmail.com \
    --cc=andy.yan@rock-chips.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=lumag@kernel.org \
    --cc=m95d+git@psihoexpert.ro \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.