From: Stanislav Fomichev <sdf.kernel@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, anthony.l.nguyen@intel.com,
przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch,
saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com,
maxime.chevallier@bootlin.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, aleksander.lobakin@intel.com,
horms@kernel.org, magnus.karlsson@intel.com,
maciej.fijalkowski@intel.com, sdf@fomichev.me, ast@kernel.org,
daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com,
witu@nvidia.com, martin.lau@kernel.org,
yoong.siang.song@intel.com, rohan.g.thomas@intel.com,
intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org,
leon@kernel.org
Subject: [PATCH net v2 0/3] xsk: pre-existing AF_XDP TX metadata fixes from Sashiko
Date: Thu, 13 Aug 2026 12:07:57 -0700 [thread overview]
Message-ID: <20260813190800.222527-1-sdf@fomichev.me> (raw)
A few fixes to address pre-existing issues from Sashiko review.
Notes on the feedback from net-next v1 posting [0]:
- It correctly complains about ABI breakage for 32 bit systems, added
an explanation why I think we unlikely to have any 32 bit users with
launch time
- mlx5 batching (pre existing) - I think my point in the comment still
stays (that we do not make it worse)
- stmmac recycled descriptors (pre existing) - seems valid but I don't feel
confident sending a vibe-coded fix
- stmmac queueMaxSDU vs taprio offload - don't think this is real but
we can fix separately later if it is (the existing issue with breaking
xsk seems more real)
v2:
- target net, address clashiko feedback (mostly here and other commit
descriptions)
0: from https://netdev-ai.bots.linux.dev/sashiko/#/message/20260810184753.135756-1-sdf%40fomichev.me
Stanislav Fomichev (3):
xsk: align TX metadata layout across ABIs
xsk: honor XDP_TX_METADATA in zero-copy path
net: stmmac: skip queueMaxSDU check for AF_XDP
drivers/net/ethernet/intel/igc/igc_main.c | 3 ++-
.../ethernet/mellanox/mlx5/core/en/xsk/tx.c | 2 +-
.../net/ethernet/stmicro/stmmac/stmmac_main.c | 10 ++-------
include/net/libeth/xsk.h | 2 +-
include/net/xdp_sock_drv.h | 22 +++++++++++--------
include/net/xsk_buff_pool.h | 3 ++-
include/uapi/linux/if_xdp.h | 1 +
net/xdp/xsk_buff_pool.c | 7 ++++--
tools/include/uapi/linux/if_xdp.h | 1 +
9 files changed, 28 insertions(+), 23 deletions(-)
--
2.53.0-Meta
WARNING: multiple messages have this Message-ID (diff)
From: Stanislav Fomichev <sdf.kernel@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, anthony.l.nguyen@intel.com,
przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch,
saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com,
maxime.chevallier@bootlin.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, aleksander.lobakin@intel.com,
horms@kernel.org, magnus.karlsson@intel.com,
maciej.fijalkowski@intel.com, sdf@fomichev.me, ast@kernel.org,
daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com,
witu@nvidia.com, martin.lau@kernel.org,
yoong.siang.song@intel.com, rohan.g.thomas@intel.com,
intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org,
leon@kernel.org
Subject: [Intel-wired-lan] [PATCH net v2 0/3] xsk: pre-existing AF_XDP TX metadata fixes from Sashiko
Date: Thu, 13 Aug 2026 12:07:57 -0700 [thread overview]
Message-ID: <20260813190800.222527-1-sdf@fomichev.me> (raw)
A few fixes to address pre-existing issues from Sashiko review.
Notes on the feedback from net-next v1 posting [0]:
- It correctly complains about ABI breakage for 32 bit systems, added
an explanation why I think we unlikely to have any 32 bit users with
launch time
- mlx5 batching (pre existing) - I think my point in the comment still
stays (that we do not make it worse)
- stmmac recycled descriptors (pre existing) - seems valid but I don't feel
confident sending a vibe-coded fix
- stmmac queueMaxSDU vs taprio offload - don't think this is real but
we can fix separately later if it is (the existing issue with breaking
xsk seems more real)
v2:
- target net, address clashiko feedback (mostly here and other commit
descriptions)
0: from https://netdev-ai.bots.linux.dev/sashiko/#/message/20260810184753.135756-1-sdf%40fomichev.me
Stanislav Fomichev (3):
xsk: align TX metadata layout across ABIs
xsk: honor XDP_TX_METADATA in zero-copy path
net: stmmac: skip queueMaxSDU check for AF_XDP
drivers/net/ethernet/intel/igc/igc_main.c | 3 ++-
.../ethernet/mellanox/mlx5/core/en/xsk/tx.c | 2 +-
.../net/ethernet/stmicro/stmmac/stmmac_main.c | 10 ++-------
include/net/libeth/xsk.h | 2 +-
include/net/xdp_sock_drv.h | 22 +++++++++++--------
include/net/xsk_buff_pool.h | 3 ++-
include/uapi/linux/if_xdp.h | 1 +
net/xdp/xsk_buff_pool.c | 7 ++++--
tools/include/uapi/linux/if_xdp.h | 1 +
9 files changed, 28 insertions(+), 23 deletions(-)
--
2.53.0-Meta
next reply other threads:[~2026-08-13 19:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 19:07 Stanislav Fomichev [this message]
2026-08-13 19:07 ` [Intel-wired-lan] [PATCH net v2 0/3] xsk: pre-existing AF_XDP TX metadata fixes from Sashiko Stanislav Fomichev
2026-08-13 19:07 ` [PATCH net v2 1/3] xsk: align TX metadata layout across ABIs Stanislav Fomichev
2026-08-13 19:07 ` [Intel-wired-lan] " Stanislav Fomichev
2026-08-17 10:17 ` Simon Horman
2026-08-17 10:17 ` [Intel-wired-lan] " Simon Horman
2026-08-17 12:59 ` Arnd Bergmann
2026-08-17 12:59 ` [Intel-wired-lan] " Arnd Bergmann
2026-08-18 17:03 ` Stanislav Fomichev
2026-08-18 17:03 ` Stanislav Fomichev
2026-08-13 19:07 ` [Intel-wired-lan] [PATCH net v2 2/3] xsk: honor XDP_TX_METADATA in zero-copy path Stanislav Fomichev
2026-08-13 19:07 ` Stanislav Fomichev
2026-08-13 19:08 ` [Intel-wired-lan] [PATCH net v2 3/3] net: stmmac: skip queueMaxSDU check for AF_XDP Stanislav Fomichev
2026-08-13 19:08 ` Stanislav Fomichev
2026-08-17 10:17 ` Simon Horman
2026-08-17 10:17 ` [Intel-wired-lan] " Simon Horman
2026-08-18 10:38 ` Loktionov, Aleksandr
2026-08-18 10:38 ` Loktionov, Aleksandr
2026-08-18 16:24 ` Jakub Kicinski
2026-08-18 17:03 ` Stanislav Fomichev
2026-08-18 18:19 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813190800.222527-1-sdf@fomichev.me \
--to=sdf.kernel@gmail.com \
--cc=aleksander.lobakin@intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=martin.lau@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=mbloch@nvidia.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rohan.g.thomas@intel.com \
--cc=saeedm@nvidia.com \
--cc=sdf@fomichev.me \
--cc=tariqt@nvidia.com \
--cc=witu@nvidia.com \
--cc=yoong.siang.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.