All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vladislav Leonov <vlad@zlab.su>
Cc: linux-rockchip@lists.infradead.org,
	 linux-arm-kernel@lists.infradead.org,
	Simon Glass <sjg@chromium.org>,
	linux-clk@vger.kernel.org,  devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	 Aurelien Jarno <aurelien@aurel32.net>,
	Conor Dooley <conor+dt@kernel.org>,
	 Daniel Golle <daniel@makrotopia.org>,
	Heiko Stuebner <heiko@sntech.de>,
	 Herbert Xu <herbert@gondor.apana.org.au>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
	Olivia Mackall <olivia@selenic.com>,
	 Rob Herring <robh@kernel.org>,
	linux-crypto@vger.kernel.org
Subject: Re: [PATCH 20/25] dt-bindings: rng: rockchip: Add RV1106 compatible
Date: Fri, 14 Aug 2026 12:28:25 +0200	[thread overview]
Message-ID: <20260814-screeching-fragrant-llama-fd2477@quoll> (raw)
In-Reply-To: <20260810121121.210040-21-vlad@zlab.su>

On Mon, Aug 10, 2026 at 03:11:11PM +0300, Vladislav Leonov wrote:
> Add rockchip,rv1106-rng as a variant of rockchip,rk3588-rng, following
> the pattern used for fallback compatibles in the schema (an items list
> with an enum and a matching const fallback), so RV1106 can reuse the
> existing rk3588-rng driver bindings.

All last three lines are redundant, as mentioned in other answer.

> 
> Signed-off-by: Vladislav Leonov <vlad@zlab.su>
> ---
> 
>  .../devicetree/bindings/rng/rockchip,rk3588-rng.yaml  | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml b/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml
> index fcc5be80142d..60ceac2697c0 100644
> --- a/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml
> +++ b/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml
> @@ -13,10 +13,13 @@ maintainers:
>  
>  properties:
>    compatible:
> -    enum:
> -      - rockchip,rk3576-rng
> -      - rockchip,rk3588-rng
> -

Do not remove blank line.

Best regards,
Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vladislav Leonov <vlad@zlab.su>
Cc: linux-rockchip@lists.infradead.org,
	 linux-arm-kernel@lists.infradead.org,
	Simon Glass <sjg@chromium.org>,
	linux-clk@vger.kernel.org,  devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	 Aurelien Jarno <aurelien@aurel32.net>,
	Conor Dooley <conor+dt@kernel.org>,
	 Daniel Golle <daniel@makrotopia.org>,
	Heiko Stuebner <heiko@sntech.de>,
	 Herbert Xu <herbert@gondor.apana.org.au>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
	Olivia Mackall <olivia@selenic.com>,
	 Rob Herring <robh@kernel.org>,
	linux-crypto@vger.kernel.org
Subject: Re: [PATCH 20/25] dt-bindings: rng: rockchip: Add RV1106 compatible
Date: Fri, 14 Aug 2026 12:28:25 +0200	[thread overview]
Message-ID: <20260814-screeching-fragrant-llama-fd2477@quoll> (raw)
In-Reply-To: <20260810121121.210040-21-vlad@zlab.su>

On Mon, Aug 10, 2026 at 03:11:11PM +0300, Vladislav Leonov wrote:
> Add rockchip,rv1106-rng as a variant of rockchip,rk3588-rng, following
> the pattern used for fallback compatibles in the schema (an items list
> with an enum and a matching const fallback), so RV1106 can reuse the
> existing rk3588-rng driver bindings.

All last three lines are redundant, as mentioned in other answer.

> 
> Signed-off-by: Vladislav Leonov <vlad@zlab.su>
> ---
> 
>  .../devicetree/bindings/rng/rockchip,rk3588-rng.yaml  | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml b/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml
> index fcc5be80142d..60ceac2697c0 100644
> --- a/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml
> +++ b/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml
> @@ -13,10 +13,13 @@ maintainers:
>  
>  properties:
>    compatible:
> -    enum:
> -      - rockchip,rk3576-rng
> -      - rockchip,rk3588-rng
> -

Do not remove blank line.

Best regards,
Krzysztof


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2026-08-14 10:28 UTC|newest]

Thread overview: 97+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10 12:10 [PATCH 00/25] ARM: rockchip: Add peripheral support for RV1106 Vladislav Leonov
2026-08-10 12:10 ` Vladislav Leonov
2026-08-10 12:10 ` Vladislav Leonov
2026-08-10 12:10 ` [PATCH 01/25] dt-bindings: reset: Add RV1106 CRU reset definitions Vladislav Leonov
2026-08-10 12:10   ` Vladislav Leonov
2026-08-14 10:15   ` Krzysztof Kozlowski
2026-08-14 10:15     ` Krzysztof Kozlowski
2026-08-20 12:01     ` Heiko Stübner
2026-08-20 12:01       ` Heiko Stübner
2026-08-20 12:09       ` Krzysztof Kozlowski
2026-08-20 12:09         ` Krzysztof Kozlowski
2026-08-10 12:10 ` [PATCH 02/25] clk: rockchip: Add reset controller support for RV1106 Vladislav Leonov
2026-08-10 12:10   ` Vladislav Leonov
2026-08-10 12:10 ` [PATCH 03/25] ARM: dts: rockchip: Add reset bindings to RV1106 Vladislav Leonov
2026-08-10 12:10   ` Vladislav Leonov
2026-08-14 10:16   ` Krzysztof Kozlowski
2026-08-14 10:16     ` Krzysztof Kozlowski
2026-08-10 12:10 ` [PATCH 04/25] dt-bindings: net: rockchip-dwmac: add RV1106 compatible Vladislav Leonov
2026-08-10 12:10   ` Vladislav Leonov
2026-08-10 12:10 ` [PATCH 05/25] net: ethernet: stmicro: stmmac: dwmac-rk: Add RV1106 support Vladislav Leonov
2026-08-10 12:10   ` Vladislav Leonov
2026-08-10 12:10 ` [PATCH 06/25] ARM: dts: rockchip: Add Ethernet GMAC node for RV1106 Vladislav Leonov
2026-08-10 12:10   ` Vladislav Leonov
2026-08-20 11:47   ` Simon Glass
2026-08-20 11:47     ` Simon Glass
2026-08-10 12:10 ` [PATCH 07/25] dt-bindings: phy: rockchip,inno-usb2phy: Add RV1106 compatible Vladislav Leonov
2026-08-10 12:10   ` Vladislav Leonov
2026-08-10 12:10   ` Vladislav Leonov
2026-08-10 12:10 ` [PATCH 08/25] phy: rockchip: inno-usb2: Add support for RV1106 Vladislav Leonov
2026-08-10 12:10   ` Vladislav Leonov
2026-08-10 12:10   ` Vladislav Leonov
2026-08-10 12:11 ` [PATCH 09/25] dt-bindings: usb: rockchip,dwc3: add RV1106 SoC support Vladislav Leonov
2026-08-10 12:11   ` Vladislav Leonov
2026-08-10 12:11 ` [PATCH 10/25] ARM: dts: rockchip: Add USB2 PHY and USB3-OTG (DWC3) nodes for RV1106 Vladislav Leonov
2026-08-10 12:11   ` Vladislav Leonov
2026-08-10 12:11 ` [PATCH 11/25] dt-bindings: i2c: rk3x: Add RV1106 compatible Vladislav Leonov
2026-08-10 12:11   ` Vladislav Leonov
2026-08-14 10:21   ` Krzysztof Kozlowski
2026-08-14 10:21     ` Krzysztof Kozlowski
2026-08-10 12:11 ` [PATCH 12/25] ARM: dts: rockchip: Add I2C nodes for RV1106 Vladislav Leonov
2026-08-10 12:11   ` Vladislav Leonov
2026-08-10 12:11 ` [PATCH 13/25] ARM: dts: rockchip: Add DMAC node " Vladislav Leonov
2026-08-10 12:11   ` Vladislav Leonov
2026-08-10 12:11 ` [PATCH 14/25] ARM: dts: rockchip: Add DMA support to UART nodes Vladislav Leonov
2026-08-10 12:11   ` Vladislav Leonov
2026-08-10 12:11 ` [PATCH 15/25] dt-bindings: clock: rockchip: Add SCLK_IN_SPI1 for RV1106 Vladislav Leonov
2026-08-10 12:11   ` Vladislav Leonov
2026-08-14 10:24   ` Krzysztof Kozlowski
2026-08-14 10:24     ` Krzysztof Kozlowski
2026-08-10 12:11 ` [PATCH 16/25] clk: rockchip: Add SCLK_IN_SPI1 gate " Vladislav Leonov
2026-08-10 12:11   ` Vladislav Leonov
2026-08-10 12:11 ` [PATCH 17/25] dt-bindings: spi: rockchip: Add RV1106 compatible Vladislav Leonov
2026-08-10 12:11   ` Vladislav Leonov
2026-08-10 12:25   ` Mark Brown
2026-08-10 12:25     ` Mark Brown
2026-08-10 12:11 ` [PATCH 18/25] spi: rockchip: Add support for RV1106 Vladislav Leonov
2026-08-10 12:11   ` Vladislav Leonov
2026-08-14 10:23   ` Krzysztof Kozlowski
2026-08-14 10:23     ` Krzysztof Kozlowski
2026-08-10 12:11 ` [PATCH 19/25] ARM: dts: rockchip: Add SPI nodes " Vladislav Leonov
2026-08-10 12:11   ` Vladislav Leonov
2026-08-10 12:11 ` [PATCH 20/25] dt-bindings: rng: rockchip: Add RV1106 compatible Vladislav Leonov
2026-08-10 12:11   ` Vladislav Leonov
2026-08-14 10:28   ` Krzysztof Kozlowski [this message]
2026-08-14 10:28     ` Krzysztof Kozlowski
2026-08-10 12:11 ` [PATCH 21/25] ARM: dts: rockchip: Add RNG node for RV1106 Vladislav Leonov
2026-08-10 12:11   ` Vladislav Leonov
2026-08-10 12:11 ` [PATCH 22/25] ARM: dts: rockchip: Add SDMMC1 " Vladislav Leonov
2026-08-10 12:11   ` Vladislav Leonov
2026-08-10 12:11 ` [PATCH 23/25] ARM: dts: rockchip: add arm,cpu-registers-not-fw-configured to RV1106 timer node Vladislav Leonov
2026-08-10 12:11   ` Vladislav Leonov
2026-08-20 11:47   ` Simon Glass
2026-08-20 11:47     ` Simon Glass
2026-08-10 12:11 ` [PATCH 24/25] dt-bindings: pwm: rockchip: Add RV1106 compatible Vladislav Leonov
2026-08-10 12:11   ` Vladislav Leonov
2026-08-11  5:39   ` Uwe Kleine-König
2026-08-11  5:39     ` Uwe Kleine-König
2026-08-10 12:11 ` [PATCH 25/25] ARM: dts: rockchip: Add PWM nodes for RV1106 Vladislav Leonov
2026-08-10 12:11   ` Vladislav Leonov
2026-08-10 18:35 ` [PATCH 00/25] ARM: rockchip: Add peripheral support " Jakub Kicinski
2026-08-10 18:35   ` Jakub Kicinski
2026-08-10 18:35   ` Jakub Kicinski
2026-08-11  5:43   ` Uwe Kleine-König
2026-08-11  5:43     ` Uwe Kleine-König
2026-08-11  5:43     ` Uwe Kleine-König
2026-08-11 15:53     ` Jakub Kicinski
2026-08-11 15:53       ` Jakub Kicinski
2026-08-11 15:53       ` Jakub Kicinski
2026-08-11 16:06     ` Mark Brown
2026-08-11 16:06       ` Mark Brown
2026-08-11 16:06       ` Mark Brown
2026-08-14 10:18     ` Krzysztof Kozlowski
2026-08-14 10:18       ` Krzysztof Kozlowski
2026-08-14 10:18       ` Krzysztof Kozlowski
2026-08-20 11:47 ` Simon Glass
2026-08-20 11:47   ` Simon Glass
2026-08-20 11:47   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260814-screeching-fragrant-llama-fd2477@quoll \
    --to=krzk@kernel.org \
    --cc=aurelien@aurel32.net \
    --cc=conor+dt@kernel.org \
    --cc=daniel@makrotopia.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=nicolas.frattaroli@collabora.com \
    --cc=olivia@selenic.com \
    --cc=robh@kernel.org \
    --cc=sjg@chromium.org \
    --cc=vlad@zlab.su \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.