* [PATCH] EDAC/xgene: Use platform_get_irq() for IRQ lookup
@ 2026-08-14 4:53 phucduc.bui
0 siblings, 0 replies; only message in thread
From: phucduc.bui @ 2026-08-14 4:53 UTC (permalink / raw)
To: Khuong Dinh, Borislav Petkov, Tony Luck, linux-edac, linux-kernel
Cc: bui duc phuc
From: bui duc phuc <phucduc.bui@gmail.com>
The probe function propagates any negative return value from
platform_get_irq_optional() and aborts the probe. Therefore, the
optional IRQ semantics of platform_get_irq_optional() are not used
here.
Use platform_get_irq() instead, which matches the existing error
handling by propagating any IRQ lookup error.
platform_get_irq() also reports lookup errors itself, so remove the
redundant error message from the driver.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
drivers/edac/xgene_edac.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c
index 9955396c9a52..aae7e03b0573 100644
--- a/drivers/edac/xgene_edac.c
+++ b/drivers/edac/xgene_edac.c
@@ -1915,9 +1915,8 @@ static int xgene_edac_probe(struct platform_device *pdev)
int i;
for (i = 0; i < 3; i++) {
- irq = platform_get_irq_optional(pdev, i);
+ irq = platform_get_irq(pdev, i);
if (irq < 0) {
- dev_err(&pdev->dev, "No IRQ resource\n");
rc = irq;
goto out_err;
}
--
2.43.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-08-14 4:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-14 4:53 [PATCH] EDAC/xgene: Use platform_get_irq() for IRQ lookup phucduc.bui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.