From: Rob Herring <robh@kernel.org>
To: Esben Haabendal <esben@geanix.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Nikita Travkin" <nikita@trvn.ru>,
"Maslov Dmitry" <maslovdmitry@seeed.cc>,
"Kuppuswamy Sathyanarayanan"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"Thomas Gleixner" <tglx@kernel.org>,
"Pan Chuang" <panchuang@vivo.com>,
"Yangtao Li" <frank.li@vivo.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH v4 3/7] dt-bindings: iio: light: ltr501: Add ltr329 compatible
Date: Fri, 14 Aug 2026 12:56:24 -0500 [thread overview]
Message-ID: <20260814175624.GE1981719-robh@kernel.org> (raw)
In-Reply-To: <tpb0KaOIsxWHbx0VIdiP5udap2Qu9DAIOdN6iBaAbpWnGqMfGOgZwRQQlJOddirF99RdD6n1FVMxlSKmrRJW8lLo7pqKKAXwN9MUBT9DKAU=@geanix.com>
On Fri, Aug 14, 2026 at 06:18:55AM +0000, Esben Haabendal wrote:
> On Monday, August 10th, 2026 at 17:50, Rob Herring <robh@kernel.org> wrote:
>
> > On Mon, Aug 10, 2026 at 09:11:13AM +0200, Esben Haabendal wrote:
> > > LTR-329ALS-01 is an ambient light sensor similar to LTR-303ALS-01, but
> > > without interrupt support.
> > >
> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > > Acked-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> > > Signed-off-by: Esben Haabendal <esben@geanix.com>
> > > ---
> > > Documentation/devicetree/bindings/iio/light/liteon,ltr501.yaml | 1 +
> > > 1 file changed, 1 insertion(+)
> >
> > sashiko issue should be addressed.
>
> What about the suggestion about adding `proximity-near-level: false` to the condition. I am thinking something like this is more correct
>
> properties:
> proximity-near-level: false
>
> allOf:
> - if:
> properties:
> compatible:
> contains:
> enum:
> - liteon,ltr501
> - liteon,ltr559
> then:
> properties:
> proximity-near-level: true
That does not work. The if/then can only add restrictions, not relax
them. It can do allowed->not-allowed, but not vice-versa as you have.
Rob
next prev parent reply other threads:[~2026-08-14 17:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 7:11 [PATCH v4 0/7] iio: light: ltr501: Add ltr329 support Esben Haabendal
2026-08-10 7:11 ` [PATCH v4 1/7] dt-bindings: iio: light: ltr501: Sort compatible enum array Esben Haabendal
2026-08-10 7:11 ` [PATCH v4 2/7] dt-bindings: iio: light: ltr501: Add missing ltr303 compatible Esben Haabendal
2026-08-10 7:11 ` [PATCH v4 3/7] dt-bindings: iio: light: ltr501: Add ltr329 compatible Esben Haabendal
2026-08-10 7:19 ` sashiko-bot
2026-08-10 15:50 ` Rob Herring
2026-08-12 12:41 ` Esben Haabendal
2026-08-13 19:20 ` Rob Herring
2026-08-14 6:12 ` Esben Haabendal
2026-08-14 6:18 ` Esben Haabendal
2026-08-14 12:39 ` Esben Haabendal
2026-08-14 17:56 ` Rob Herring [this message]
2026-08-10 7:11 ` [PATCH v4 4/7] iio: light: ltr501: Power down chip if request irq fails Esben Haabendal
2026-08-10 7:23 ` sashiko-bot
2026-08-10 7:11 ` [PATCH v4 5/7] iio: light: ltr501: Fix duplicated error message Esben Haabendal
2026-08-10 7:11 ` [PATCH v4 6/7] iio: light: ltr501: Add ltr329 driver support Esben Haabendal
2026-08-10 7:24 ` sashiko-bot
2026-08-10 19:57 ` Andy Shevchenko
2026-08-12 12:51 ` Esben Haabendal
2026-08-10 7:11 ` [PATCH v4 7/7] iio: light: ltr501: Fix sorting order of device arrays Esben Haabendal
2026-08-10 19:59 ` [PATCH v4 0/7] iio: light: ltr501: Add ltr329 support Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260814175624.GE1981719-robh@kernel.org \
--to=robh@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=esben@geanix.com \
--cc=frank.li@vivo.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maslovdmitry@seeed.cc \
--cc=nikita@trvn.ru \
--cc=nuno.sa@analog.com \
--cc=panchuang@vivo.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.